From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E4DCC31E49 for ; Wed, 19 Jun 2019 14:30:45 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 5FBA02182B for ; Wed, 19 Jun 2019 14:30:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5FBA02182B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B4CE11C2FE; Wed, 19 Jun 2019 16:30:43 +0200 (CEST) Received: from mail-io1-f66.google.com (mail-io1-f66.google.com [209.85.166.66]) by dpdk.org (Postfix) with ESMTP id 1299D1C2EF for ; Wed, 19 Jun 2019 16:30:42 +0200 (CEST) Received: by mail-io1-f66.google.com with SMTP id n5so38582942ioc.7 for ; Wed, 19 Jun 2019 07:30:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=uYqN5A2bts1FF9kSCr8fJ9t+flawZmUNlZ2z+88BUSw=; b=hFiWF97R1sPvWMyToYSsHJlGlCeUK5TKtyX6kAyQb1VWLEkDJjIWCWpHqa1Kxdt+NJ sMbvq0etSyO6K4EljSaMJlZ+urTJP7s4JweAq5clscVWOr74UeTVeyLekEbNFQqphLyx tlNWlBs/ylRvjPeI9fspu8XtvZ+HUDlei0Gp91MjtPW7dehQv211WopNAXCtfeDrXc47 T078jQoFLYJJysZu2393BZrJ+MAfnPiC68hPiMYs5xyWIG3IsGKm6rnOG2CXcET7/lmf hzxI0poqQ6UtbPkZPnuXfIpgGeFJEQHWzx/HHAPjcAeyzx1w7fgOY6e6YIcnAPKHYYcC p1aw== X-Gm-Message-State: APjAAAUf1AMtMHjwSa2p73y0yuIfmWgDuY//wsRkRUNToIpY9YIq4M1C kdY9R3BrW+ooLDCNWMpBfupF8kDL1VRgEuzR5P+h8w== X-Google-Smtp-Source: APXvYqyTU15wTUsuso0FUAs246z0kn2U8a0cQ2M1+GnFh1S5AJ6+sOHEU96IU36m47tL8G56xRvn+t2J8J/uEUnh0oA= X-Received: by 2002:a02:c6b8:: with SMTP id o24mr51748613jan.80.1560954641449; Wed, 19 Jun 2019 07:30:41 -0700 (PDT) MIME-Version: 1.0 References: <20190618105950.9599-1-andrius.sirvys@intel.com> <49C20589590A5F43815A562C49658C1E70D38D90@IRSMSX101.ger.corp.intel.com> In-Reply-To: From: David Marchand Date: Wed, 19 Jun 2019 16:30:30 +0200 Message-ID: To: "Sirvys, Andrius" Cc: dpdk stable , "Lu, Wenzhuo" , "Wu, Jingjing" , "Iremonger, Bernard" , "Yigit, Ferruh" , dev Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] test-pmd: removed references to crc_strip X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Jun 19, 2019 at 4:23 PM David Marchand wrote: > > On Wed, Jun 19, 2019 at 4:13 PM Sirvys, Andrius > wrote: > >> That sounds like a good idea. Do you have any examples by chance of >> something like this or any advice how to implement. >> >> The string needs to be generated beforehand so where would we be able to >> put the code in for that. >> > > For the usage strings, you only need to call a wrapper that dynamically > outputs the list separated by |. > For the > cmd_config_per_port_rx_offload/cmd_config_per_port_rx_offload_result_offload > tokens init, you have an example with cmd_set_fwd_retry_mode_init() which > updates cmd_set_fwd_retry_mode/cmd_setfwd_retry_mode tokens. > See: https://git.dpdk.org/dpdk/commit/?id=769ce6b17835 -- David Marchand