From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23F06C4321A for ; Fri, 28 Jun 2019 13:32:15 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id B6075208E3 for ; Fri, 28 Jun 2019 13:32:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B6075208E3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DB2373798; Fri, 28 Jun 2019 15:32:13 +0200 (CEST) Received: from mail-vs1-f66.google.com (mail-vs1-f66.google.com [209.85.217.66]) by dpdk.org (Postfix) with ESMTP id 6B8CC3798 for ; Fri, 28 Jun 2019 15:32:12 +0200 (CEST) Received: by mail-vs1-f66.google.com with SMTP id 2so4034330vso.8 for ; Fri, 28 Jun 2019 06:32:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WXNgenwVaRlsHPg5zqF0+HV2Y/6JXm7+q01U7QkgYd4=; b=R+I+MhfTgNs3Ye+HFAkV8AzG9x8Duw63raBlev+hunfc9W6lEuwTtZiX/t852IHCDp qAQ8ACPD1hIqQ3njKmStQKaAOONPw8EttbN3QoL9dDb6gYgqbigqhQoS9L2PB2bk1+C3 jREOM5QA0jJlDg1a5GaWNyEF4vWa3/LZSLLVMM7Q9znUS6KgnivRsyeIk+Tb6dhDwgDz Oj0vj5357N6Y+p2QXgDO5iYreWCVsXKJKsdaHiurFvS0ZXhwm4EbZUw7fY2Rk3jQoCwD r0BvDpUyfmMFpH3RZg9VIaIqEPAdIcW/lo9LpuIiY2/Dahoxgkj7rsL0Uzkh4QYYiq5P 46Pw== X-Gm-Message-State: APjAAAV6qLZHzwL28G9eMf+2waBeRHpGob6EWnLK+XJSYAUyDYKlsCPB YJTLrH2nmtvGJ4gyUfCcfjo4MTxez61vux7uUOcgPg== X-Google-Smtp-Source: APXvYqzbZ00ok3xi+xbgCoQzVzZzDXv4ZjiTKgfw0WXHQB/up/QXASvDbB7AKVXbAI9S4n0NRE4GKck+WF/gZYzpZ9Q= X-Received: by 2002:a67:f998:: with SMTP id b24mr6341119vsq.180.1561728731739; Fri, 28 Jun 2019 06:32:11 -0700 (PDT) MIME-Version: 1.0 References: <1559638792-8608-1-git-send-email-david.marchand@redhat.com> <1560580950-16754-1-git-send-email-david.marchand@redhat.com> <1560580950-16754-9-git-send-email-david.marchand@redhat.com> In-Reply-To: From: David Marchand Date: Fri, 28 Jun 2019 15:32:00 +0200 Message-ID: To: Ferruh Yigit Cc: dev , Thomas Monjalon , Aaron Conole , Michael Santana , dpdk stable , Honnappa Nagarahalli , Jerin Jacob Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2 08/15] test/rcu: remove arbitrary limit on max core count X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Jun 28, 2019 at 2:57 PM Ferruh Yigit wrote: > On 6/15/2019 7:42 AM, David Marchand wrote: > > We can have up to RTE_MAX_LCORE in a dpdk application. > > Remove the limit on 128 cores and tests that are now always false. > > > > Fixes: b87089b0bb19 ("test/rcu: add API and functional tests") > > Cc: stable@dpdk.org > > > > Signed-off-by: David Marchand > > <...> > > > @@ -664,12 +643,12 @@ static struct rte_hash *init_hash(void) > > goto test_fail; > > > > /* Make sure the actual number of cores provided is less than > > - * TEST_RCU_MAX_LCORE. This will allow for some threads not > > + * RTE_MAX_LCORE. This will allow for some threads not > > * to be registered on the QS variable. > > */ > > - if (num_cores >= TEST_RCU_MAX_LCORE) { > > + if (num_cores >= RTE_MAX_LCORE) { > > printf("Test failed! number of cores provided should be > less than %d\n", > > - TEST_RCU_MAX_LCORE); > > + RTE_MAX_LCORE); > > goto test_fail; > > } > > > > > > Hi David, > > This is causing build error for arm [1] since in config they have > "CONFIG_RTE_MAX_LCORE=256" > Can we make 'num_cores' 'uint16_t'? > > [1] > .../dpdk/app/test/test_rcu_qsbr_perf.c:649:16: error: comparison is always > false > due to limited range of data type [-Werror=type-limits] > if (num_cores >= RTE_MAX_LCORE) { > ^~ > I checked and I am not reproducing it in travis arm64 compilation, but did not investigate why. Indeed there is an issue, I can send a patch to fix, but Honnappa also reported it and sent a patch [1]. 1: http://patchwork.dpdk.org/patch/55530/ -- David Marchand