From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Marchand <david.marchand@redhat.com>
Subject: Re: [PATCH v2] eal: fix core number validation
Date: Thu, 3 Jan 2019 14:03:02 +0100
Message-ID: <CAJFAV8wmDuNnx2Yms_0gSkUpg7s3g-2C0S_uuH6ZBcrekCQ-Sg@mail.gmail.com>
References: <1546518487-9942-1-git-send-email-hari.kumarx.vemula@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Cc: dev@dpdk.org, stable@dpdk.org, reshma.pattan@intel.com,
 "Yigit, Ferruh" <ferruh.yigit@intel.com>, jananeex.m.parthasarathy@intel.com
To: Hari kumar Vemula <hari.kumarx.vemula@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-ua1-f53.google.com (mail-ua1-f53.google.com
 [209.85.222.53]) by dpdk.org (Postfix) with ESMTP id AAA2F1B11A
 for <dev@dpdk.org>; Thu,  3 Jan 2019 14:03:14 +0100 (CET)
Received: by mail-ua1-f53.google.com with SMTP id z11so10888171uaa.10
 for <dev@dpdk.org>; Thu, 03 Jan 2019 05:03:14 -0800 (PST)
In-Reply-To: <1546518487-9942-1-git-send-email-hari.kumarx.vemula@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu, Jan 3, 2019 at 1:28 PM Hari kumar Vemula <
hari.kumarx.vemula@intel.com> wrote:

> When incorrect core value or range provided,
> as part of -l command line option, a crash occurs.
>
> Added valid range checks to fix the crash.
>
> Fixes: d888cb8b9613 ("eal: add core list input format")
> Cc: stable@dpdk.org
>
> --
> v2: Replace strtoul with strtol
>     Modified log message
>

You did not take my other comments into account and the ut updates are
missing.


-- 
David Marchand