From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DCCEBC43331 for ; Mon, 30 Mar 2020 13:25:27 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 67A4420733 for ; Mon, 30 Mar 2020 13:25:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Ct4fp9xi" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 67A4420733 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3AD852BEA; Mon, 30 Mar 2020 15:25:26 +0200 (CEST) Received: from us-smtp-delivery-74.mimecast.com (us-smtp-delivery-74.mimecast.com [63.128.21.74]) by dpdk.org (Postfix) with ESMTP id BE6582B8B for ; Mon, 30 Mar 2020 15:25:24 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1585574724; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KojqCOwPlBsVZiT405+vULf/NrU6atv6JPY58npiR+o=; b=Ct4fp9xipqGWANvInms3Zgd+TZIkVhQi6YVNyiqEeDSaP2jFetRf342W0xYTGthVLOaQ2e brcoKGppVGtbYIs+KLXeaKdlCQtklM/u9ACjyOmmIAnAPEila/nJRe1KxJqB8mU/1gG/zf +HW+3YVDnqetLhyymEx5pVycklMcLrA= Received: from mail-vs1-f71.google.com (mail-vs1-f71.google.com [209.85.217.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-344-3r6J6ppUPvmV-ciI1G79hg-1; Mon, 30 Mar 2020 09:25:20 -0400 X-MC-Unique: 3r6J6ppUPvmV-ciI1G79hg-1 Received: by mail-vs1-f71.google.com with SMTP id x185so4088184vsc.15 for ; Mon, 30 Mar 2020 06:25:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/AVSEhYu37jCi0hNsjr0l1sl9FrKS7t7ag1ArgLGSgE=; b=hDnhc75Z9DywqSR/ns3tp6OClZaJjct6a/g4B7IDu+VptYBAJS3R5aPGZVcHsaibMk pujmMmkgWRsL9cHzvtvmqfFUVRzl6wswsctDFJ7tN+Wflad9ZuhxGEfKT+ZbWNl6v0bW UKIQwmwJ9uAWLSRCoe9pm8BU0JSGcsfHCzVW6yoWvWq0YUkHmSM/5MzcQ0UDlyurWhKH qIUJRuI9v2C015EsSgsneqC+gX2xHG2MeH3jFN2+0LPNtJpmTNeHz0BlF04QnvNfxhl3 L8GqUJADuX8iPHvpRO9BK07ztVRc8fsm9y57EpLAI/Igr5Y8eCs8/ubvnLqoY4FsYK49 Xx3g== X-Gm-Message-State: AGi0PubWEXSKMdRfjaS3uZKKanQErJYnk/xJy5WAwNsOpdYIR73AmWxw QYv4to2uiSU+TP6d2SMhCjFXcAKSjcTaNIWtVYZecaTVuLj91Vx2cQiADSUds3y6BW5GR5nKxMY kjpMu/2ZarSkFCjdPqaM= X-Received: by 2002:a67:2c81:: with SMTP id s123mr8198196vss.198.1585574719974; Mon, 30 Mar 2020 06:25:19 -0700 (PDT) X-Google-Smtp-Source: APiQypIqICSil5MlSZBWiamG/PjotFpvx4+GScoYUcEIX2ebQgpcwQOro5zcGnjYacCcWoKFYUHfmTgzFOOzALwWC1w= X-Received: by 2002:a67:2c81:: with SMTP id s123mr8198157vss.198.1585574719651; Mon, 30 Mar 2020 06:25:19 -0700 (PDT) MIME-Version: 1.0 References: <20200320001220.150235-1-thomas@monjalon.net> <20200327011540.954014-1-thomas@monjalon.net> <20200327011540.954014-7-thomas@monjalon.net> In-Reply-To: <20200327011540.954014-7-thomas@monjalon.net> From: David Marchand Date: Mon, 30 Mar 2020 15:25:07 +0200 Message-ID: To: Thomas Monjalon Cc: dev , Neil Horman , John McNamara , Marko Kovacevic , Hemant Agrawal , Sachin Saxena , Matan Azrad , Shahaf Shuler , Viacheslav Ovsiienko , Gagandeep Singh , Akhil Goyal , Nipun Gupta , Ferruh Yigit , Cristian Dumitrescu , Harry van Haaren , Bruce Richardson , Phil Yang , Joyce Kong , Anatoly Burakov , =?UTF-8?Q?Mattias_R=C3=B6nnblom?= , Olivier Matz X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v2 6/8] eal: move common header files X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Mar 27, 2020 at 2:17 AM Thomas Monjalon wrote= : > > The EAL API (with doxygen documentation) is moved from > common/include/ to include/, which makes more clear that > it is the global API for all environments and architectures. > > Note that the arch-specific and OS-specific include files are not > in this global include directory, but include/generic/ should > cover the doxygen documentation for them. > > Signed-off-by: Thomas Monjalon This patch breaks the installation of common headers with meson, hence breaking the compilation of external applications (like examples). [snip] > diff --git a/lib/librte_eal/meson.build b/lib/librte_eal/meson.build > index 1fc532139b..a433f46ade 100644 > --- a/lib/librte_eal/meson.build > +++ b/lib/librte_eal/meson.build > @@ -5,6 +5,8 @@ > # have a straight list of headers and source files. > # Initially pull in common settings > eal_inc =3D [global_inc] > +subdir('include') > + > subdir('common') > > # Now do OS/exec-env specific settings, including building kernel module= s > @@ -27,5 +29,5 @@ if cc.has_header('getopt.h') > endif > sources +=3D env_sources > objs =3D env_objs > -headers =3D common_headers + env_headers > +headers =3D env_headers > includes +=3D eal_inc Works with fix: diff --git a/lib/librte_eal/meson.build b/lib/librte_eal/meson.build index a433f46ad..23ae03ad4 100644 --- a/lib/librte_eal/meson.build +++ b/lib/librte_eal/meson.build @@ -29,5 +29,5 @@ if cc.has_header('getopt.h') endif sources +=3D env_sources objs =3D env_objs -headers =3D env_headers +headers +=3D env_headers includes +=3D eal_inc --=20 David Marchand