From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35A95C76190 for ; Mon, 22 Jul 2019 19:38:55 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id C326C216F4 for ; Mon, 22 Jul 2019 19:38:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C326C216F4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7769E1BF35; Mon, 22 Jul 2019 21:38:53 +0200 (CEST) Received: from mail-vs1-f68.google.com (mail-vs1-f68.google.com [209.85.217.68]) by dpdk.org (Postfix) with ESMTP id 598B81BF32 for ; Mon, 22 Jul 2019 21:38:52 +0200 (CEST) Received: by mail-vs1-f68.google.com with SMTP id y16so27094762vsc.3 for ; Mon, 22 Jul 2019 12:38:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=LVeC5v1yR8QksF+XcDn61+ZzJjYKdQ2y5HMxLVlYRrk=; b=P7TCQ7JCYZ+2OaWXMosu3fq3IBOSjNnXX0N51X9MS5PKVAW8MOocNyG9GyJz8jdFq/ w6Ztko18ALFF5tw/Gl8hGoRuCZQFESeMR2tgF5Lryx8VObU2XlDv8iEHCV+mCX6mji67 XhJtlHrahhSWkGw9h1zJEfbtuhl9it5CM9Wuz+CMKe1dCMa9NRDj9CQ+UU8ZCEdQZ+UE rHfoI4+ZYyX+LZAoL1Q5Y4+NYj7NTzU5wzlUpBeSc0a60/xylDSiBf+CscdHSRMv/Thc AxNw0lt3ZvGVXdC4L1R465tOJjMs7aUHfCwP9SsOfIxrUWf6+tlmTinu8yN+wdYDcpve 2HVQ== X-Gm-Message-State: APjAAAVLpGECxEIm/LKTw6/caR9QE1jaMXHEk5tSysSDdI0y354Bd4Gl RU1o8E0vo/YKJubRBfqp9A2Z2FE5oLc6K1rbots/1Q== X-Google-Smtp-Source: APXvYqxxfcd1d7HrIirLXCJIb4d1muC7/BtnLi0FyXDTYod2oLysqQtjCqNnpTUJ7qGiug/DK2l/hjh5UvRKqLnSeaQ= X-Received: by 2002:a67:f998:: with SMTP id b24mr44608672vsq.180.1563824331651; Mon, 22 Jul 2019 12:38:51 -0700 (PDT) MIME-Version: 1.0 References: <20190717115852.171416-1-ndabilpuram@marvell.com> <20190718143628.169623-1-ndabilpuram@marvell.com> In-Reply-To: <20190718143628.169623-1-ndabilpuram@marvell.com> From: David Marchand Date: Mon, 22 Jul 2019 21:38:40 +0200 Message-ID: To: Nithin Dabilpuram , Thomas Monjalon Cc: Hyong Youb Kim , Ferruh Yigit , Jerin Jacob Kollanukkaran , John Daley , Shahed Shaikh , dev Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v4 0/3] vfio: fix broken msix interrupt initialization X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Jul 18, 2019 at 4:36 PM Nithin Dabilpuram wrote: > > A final patch for below mentioned RFC patch discussions. > > [RFC PATCH v3 1/3] vfio: revert change that does intr eventfd setup at probe > http://mails.dpdk.org/archives/dev/2019-July/138358.html > [RFC PATCH v3 2/3] eal: add mask and unmask interrupt APIs > http://mails.dpdk.org/archives/dev/2019-July/138357.html > [RFC PATCH v3 3/3] drivers/net: use unmask API in interrupt handlers > http://mails.dpdk.org/archives/dev/2019-July/138359.html > > Please also refer to below discussions > http://mails.dpdk.org/archives/dev/2019-July/138184.html > http://mails.dpdk.org/archives/dev/2019-July/138113.html > > This patch set basically reverts vfio patch that moves eventfd setup > to probe time (1/3) because msix initialization is broken. > It adds new ack interrupt api for purposes of simple and light > weight ack method and also to avoid race conditions > that was the root cause of this discussion. Thanks a lot for working on this. I only have small comments (sent in separate mails), you already did all the work. I prepared incremental patches if you agree with those comments: - patch 2 https://github.com/david-marchand/dpdk/commit/374acb3409c206ffcb1bf6b5a7e8bb0bfca4e2b9 - patch 3 https://github.com/david-marchand/dpdk/commit/71102b9301b2a55a057a605f8e48e4a24f9d74a3 And a squashed branch: https://github.com/david-marchand/dpdk/commits/interrupt_fixes -- David Marchand