From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56C4CC432C0 for ; Wed, 20 Nov 2019 17:29:03 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id D71002071B for ; Wed, 20 Nov 2019 17:29:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="E1UialSf" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D71002071B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3A3532C36; Wed, 20 Nov 2019 18:29:02 +0100 (CET) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) by dpdk.org (Postfix) with ESMTP id DEAEA2C2B for ; Wed, 20 Nov 2019 18:29:00 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1574270940; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XhWX+HOXiiE03P7vOxag+FAlQDazJXWn7uhhYMh0tyM=; b=E1UialSfAnVpka4b1U0Y3FFW3EgchXN5jU/RvUpWeEmFyfl//vt0iFZs4Xe3YJ5rj1DJUV hSieNZEDDkijb5Li6o4DUzVBdC7m1K0DVsIm861kikVCLD5ZXEguYfollHjbsD81LANyiu eFTF65/TfFrBPKLAQVqJHefldCUYIyg= Received: from mail-vk1-f200.google.com (mail-vk1-f200.google.com [209.85.221.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-413-trwtEinXPkaQVqyndrT5eA-1; Wed, 20 Nov 2019 12:28:58 -0500 Received: by mail-vk1-f200.google.com with SMTP id x65so111040vkd.15 for ; Wed, 20 Nov 2019 09:28:58 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=XhWX+HOXiiE03P7vOxag+FAlQDazJXWn7uhhYMh0tyM=; b=sJIf8YOAL1c1TjLtGUU3zlgQHCnbhYUdMnrySPFfPxjtRzyYtABS4EwQjouxO24HSk eweyCCqkSFynzrk8C8qclmUz5z+voAJHzDBKK4nOT6HJfFwGMkrmk9KnJd+UV/Huc0ZJ bLyRhWOk0UQw/XNhN9413+IxzB4RhtaSRKW5LfGFq1dHtWJDQTImtIUGo/dRrgV/naCJ i2mIpooD4Jn0MsbcixWz8tmU+n2ddR0GP7/ne5ijvJI4rX3jppn5wHYYl71Wzhu1CpAV W2PazRpeafnpaKm1fYjjcmGAxZxA9tZ+ELdQ1NmIBJWH9X9PyDULqozCvt/Ib0Kphp1+ cFHQ== X-Gm-Message-State: APjAAAVTBm4YWLweLq2v2fHq5yPsGN7Gx0ukn4JregMxD45uWm9OxVav nO9bqqR7MG6QpCm7iVAZG3LcdiLDlpbK8/ItNGRKQBCWC1K+5OQrG9dmPMwY4gAVwL9dGfvqXG2 DdKdNa81SywI1+nvZze8= X-Received: by 2002:ab0:48ab:: with SMTP id x40mr2542740uac.126.1574270938060; Wed, 20 Nov 2019 09:28:58 -0800 (PST) X-Google-Smtp-Source: APXvYqyWf9OcQN6EGNEUonOKr1sBWmII5I2y+JW5DQTXvpH3uEt4oVggf2a9E1V31J13a3+Ha+ajJ3ZET60aRUE4wtw= X-Received: by 2002:ab0:48ab:: with SMTP id x40mr2542704uac.126.1574270937516; Wed, 20 Nov 2019 09:28:57 -0800 (PST) MIME-Version: 1.0 References: <20191120160009.46270-1-ferruh.yigit@intel.com> <20191120172227.42798-1-ferruh.yigit@intel.com> In-Reply-To: <20191120172227.42798-1-ferruh.yigit@intel.com> From: David Marchand Date: Wed, 20 Nov 2019 18:28:46 +0100 Message-ID: To: Vamsi Attunuru , Jerin Jacob Cc: John McNamara , Marko Kovacevic , dev , Kiran Kumar K , Igor Ryzhov , Ferruh Yigit X-MC-Unique: trwtEinXPkaQVqyndrT5eA-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v2] kni: increase kernel version requirement for VA X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Nov 20, 2019 at 6:22 PM Ferruh Yigit wrote= : > > A build error reported related to the selected > 'get_user_pages_remote()' kernel API: > > .../kernel/linux/kni/kni_dev.h:113:8: > error: too few arguments to function =E2=80=98get_user_pages_remote=E2= =80=99 > ret =3D get_user_pages_remote(tsk, tsk->mm, iova, 1 > ^~~~~~~~~~~~~~~~~~~~~ > > Currently there are three version of the 'get_user_pages_remote()' > supported, based on kernel version > < 4.9, =3D 4.9, > 4.9 > > These version based checks are not working fine with the distro kernels > which is the cause of reported build error. The error reported by the > kernel version 4.8, but it is using API defined in > 4.9. > > To be able to take control of this, and possible more, related build > error, increasing the minimum supported kernel version for iova=3Dva with > KNI to kernel version 4.9. > > This leaves us with single version of the kernel API and more > manageable. > > Signed-off-by: Ferruh Yigit Jerin, Vamsi, Is this okay for you? Thanks. --=20 David Marchand