From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2078DC3A5A2 for ; Tue, 3 Sep 2019 08:06:46 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id AF39E21881 for ; Tue, 3 Sep 2019 08:06:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AF39E21881 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 019281E545; Tue, 3 Sep 2019 10:06:45 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 2B6331D168 for ; Tue, 3 Sep 2019 10:06:43 +0200 (CEST) Received: from mail-vs1-f71.google.com (mail-vs1-f71.google.com [209.85.217.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6116520260 for ; Tue, 3 Sep 2019 08:06:42 +0000 (UTC) Received: by mail-vs1-f71.google.com with SMTP id l24so2229460vsq.1 for ; Tue, 03 Sep 2019 01:06:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=Cq25RSJRJXmX/pIbLjQXnukKTc+QMdgCQZyalXOVu44=; b=Xk3X5gP0sLQdvDEzYg6GtIeeYErDDA8DSeGuYuh1HHhhVUFEZqdm228ud0XuzQLFYW 8ov8WtR1dp3ZrAJCT9C4QoI+BxiKj7WHUpiHceFOZLkWIDWSevCysxAmDGyvu3bYWOgw s74xQ6b6eIbYvb1pSx4jE1OAQE+MqnhIST4KWIZQyl/lgTXGsUl+YPRH0mAaykayVUWK u9lYepoMErAzqamwnPSSsEtFDlaOWBaW8Ys3OdVUSEnfQWM3QGCN/RQHebNF5I7QmPMG lCb79L0ecomgWZ53AOFEDd+r7cmMPyhX2SQ4jBmEY+sUEpq+OLM7V4RbNfss3i0iuztP INIw== X-Gm-Message-State: APjAAAUel5ZzWzgNm/pTaYS9Qt5b7VHib3guxcZ5Cz/HWVOCzXkCEdku bsYsGER6UkovoEL7Ldez1Q2+I68cBfoUYjQ2aE1zbG5CM6EW7LUvn13DFbkb3U6wskQ2NCqlO1p niHPsMs2GkQg2aNmJilw= X-Received: by 2002:ab0:30e1:: with SMTP id d1mr822191uam.41.1567498001569; Tue, 03 Sep 2019 01:06:41 -0700 (PDT) X-Google-Smtp-Source: APXvYqy6e7WrFVy6j0nFmhPJyozuzlJMWP1KPShQlf6qsqQCl6+NJwqMZshbPHlxm5XydUfty0W4lRanRfjb+DNVNUs= X-Received: by 2002:ab0:30e1:: with SMTP id d1mr822175uam.41.1567498001267; Tue, 03 Sep 2019 01:06:41 -0700 (PDT) MIME-Version: 1.0 References: <1566214919-32250-1-git-send-email-david.marchand@redhat.com> <1566214919-32250-11-git-send-email-david.marchand@redhat.com> <7eea5375-25e7-47c8-a522-e74b7267836c@intel.com> In-Reply-To: <7eea5375-25e7-47c8-a522-e74b7267836c@intel.com> From: David Marchand Date: Tue, 3 Sep 2019 10:06:30 +0200 Message-ID: To: Ferruh Yigit Cc: dev , "John W. Linville" , Xiaolong Ye , Qi Zhang , Igor Russkikh , Pavel Belous , Allain Legacy , Matt Peters , Ravi Kumar , Rasesh Mody , Shahed Shaikh , Ajit Khaparde , Somnath Kotur , Chas Williams , Hemant Agrawal , Sachin Saxena , Wenzhuo Lu , Marcin Wojtas , Michal Krawczyk , Guy Tzalik , Evgeny Schemeilin , Gagandeep Singh , John Daley , Hyong Youb Kim , Gaetan Rivet , Xiao Wang , Ziyang Xuan , Xiaoyun Wang , Guoyang Zhou , Beilei Xing , Jingjing Wu , Qiming Yang , Rosen Xu , Konstantin Ananyev , Shijith Thotton , Srisivasubramanian Srinivasan , Jakub Grajciar , Matan Azrad , Shahaf Shuler , Yongseok Koh , Viacheslav Ovsiienko , Zyta Szpak , Liron Himi , Tomasz Duszynski , Stephen Hemminger , "K. Y. Srinivasan" , Haiyang Zhang , Alejandro Lucero , Tetsuya Mukawa , Jerin Jacob , Bruce Richardson , Jasvinder Singh , Cristian Dumitrescu , Jan Remes , Rastislav Cernay , Keith Wiles , Maciej Czekaj , Maxime Coquelin , Tiwei Bie , Zhihong Wang , Yong Wang Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH 10/11] drivers/net: use new logtype wrapper X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Sep 2, 2019 at 6:11 PM Ferruh Yigit wrote: > > On 8/19/2019 12:41 PM, David Marchand wrote: > > Make use of the newly introduced wrapper. > > > > Signed-off-by: David Marchand > > <...> > > > diff --git a/drivers/net/mlx4/mlx4.c b/drivers/net/mlx4/mlx4.c > > index 931e4f4..c71b68e 100644 > > --- a/drivers/net/mlx4/mlx4.c > > +++ b/drivers/net/mlx4/mlx4.c > > @@ -1274,16 +1274,14 @@ glue_error: > > > > #endif > > > > +RTE_LOG_REGISTER(mlx4_logtype, "pmd.net.mlx4", > > + RTE_LOG_NOTICE, RTE_LOGTYPE_PMD); > > + > > btw, compiler is complaining about the ';' for mlx4/5 because of the peda= ntic > parameter: > > error: ISO C does not allow extra =E2=80=98;=E2=80=99 outside of a functi= on [-Werror=3Dpedantic] > Oops, I thought I had fixed it before sending the series.. thanks. -- David Marchand