From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C54ACA9EAF for ; Thu, 24 Oct 2019 19:27:54 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id E617C2070B for ; Thu, 24 Oct 2019 19:27:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E617C2070B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 41A5A1EBEE; Thu, 24 Oct 2019 21:27:53 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 502F31EBEC for ; Thu, 24 Oct 2019 21:27:51 +0200 (CEST) Received: from mail-vs1-f72.google.com (mail-vs1-f72.google.com [209.85.217.72]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 94F884E83C for ; Thu, 24 Oct 2019 19:27:50 +0000 (UTC) Received: by mail-vs1-f72.google.com with SMTP id p21so401542vso.14 for ; Thu, 24 Oct 2019 12:27:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=kRHPJd7Wko75dq/PkxBETRbgDz9vtv0So1KzKSI69/U=; b=EeugzOux/kmGg1lkgqejy+iE5Re8FV/thElzk+GFdkcA3Vi4uKwO5P/6fZ70Uvnmiu jCblN2EOGicZuiLpgANjo2OVKBPyRPkkrH/UjbeK7z8Dx5eEzbS8s/efQpPVISwDuyCn AZUn4wANIHOrjRBWK6em6JtoGB697qwfFoF91X4k69AI2XlXrJbMCZBXGqaEF2txf1jp I0wW3PIDQBkqvAmzEqf5NEK8Fffi4pYlQSbZZtVID/lH3QcPpTM+4nW1jU8oRD6dgpK/ XyhNDm2HxnObZX8RLUHWO4Kd3axBF4QfKDzQf8kFNAlMnpGdmozko8/entHD9c/s4oHb TxrQ== X-Gm-Message-State: APjAAAXrr71MCDX/jtGI07vvzhK4rL9OpQQ+s9ERgCNbAsjLK3YfH1wS 2ASzegMIBWMv4PNY0BFuoNk3v0Hfjuo7Gtcvq7Uc9ISAgWuoHM/2unFMVScjGlVKlCiLY6X4k1A Jfk9Dyc1S9rtJi65Nx2E= X-Received: by 2002:a1f:3811:: with SMTP id f17mr5433vka.56.1571945269644; Thu, 24 Oct 2019 12:27:49 -0700 (PDT) X-Google-Smtp-Source: APXvYqyXeo2GYp2/GhQip7PDXBAKMmDYUzm/5YOil5UJhmSNow/Rm2uZNX/Hm287uEOHfqS1z/8O/mGoTd3tH8SvnSE= X-Received: by 2002:a1f:3811:: with SMTP id f17mr5416vka.56.1571945269237; Thu, 24 Oct 2019 12:27:49 -0700 (PDT) MIME-Version: 1.0 References: <1565807801-72546-1-git-send-email-drc@linux.vnet.ibm.com> <1565807801-72546-3-git-send-email-drc@linux.vnet.ibm.com> In-Reply-To: From: David Marchand Date: Thu, 24 Oct 2019 21:27:38 +0200 Message-ID: To: Maxime Coquelin , Tiwei Bie Cc: David Christensen , dev Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH 2/2] vhost: fix build error caused by 64bit print formatting X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Aug 19, 2019 at 1:41 PM Maxime Coquelin wrote: > On 8/19/19 10:40 AM, David Marchand wrote: > > On Thu, Aug 15, 2019 at 6:16 PM David Christensen > > wrote: > >> > >>>> Use of %llx print formatting causes meson build error on Power syste= ms with > >>>> RHEL 7.6 and gcc 4.8.5. Replace with PRIx64 macro. > >>>> > >>>> + (uint64_t)reg_struct.range.start, > >>>> + (uint64_t)reg_struct.range.start + > >>>> + (uint64_t)reg_struct.range.len - 1); > >> > >> I didn't need them when compiling on Power but it's the only way I cou= ld > >> get x86 to build without any warning: > >> > >> cc -Ilib/lib@@rte_vhost@sta -Ilib -I../lib -Ilib/librte_vhost > >> -I../lib/librte_vhost -I. -I../ -Iconfig -I../config > >> -Ilib/librte_eal/common/include -I../lib/librte_eal/common/include > >> -I../lib/librte_eal/linux/eal/include -Ilib/librte_eal/common > >> -I../lib/librte_eal/common -Ilib/librte_eal/common/include/arch/x86 > >> -I../lib/librte_eal/common/include/arch/x86 -Ilib/librte_eal > >> -I../lib/librte_eal -Ilib/librte_kvargs -I../lib/librte_kvargs > >> -Ilib/librte_ethdev -I../lib/librte_ethdev -Ilib/librte_net > >> -I../lib/librte_net -Ilib/librte_mbuf -I../lib/librte_mbuf > >> -Ilib/librte_mempool -I../lib/librte_mempool -Ilib/librte_ring > >> -I../lib/librte_ring -Ilib/librte_meter -I../lib/librte_meter > >> -Ilib/librte_cryptodev -I../lib/librte_cryptodev -Ilib/librte_hash > >> -I../lib/librte_hash -Ilib/librte_pci -I../lib/librte_pci -pipe > >> -D_FILE_OFFSET_BITS=3D64 -Wall -Winvalid-pch -O3 -include rte_config.h > >> -Wunused-parameter -Wsign-compare -Wcast-qual -D_GNU_SOURCE -fPIC > >> -march=3Dnative -fno-strict-aliasing -DALLOW_EXPERIMENTAL_API -MD -MQ > >> 'lib/lib@@rte_vhost@sta/librte_vhost_vhost_user.c.o' -MF > >> 'lib/lib@@rte_vhost@sta/librte_vhost_vhost_user.c.o.d' -o > >> 'lib/lib@@rte_vhost@sta/librte_vhost_vhost_user.c.o' -c > >> ../lib/librte_vhost/vhost_user.c > >> ../lib/librte_vhost/vhost_user.c: In function =E2=80=98vhost_user_set_= mem_table=E2=80=99: > >> ../lib/librte_vhost/vhost_user.c:1088:4: warning: format =E2=80=98%lx= =E2=80=99 expects > >> argument of type =E2=80=98long unsigned int=E2=80=99, but argument 4 h= as type =E2=80=98__u64=E2=80=99 > >> [-Wformat=3D] > >> RTE_LOG(INFO, VHOST_CONFIG, > >> ^ > >> ../lib/librte_vhost/vhost_user.c:1088:4: warning: format =E2=80=98%lx= =E2=80=99 expects > >> argument of type =E2=80=98long unsigned int=E2=80=99, but argument 5 h= as type =E2=80=98__u64=E2=80=99 > >> [-Wformat=3D] > >> > >> This system was also RHEL 7.6 with gcc 4.8.5-36 > > > > Ok, I run the same. > > The catch is that I did not have RTE_LIBRTE_VHOST_POSTCOPY enabled in > > my working environment (using make) while meson enables it as long as > > userfaultd.h is present. > > > > Maxime, Tiwei, > > > > Can't we use uintXX_t instead of (what looks to me) kernel types __uXX = ? > > > > > > That actually comes from a kernel header (linux/userfaultfd.h), so I > would say no. Sorry, I had forgotten about this patch. Seems fine to me then. Maxime, Tiwei? --=20 David Marchand