From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Marchand <david.marchand@redhat.com>
Subject: Re: [PATCH v6] eal: fix core number validation
Date: Thu, 17 Jan 2019 13:32:21 +0100
Message-ID: <CAJFAV8y2QJr6w87_S_3eks8bYoDKB70asHoVdCx=8+ZxvBCBtw@mail.gmail.com>
References: <1547216106-13680-1-git-send-email-hari.kumarx.vemula@intel.com>
 <1547727192-25126-1-git-send-email-hari.kumarx.vemula@intel.com>
 <20190117121916.GA319108@bricha3-MOBL.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Cc: Hari Kumar Vemula <hari.kumarx.vemula@intel.com>, dev@dpdk.org,
 reshma.pattan@intel.com,
 "Yigit, Ferruh" <ferruh.yigit@intel.com>, jananeex.m.parthasarathy@intel.com,
 dpdk stable <stable@dpdk.org>
To: Bruce Richardson <bruce.richardson@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-vk1-f196.google.com (mail-vk1-f196.google.com
 [209.85.221.196]) by dpdk.org (Postfix) with ESMTP id 812992082
 for <dev@dpdk.org>; Thu, 17 Jan 2019 13:32:33 +0100 (CET)
Received: by mail-vk1-f196.google.com with SMTP id s184so2220308vkd.6
 for <dev@dpdk.org>; Thu, 17 Jan 2019 04:32:33 -0800 (PST)
In-Reply-To: <20190117121916.GA319108@bricha3-MOBL.ger.corp.intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu, Jan 17, 2019 at 1:19 PM Bruce Richardson <bruce.richardson@intel.com>
wrote:

> On Thu, Jan 17, 2019 at 12:13:12PM +0000, Hari Kumar Vemula wrote:
> > When incorrect core value or range provided,
> > as part of -l command line option, a crash occurs.
> >
> > Added valid range checks to fix the crash.
> >
> > Added ut check for negative core values.
> > Added unit test case for invalid core number range.
> >
> > Fixes: d888cb8b9613 ("eal: add core list input format")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Hari Kumar Vemula <hari.kumarx.vemula@intel.com>
> > Reviewed-by: David Marchand <david.marchand@redhat.com>
> > --
> > v6: Changed testcase order
> > v5: Corrected unit test case for -l option
> > v4: Used RTE_MAX_LCORE for max core check
> > v3: Added unit test cases for invalid core number range
> > v2: Replace strtoul with strtol
> >     Modified log message
> > ---
> >  lib/librte_eal/common/eal_common_options.c |  9 +++-
> >  test/test/test_eal_flags.c                 | 61 ++++++++++++++--------
> >  2 files changed, 45 insertions(+), 25 deletions(-)
> >
> Is this patch related to, or does it fix Bugzilla #19?
>
> https://bugs.dpdk.org/show_bug.cgi?id=19


Separate issue, from my pov.
I would say the issue happens with a dpdk process that has no cpu available
wrt CONFIG_RTE_MAX_CORES.
eal_auto_detect_cores() then removes all cores from cfg->lcore_role[], then
eal_adjust_config() an incorrect master lcore is chosen at
cfg->master_lcore = rte_get_next_lcore(-1, 0, 0); ?


-- 
David Marchand