From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0961C432C0 for ; Wed, 20 Nov 2019 19:51:20 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 5B6002068F for ; Wed, 20 Nov 2019 19:51:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="VXjkHyy0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5B6002068F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3072027D; Wed, 20 Nov 2019 20:51:19 +0100 (CET) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by dpdk.org (Postfix) with ESMTP id 9302DA3 for ; Wed, 20 Nov 2019 20:51:17 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1574279476; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Md0GJwvkLpopALYXlfXEGKEnoVw9ukDUL9X7spHdU1A=; b=VXjkHyy0r6ZXT8oipTq1WQ/9kDcvOkNe5euQk0gHgxoQ7g0R7cgYVszgbCo+O09r7wVZSC hvVVzjpohlR+25uClQzDAYvmt2obv8EHV761iitWIRXrRzTLxI245FoUgLNyGO5PFTnl2z bCQJs5buX6lQSIquu6tzgVbVz1mPU/M= Received: from mail-vk1-f199.google.com (mail-vk1-f199.google.com [209.85.221.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-430-NA4Lfy8CNdaRNbVztLukCQ-1; Wed, 20 Nov 2019 14:51:15 -0500 Received: by mail-vk1-f199.google.com with SMTP id i124so310444vkc.2 for ; Wed, 20 Nov 2019 11:51:15 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=UAG6EHtDKUh7z+NRZ9hkEcZeq/GqM2KOWMGqNldaoXg=; b=UQM9HC7IVfFk/fLV2S2IlAL68sVOA8LAvebEQjv5dLcKo3/yacmrH1vmj8GGGr7iQf M1UebRkrtx4m8qy0CCevIRfLNgscqpDCxuAO5n1oZtwIcU/7yvCSZL8LCL4QNJtGccRu TB6/7/z8NSJwRfACxYEzbOGGuAMsTKrWfoiOM5P/3b77cK851r7phoi74Myaer7sYelt LvNdVngg9aF2MjEEDdXQHLlldp2LjoUUaFDYDVI9uKHAqbyBAr6rCnbvwQdOjuaFXRWy n4Vx14OXSxJB24eHCVGSVQu4e7ByurruzWMV+CCoBxuGon+SqwuArGRb00XSv20/PqO7 zUxw== X-Gm-Message-State: APjAAAWRjeEONLEGrMTUPZJwYaxtjsLv4iMwYBf7TDWRtMXmvA/eO/+l MuOvxI9rIKruJ/CROm+FZqjnAlJzE12POtSqHFguIuRoE66EqNjVnSrTQCd5H6mXhem/bGJZof3 PTo+yVh9xXkVbsRD5vpE= X-Received: by 2002:ab0:189a:: with SMTP id t26mr3029236uag.87.1574279474897; Wed, 20 Nov 2019 11:51:14 -0800 (PST) X-Google-Smtp-Source: APXvYqzdoFCIyDC2w2qVrABspupPolQCCLxI/7XAeMnyCWyv+qe5EXhsnbpbhPzGqf/EKGlyO2xsu19HbRaAYZ45aXM= X-Received: by 2002:ab0:189a:: with SMTP id t26mr3029210uag.87.1574279474375; Wed, 20 Nov 2019 11:51:14 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: David Marchand Date: Wed, 20 Nov 2019 20:51:03 +0100 Message-ID: To: Anatoly Burakov Cc: dev , Thomas Monjalon X-MC-Unique: NA4Lfy8CNdaRNbVztLukCQ-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v8 01/12] config: change ABI versioning to global X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Nov 20, 2019 at 6:23 PM Anatoly Burakov wrote: > > From: Marcin Baran > > As per new ABI policy [1], all of the libraries are now versioned using > one global ABI version. Stable libraries use the MAJOR.MINOR ABI > version for their shared objects, while experimental libraries > use the 0.MAJORMINOR convention for their versioning. > Experimental library versioning is managed globally. Changes in this > patch implement the necessary steps to enable that. The next patch just removes the config entry CONFIG_RTE_MAJOR_ABI while this patch entirely removes its usage. I squashed patch 2 in patch 1 and added its commitlog here. > > [1] https://doc.dpdk.org/guides/contributing/abi_policy.html > > Signed-off-by: Marcin Baran > Signed-off-by: Pawel Modrak > Signed-off-by: Anatoly Burakov > Acked-by: Bruce Richardson [snip] > diff --git a/mk/rte.lib.mk b/mk/rte.lib.mk > index 4df8849a08..3b318a5306 100644 > --- a/mk/rte.lib.mk > +++ b/mk/rte.lib.mk > @@ -11,20 +11,16 @@ EXTLIB_BUILD ?=3D n > # VPATH contains at least SRCDIR > VPATH +=3D $(SRCDIR) > > -ifneq ($(CONFIG_RTE_MAJOR_ABI),) > -ifneq ($(LIBABIVER),) > -LIBABIVER :=3D $(CONFIG_RTE_MAJOR_ABI) > -endif > +ifneq ($(shell grep -s "^DPDK_" $(SRCDIR)/$(EXPORT_MAP)),) > +LIBABIVER :=3D $(shell cat $(RTE_SRCDIR)/ABI_VERSION) > +else > +# EXPERIMENTAL ABI is versioned as 0.major+minor, e.g. 0.201 for 20.1 AB= I > +LIBABIVER :=3D 0.$(shell cat $(RTE_SRCDIR)/ABI_VERSION | td -d '.') s/td/tr/ Will fix while applying. --=20 David Marchand