Re: [dpdk-dev] [PATCH v4 4/9] eal: introduce thread uninit helper

[David Marchand <david.marchand@redhat.com>]

On Tue, Jun 30, 2020 at 11:42 AM Olivier Matz <olivier.matz@6wind.com> wrote:
> > diff --git a/lib/librte_eal/include/rte_trace_point.h b/lib/librte_eal/include/rte_trace_point.h
> > index 377c2414aa..686b86fdb1 100644
> > --- a/lib/librte_eal/include/rte_trace_point.h
> > +++ b/lib/librte_eal/include/rte_trace_point.h
> > @@ -230,6 +230,15 @@ __rte_trace_point_fp_is_enabled(void)
> >  __rte_experimental
> >  void __rte_trace_mem_per_thread_alloc(void);
> >
> > +/**
> > + * @internal
> > + *
> > + * Free trace memory buffer per thread.
> > + *
> > + */
> > +__rte_experimental
> > +void __rte_trace_mem_per_thread_free(void);
>
> Maybe the doc comment could be reworded a bit
> (and the empty line can be removed by the way).

Copy/paste.
If we keep this symbol, I'll reword.


>
> > +
> >  /**
> >   * @internal
> >   *
> > diff --git a/lib/librte_eal/rte_eal_version.map b/lib/librte_eal/rte_eal_version.map
> > index 0d42d44ce9..5831eea4b0 100644
> > --- a/lib/librte_eal/rte_eal_version.map
> > +++ b/lib/librte_eal/rte_eal_version.map
> > @@ -393,6 +393,9 @@ EXPERIMENTAL {
> >       rte_trace_point_lookup;
> >       rte_trace_regexp;
> >       rte_trace_save;
> > +
> > +     # added in 20.08
> > +     __rte_trace_mem_per_thread_free;
>
> Is it really needed to export this function?
>

There is no need for the series.

When an application non-EAL thread (not talking about threads that
dpdk is aware of) calls a tracepoint callback, there is an implicit
call to _alloc.
We end up with a memory leak and the application has no way to fix this.
I left this symbol exported, but this is not documented properly.


-- 
David Marchand