From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 380DCC433DF for ; Mon, 29 Jun 2020 09:07:37 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id C49BC23159 for ; Mon, 29 Jun 2020 09:07:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="bEUe9qQG" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C49BC23159 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1C3071B13C; Mon, 29 Jun 2020 11:07:36 +0200 (CEST) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) by dpdk.org (Postfix) with ESMTP id CFDD52C01 for ; Mon, 29 Jun 2020 11:07:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1593421654; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=nOFOUECf+fGx0NjUVNi4apOVju3bpbEbRr5S5CMURsg=; b=bEUe9qQG/FWygk/eBc7BMjRr7RJuEuNXJ1IfSZVETKMvdtAt7HWiMUrJRBIBMo95JvdNAj u7U8AU6vIncWEwV3zM73bUGMiL1T42HtEVwYttbcDhxvdjeHegvuF6lf7XSAjozAQM4uYK reTz3HHueU4EmPvBiKzYKQ6cOfzLRzA= Received: from mail-vk1-f197.google.com (mail-vk1-f197.google.com [209.85.221.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-254-Z6l42g_EPdiwyud4T3ZhTQ-1; Mon, 29 Jun 2020 05:07:32 -0400 X-MC-Unique: Z6l42g_EPdiwyud4T3ZhTQ-1 Received: by mail-vk1-f197.google.com with SMTP id m22so2553477vka.22 for ; Mon, 29 Jun 2020 02:07:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=nOFOUECf+fGx0NjUVNi4apOVju3bpbEbRr5S5CMURsg=; b=oKy02mX+DYVs0WgFcg5RgLAa0XdBrC7KgIWTRHNPkdEhE6wfQTEYHCQvo8WE3A7s7L 2ifyEyfZWiOUNqwP1UiDVmqmOGZPRHoXbSnMF9vn3K22KUnO+Jg/7ahsKW0pjCarSWKF coh4kGlGxInC01HvkOdQDnVLcHtGSLd1RwT9d7EENizWolwjvTRnACxFXksaCJf4uo9o yp0Nc7bD+/kzMXBOXcnL9kVkGaIg0aekc0rWJSY+gjZcyWL6wfE9eFbV2V4no4WXEmzF wNvN7TSNDHijXOOhmt0nX+Pf654wDmaRDtXdMlhNC3+azonFTGZRT82m7oWSGcuvtqFL nysA== X-Gm-Message-State: AOAM533szgUgODjIopNsQYTWwklKQ9MRfmicXt6PCgVpk2Gy/s/9qato w7kXqOSdylQ3Q7rfChv4B5rQSXS9j7Y9Zxz8kZOhf0FV87IMoiMBTlG3X2WRIFJ33wjMZ7yarVa q2G4APtnFYaplDAJcnSQ= X-Received: by 2002:ab0:2c3:: with SMTP id 61mr9683985uah.87.1593421652003; Mon, 29 Jun 2020 02:07:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxyJwvmxtVNB+2mPtTzreOzf22Cxfe38qyFNfHJFTTq6UO7eDkoYPdzFN/RQkuqP9JUQBFmUkEsa9Mec6BmnQc= X-Received: by 2002:ab0:2c3:: with SMTP id 61mr9683972uah.87.1593421651772; Mon, 29 Jun 2020 02:07:31 -0700 (PDT) MIME-Version: 1.0 References: <20200610144506.30505-1-david.marchand@redhat.com> <20200626144736.11011-1-david.marchand@redhat.com> <20200626144736.11011-5-david.marchand@redhat.com> In-Reply-To: From: David Marchand Date: Mon, 29 Jun 2020 11:07:20 +0200 Message-ID: To: Jerin Jacob Cc: dpdk-dev , "Richardson, Bruce" , Ray Kinsella , Thomas Monjalon , Andrew Rybchenko , Kevin Traynor , Ian Stokes , Ilya Maximets , Jerin Jacob , Sunil Kumar Kori , Neil Horman , Harini Ramakrishnan , Omar Cardona , Pallavi Kadam , Ranjit Menon X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v4 4/9] eal: introduce thread uninit helper X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Jun 26, 2020 at 5:00 PM Jerin Jacob wrote: > > On Fri, Jun 26, 2020 at 8:18 PM David Marchand > wrote: > > > > This is a preparation step for dynamically unregistering threads. > > > > Since we explicitly allocate a per thread trace buffer in > > rte_thread_init, add an internal helper to free this buffer. > > > > Signed-off-by: David Marchand > > --- > > Note: I preferred renaming the current internal function to free all > > threads trace buffers (new name trace_mem_free()) and reuse the previous > > name (trace_mem_per_thread_free()) when freeing this buffer for a given > > thread. > > > > Changes since v2: > > - added missing stub for windows tracing support, > > - moved free symbol to exported (experimental) ABI as a counterpart of > > the alloc symbol we already had, > > > > Changes since v1: > > - rebased on master, removed Windows workaround wrt traces support, > > > +/** > > + * Uninitialize per-lcore info for current thread. > > + */ > > +void rte_thread_uninit(void); > > + > > Is it a public API? I guess not as it not adding in .map file. > If it is private API, Is n't it better to change as eal_thread_ like > another private API in eal_thread.h? Before this series, we have: - rte_thread_ public APIs for both EAL and non-EAL threads (declared in rte_eal_interrupts.h and rte_lcore.h), - eal_thread_ internal APIs that apply to EAL threads (declared in eal_thread.h), I guess __rte_thread_ could do the trick and I will move this to eal_private.h. -- David Marchand