From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D23FC43603 for ; Wed, 4 Dec 2019 12:31:30 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id DD50D20833 for ; Wed, 4 Dec 2019 12:31:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="BxjE0ior" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DD50D20833 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EB5FC1BF6E; Wed, 4 Dec 2019 13:31:28 +0100 (CET) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by dpdk.org (Postfix) with ESMTP id 56FCE1BE84 for ; Wed, 4 Dec 2019 13:31:27 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1575462686; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Mw7f3kvjHpkIutKqd9RBUiplhMyhrxAO0peBeLNUS5k=; b=BxjE0iorbmJ6qBgYnzuXuFSav6TLaPiZii81+/oWSa3VCDuKSpsnwN2NaBhmkZDTIts3gy nUtGoXCqjeEl2EspXA0VSRzW1BrVRpVxcCjZlisGYXsOLCsY83ibR+nH6SCoxwTAh0i7DS NFpdiQtJeNsS09/ilVMLqzH1E59FFbk= Received: from mail-vk1-f200.google.com (mail-vk1-f200.google.com [209.85.221.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-359-NAtsQLfuN7m6WYP9r69Z7Q-1; Wed, 04 Dec 2019 07:31:26 -0500 Received: by mail-vk1-f200.google.com with SMTP id y23so2890163vkn.7 for ; Wed, 04 Dec 2019 04:31:25 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=Mw7f3kvjHpkIutKqd9RBUiplhMyhrxAO0peBeLNUS5k=; b=fuLHUHah6loQ2QVdEJufjZ0pFN544viAMz5FEPHAHTCZKcJtz9glE1OEYT4JMZUm1p eSqwZxJWjV+Jd8c8oFRUBDgsTlyJRl0cRjGlLZHh3oqxqiySKebTMS2kS5e/agwLcHnO Sap6qCUS6QRaJ8XbOCnegtS/PEak3pfWwdsW7CynxJ5RMs/mycsXAaPMw4di9jn6M4/l hNzgS7Mtb+jCgg/DRB/ehqQhbmrXtyOEW6IEoGzgN8Y7rZvM7nEmHUxrbWxonqsgo3H0 vF7FcpPzrg8yg3oVIL8fwHnbxuEoNDIRuPCnJmY/UJ7OaWhoku2nQQIlfFhnkL3UWr7Z 4qiQ== X-Gm-Message-State: APjAAAU7lKKeW4EnRC4hXc+zUtDn0o25Cji30s3qRZVqLmMrNbV8qywh 1CbkYUs1sn9rOur5B6jJWto42RHvz0O1aNrxHrNZVZUcWJCDTdICvQNlmqnMScGY6wHtkkbuOuB 7VoqExCbx3TYiwXzYQvk= X-Received: by 2002:ab0:3495:: with SMTP id c21mr2257966uar.86.1575462683828; Wed, 04 Dec 2019 04:31:23 -0800 (PST) X-Google-Smtp-Source: APXvYqzs31pjEKcWum6FPBWthTokc3U8JGWF6SW83jxU1mF2BFcyTorV5MECV4s2RGL01dbAklbzy+8coBz0wfgucAM= X-Received: by 2002:ab0:3495:: with SMTP id c21mr2257928uar.86.1575462683211; Wed, 04 Dec 2019 04:31:23 -0800 (PST) MIME-Version: 1.0 References: <20191127223232.26404-1-stephen@networkplumber.org> In-Reply-To: From: David Marchand Date: Wed, 4 Dec 2019 13:31:11 +0100 Message-ID: To: Andrew Rybchenko Cc: Stephen Hemminger , dev , dpdk stable X-MC-Unique: NAtsQLfuN7m6WYP9r69Z7Q-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] eal: fix unitialized data warning X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Dec 4, 2019 at 1:17 PM Andrew Rybchenko wrote: > > On 12/4/19 2:12 PM, David Marchand wrote: > > Fixed title s/unitialized/uninitialized/ > > > > On Wed, Nov 27, 2019 at 11:32 PM Stephen Hemminger > > wrote: > >> > >> Valgrind reports that eal interrupt thread is calling epoll_ctl > >> with uninitialized data. Trivial to fix by initializing it. > > > > Added a note on it being a Valgrind false positive. > > > > > >> Fixes: af75078fece3 ("first public release") > >> Cc: stable@dpdk.org > > > >> Signed-off-by: Stephen Hemminger > > Acked-by: David Marchand > > > > Applied, thanks. > > It breaks build on RHEL 7.6 gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-36): > > lib/librte_eal/linux/eal/eal_interrupts.c: In function > =E2=80=98eal_intr_thread_main=E2=80=99: > lib/librte_eal/linux/eal/eal_interrupts.c:1048:9: error: missing > initializer for field =E2=80=98events=E2=80=99 of =E2=80=98struct epoll_e= vent=E2=80=99 > [-Werror=3Dmissing-field-initializers] > struct epoll_event ev =3D { }; > ^ > In file included from lib/librte_eal/linu/eal/eal_interrupts.c:15:0: > /usr/include/sys/epoll.h:89:12: note: =E2=80=98events=E2=80=99 declared h= ere > uint32_t events; /* Epoll events */ > ^ Erf, indeed, I ran the tests on a different system than my laptop... Need more coffee, those initializers are always a pain. I'll go with a memset. Best first commit for a release, I suppose. -- David Marchand