From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1DC9FC32750 for ; Fri, 2 Aug 2019 11:14:07 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id D1F3D20665 for ; Fri, 2 Aug 2019 11:14:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D1F3D20665 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id F290A1C25C; Fri, 2 Aug 2019 13:14:04 +0200 (CEST) Received: from mail-vk1-f194.google.com (mail-vk1-f194.google.com [209.85.221.194]) by dpdk.org (Postfix) with ESMTP id D673E1C258 for ; Fri, 2 Aug 2019 13:14:03 +0200 (CEST) Received: by mail-vk1-f194.google.com with SMTP id b69so15290588vkb.3 for ; Fri, 02 Aug 2019 04:14:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=v/reLp3sQzpiObB/XVYLNJUp/9DR+h0QwzCOHhlwme4=; b=EdaofbsjPbQGZhr72/V96RCSnHwcfh1FK60KFNMDMU8aki3PxjtZUrIB4y2B/yqkAB oEVUDfabAiGPGqFWLle1wpOjJDfTPx9XaYWO2Lcep9Q57QHEPPAtNi7OoghQbgOW3cAN ckqPWC6WCweR5J6vEiqDHEJzVVVuwBxgRcjr4MsPYvxYMgZx6YId+rJBm+zo43P6lKv2 Y5vi5OGvEBj/7aqrGC9sSJ2RCoU0i++rloK8OG8AfrVP6DNpcjtNAVnmQQPXUWqbEB6A u2JlxUM1SyzBNdSB1x2SwJSFEJXIeAzSJLN0x3k/P3vnXlZlO5Gq2QGIbsCteXKP4Vo0 oDBA== X-Gm-Message-State: APjAAAVf/xC/NPufZIir0uQ3eEyiAEw+IpX59LUrCmYeP9WwCr3LPzZ/ ilKG/g91JNgCPzYUYjSgYzvPGnwOrsFcsdFeiMD7hK85 X-Google-Smtp-Source: APXvYqzYbm5WnlHv8OiLFZ3Jq4VQGkITbJaIemzthpcGnV/vPkaech9LGHx6ZEzvmHxYp/x8uMz636aQhJGrNMuXxEw= X-Received: by 2002:a1f:9f06:: with SMTP id i6mr52999110vke.52.1564744443017; Fri, 02 Aug 2019 04:14:03 -0700 (PDT) MIME-Version: 1.0 References: <1564662465-2925-1-git-send-email-david.marchand@redhat.com> In-Reply-To: From: David Marchand Date: Fri, 2 Aug 2019 13:13:52 +0200 Message-ID: To: dev Cc: Aaron Conole , Michael Santana , dpdk stable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] test/eal: do not scan PCI devices for memory tests X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Aug 1, 2019 at 2:29 PM David Marchand wrote: > > On Thu, Aug 1, 2019 at 2:28 PM David Marchand wrote: > > > > The memory tests currently check that, for normal mode (not legacy mode), > > there is no memory left behind when exiting. > > > > The problem is that if a ethdev port is allocated when scanning pci > > devices (even if the driver probe fails like when you have a virtio > > management interface attached to the kernel), on exit, dpdk won't free > > the associated memory since ethdev never frees the ethdev memzone. > > > > Workaround this by disabling pci scan. > > Not entirely happy with this patch. > I am open to suggestions :-) Note: this problem won't be seen in shared builds as long as the pci drivers for net devices are not loaded. -- David Marchand