From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 851F5C432C3 for ; Wed, 27 Nov 2019 20:46:04 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 1527721847 for ; Wed, 27 Nov 2019 20:46:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="K3e6H4X+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1527721847 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 293E71BEB5; Wed, 27 Nov 2019 21:46:03 +0100 (CET) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by dpdk.org (Postfix) with ESMTP id D311B1BEA7 for ; Wed, 27 Nov 2019 21:46:01 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1574887561; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ANdRNVENBbsJ2h1pY9vr1CG/3ON+r2E5CJvrFVKn/O4=; b=K3e6H4X+Vy4VBVQUecTHQ1msT0spao+FKhh1nHZCFaxFNOGuPK3WgoHiG6XSqp3ItY2mZx viI/9J+IrclLBJtDXJevxMc8Jl5Dj4fNQV4igK9vSGsYta+PJowFLHIyvb+NFkq7+j1kRg H7ifyK7IyAjgJwoV7LYjsv2vTf/kqXA= Received: from mail-vk1-f198.google.com (mail-vk1-f198.google.com [209.85.221.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-17-KyegaLunOBugQ9AnN2qgMw-1; Wed, 27 Nov 2019 15:45:58 -0500 Received: by mail-vk1-f198.google.com with SMTP id m72so8618219vka.20 for ; Wed, 27 Nov 2019 12:45:58 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/82TgGR2Vd6Sz6VWcaoZW/PYv6qk7Wj/Pd60wHDlArY=; b=cTxk0ceAMxRALfDaFt3hjg8BBTZJmxbua4O7USiGFWRL6pTIRMjkLrnVTcsIreh6KY cK5wT9vj0O/FLMOxQ96+qNMmOewe+ttkjqJJB1mndP5csy7lhAVN0wY3b7lh/RNhrDIo YwfdlIelZSkuXi/pSfdWPrbNceiIEwIBL8Eo61hQ8J1iU+netojyxII/4EI3BlZLL51t tFBS7ESbo0UYEdjfp4b8kKjPb7koKsOoTnp41ajWXb5130T+8qDmIT8ZAKPU1LCTuMrk QQ/eoojD5uBQxJz+9aWuNDzYnr/rQUX5sv4OXLazhpFBYkd+EoCZplbDhXlXI+K5lBVO qfoQ== X-Gm-Message-State: APjAAAVA9MtFV8U1NHTzD6LgioU5u5OqJY1AxQQCEZIZwFhKHWkPNlV6 H1UxhcJJb9X5/i0WeRWTFVMiUtgeeRtaCpD6LVB5C8TiN/WSXfr0LL4JSjpbK5V0TCQ9VFlnJKn 7XkxPwoTigzpvVOl7NHM= X-Received: by 2002:ab0:2716:: with SMTP id s22mr4141863uao.86.1574887557633; Wed, 27 Nov 2019 12:45:57 -0800 (PST) X-Google-Smtp-Source: APXvYqxkO8txHqFF0Pt4oyN3l151Qy6rqnlrD8+MX6yufWfv/QNEmLYKvme7qwxwQrpeO2Qk/zvp7jF+wkh/UdZoAA8= X-Received: by 2002:ab0:2716:: with SMTP id s22mr4141836uao.86.1574887557212; Wed, 27 Nov 2019 12:45:57 -0800 (PST) MIME-Version: 1.0 References: <20191125161314.18804-1-david.marchand@redhat.com> <20191126142212.GC21200@hmswarspite.think-freely.org> In-Reply-To: <20191126142212.GC21200@hmswarspite.think-freely.org> From: David Marchand Date: Wed, 27 Nov 2019 21:45:46 +0100 Message-ID: To: Neil Horman Cc: dev , Thomas Monjalon , Andrew Rybchenko , dpdk stable , Ray Kinsella , John McNamara , Marko Kovacevic , Qiming Yang , Wenzhuo Lu , Declan Doherty , Adrien Mazarguil , Ferruh Yigit , Cristian Dumitrescu X-MC-Unique: KyegaLunOBugQ9AnN2qgMw-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [RFC PATCH] mark experimental variables X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Nov 26, 2019 at 3:22 PM Neil Horman wrote: > On Mon, Nov 25, 2019 at 05:13:14PM +0100, David Marchand wrote: > > So far, we did not pay attention to direct access to variables but they > > are part of the API/ABI too and should be clearly identified. > > > > Introduce a __rte_experimental_var tag and mark existing variables. > > > > Fixes: a4bcd61de82d ("buildtools: add script to check experimental API = exports") > > Cc: stable@dpdk.org > > > > Signed-off-by: David Marchand > > --- > > Quick patch to try to catch experimental variables. > > Not sure if we could use a single section, so please advise if there is > > better to do about this. > > > I don't see any definition of __rte_experimental_var here, won't the > preprocessor choke on this when you try to compile without that? Sorry, not getting your point. If there is an issue, then it is the same as __rte_experimental. [snip] > > diff --git a/lib/librte_eal/common/include/rte_compat.h b/lib/librte_ea= l/common/include/rte_compat.h > > index 3eb33784b..3fd05179f 100644 > > --- a/lib/librte_eal/common/include/rte_compat.h > > +++ b/lib/librte_eal/common/include/rte_compat.h > > @@ -11,11 +11,16 @@ > > #define __rte_experimental \ > > __attribute__((deprecated("Symbol is not yet part of stable ABI"), \ > > section(".text.experimental"))) > > +#define __rte_experimental_var \ > > +__attribute__((deprecated("Symbol is not yet part of stable ABI"), \ > > +section(".data.experimental"))) > > > > #else > > > > #define __rte_experimental \ > > __attribute__((section(".text.experimental"))) > > +#define __rte_experimental_var \ > > +__attribute__((section(".data.experimental"))) > > > > #endif > > --=20 David Marchand