DPDK-dev Archive on lore.kernel.org
 help / color / Atom feed
From: David Marchand <david.marchand@redhat.com>
To: Arnon Warshavsky <arnon@qwilt.com>
Cc: dev <dev@dpdk.org>, "Mcnamara, John" <john.mcnamara@intel.com>
Subject: Re: [dpdk-dev] [PATCH] eal: unmap undesired address upon config reattach failure
Date: Mon, 19 Aug 2019 10:27:59 +0200
Message-ID: <CAJFAV8zGFG38NBRJ=EP6SuS6AFABv=CGRVnKX=XOQSFjsJyU6g@mail.gmail.com> (raw)
In-Reply-To: <1566110854-2669-1-git-send-email-arnon@qwilt.com>

On Sun, Aug 18, 2019 at 8:47 AM Arnon Warshavsky <arnon@qwilt.com> wrote:
>
> Have rte_eal_config_reattach clean up the mapped address
> which is a valid address but not the one intended.
>
> Coverity issue: 343439

Fixes: 4e8854ae89fa ("eal: do not panic on shared memory init")
Since the issue was hidden before that.

> Signed-off-by: Arnon Warshavsky <arnon@qwilt.com>

FreeBSD has the same issue since:
b149a7064261 ("eal/freebsd: add config reattach in secondary process")


> ---
>  lib/librte_eal/linux/eal/eal.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/lib/librte_eal/linux/eal/eal.c b/lib/librte_eal/linux/eal/eal.c
> index 946222c..fac69b9 100644
> --- a/lib/librte_eal/linux/eal/eal.c
> +++ b/lib/librte_eal/linux/eal/eal.c
> @@ -438,6 +438,7 @@ enum rte_iova_mode
>                         RTE_LOG(ERR, EAL, "Cannot mmap memory for rte_config at [%p], got [%p]"
>                                 " - please use '--base-virtaddr' option\n",
>                                 rte_mem_cfg_addr, mem_config);
> +                       munmap(mem_config, sizeof(struct rte_mem_config));
>                         return -1;
>                 }
>                 RTE_LOG(ERR, EAL, "Cannot mmap memory for rte_config! error %i (%s)\n",
> --
> 1.8.3.1
>

Thanks.

Reviewed-by: David Marchand <david.marchand@redhat.com>

-- 
David Marchand

  reply index

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-18  6:47 Arnon Warshavsky
2019-08-19  8:27 ` David Marchand [this message]
2019-08-19 13:57 ` [dpdk-dev] [PATCH v2] " Arnon Warshavsky
2019-08-19 14:48   ` Burakov, Anatoly
2019-08-19 15:29   ` David Marchand
2019-10-15 18:39     ` David Marchand

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJFAV8zGFG38NBRJ=EP6SuS6AFABv=CGRVnKX=XOQSFjsJyU6g@mail.gmail.com' \
    --to=david.marchand@redhat.com \
    --cc=arnon@qwilt.com \
    --cc=dev@dpdk.org \
    --cc=john.mcnamara@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK-dev Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/dpdk-dev/0 dpdk-dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dpdk-dev dpdk-dev/ https://lore.kernel.org/dpdk-dev \
		dev@dpdk.org dpdk-dev@archiver.kernel.org
	public-inbox-index dpdk-dev

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/ public-inbox