DPDK-dev Archive on lore.kernel.org
 help / color / Atom feed
From: David Marchand <david.marchand@redhat.com>
To: Gagandeep Singh <G.Singh@nxp.com>,
	Hemant Agrawal <hemant.agrawal@nxp.com>
Cc: Thomas Monjalon <thomas@monjalon.net>,
	"dev@dpdk.org" <dev@dpdk.org>,
	 "Burakov, Anatoly" <anatoly.burakov@intel.com>,
	Olivier Matz <olivier.matz@6wind.com>,
	 Andrew Rybchenko <arybchenko@solarflare.com>,
	Nipun Gupta <nipun.gupta@nxp.com>,
	"honnappa.nagarahalli@arm.com" <honnappa.nagarahalli@arm.com>,
	Steve Capper <steve.capper@arm.com>,
	 "jerinj@marvell.com" <jerinj@marvell.com>,
	 "bruce.richardson@intel.com" <bruce.richardson@intel.com>,
	"gavin.hu@arm.com" <gavin.hu@arm.com>,
	 "konstantin.ananyev@intel.com" <konstantin.ananyev@intel.com>,
	 "drc@linux.vnet.ibm.com" <drc@linux.vnet.ibm.com>
Subject: Re: [dpdk-dev] [PATCH] eal: change max hugepage sizes to 4
Date: Thu, 8 Aug 2019 11:22:42 +0200
Message-ID: <CAJFAV8zh696Xe0S21hv5HDSL_jk9b4TKPF29Wf+g=y-HXy-ujg@mail.gmail.com> (raw)
In-Reply-To: <VE1PR04MB63652CADB8785B3353BBFBE8E1D70@VE1PR04MB6365.eurprd04.prod.outlook.com>

On Thu, Aug 8, 2019 at 11:00 AM Gagandeep Singh <G.Singh@nxp.com> wrote:
>
> > >HI Thomas,
> > > > > > DPDK currently is supporting maximum 3 hugepage, sizes whereas
> > > > > > system can support more than this e.g.
> > > > > > 64K, 2M, 32M and 1G.
> > > > >
> > > > > You can mention ARM platform here, and that this issue starts with
> > > > > kernel 5.2 (and I would try to mention this in the title as well).
> > > > > This is better than an annotation that will be lost.
> > > > >
> > > > >
> > > > > > Having these four hugepage sizes available to use by DPDK, which is
> > > > > > valid in case of '--in-memory' EAL option or using 4 separate mount
> > > > > > points for each hugepage size;
> > > > > > hugepage_info_init() API reports an error.
> > > > >
> > > > > Can you describe what is the impact from a user point of view rather
> > > > > than mentioning this internal function?
> > > >
> > > > Yes please, we need to understand how much it is critical.
> > > > Should we Cc stable@dpdk.org for backport?
> > > > Should it be merged at the last minute in 19.08?
> > >
> > > VPP usages in-memory option. So, VPP on ARM with kernel 5.2 wont' work
> > without this patch.
> >
> > Do you want to send a v2 with a better explanation?
> >
> > I would suggest to restrict the change to Arm only with an ifdef,
> > in order to limit the risk for this release.
> > We can think about a dynamic hugepage scan in the next release.
> >
> Ok, I will send a v2 with better explanation and will also add an if check to make this change for ARM specific only.

I hope this explanation covers the question I had about when the
change happened in the kernel :-).
Thanks.


-- 
David Marchand

  reply index

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-08  9:00 Gagandeep Singh
2019-08-08  9:22 ` David Marchand [this message]
  -- strict thread matches above, loose matches on Subject: below --
2019-08-07 12:53 Gagandeep Singh
2019-08-07 14:09 ` Honnappa Nagarahalli
2019-08-07 12:47 Gagandeep Singh
2019-08-07 10:12 Gagandeep Singh
2019-08-07 12:00 ` David Marchand
2019-08-07 12:07   ` Thomas Monjalon
2019-08-07 13:28     ` Hemant Agrawal
2019-08-08  7:31       ` Thomas Monjalon
2019-08-12  9:43         ` Burakov, Anatoly
2019-08-12  9:49           ` David Marchand
2019-08-12 10:01             ` Thomas Monjalon
2019-08-12 10:38             ` Burakov, Anatoly
2019-08-08  7:33       ` David Marchand
2019-08-08 10:37         ` Hemant Agrawal
2019-08-08 12:29           ` Steve Capper
2019-08-08 12:39             ` David Marchand
2019-08-12  9:42       ` Burakov, Anatoly
2019-08-07 15:27 ` Stephen Hemminger

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJFAV8zh696Xe0S21hv5HDSL_jk9b4TKPF29Wf+g=y-HXy-ujg@mail.gmail.com' \
    --to=david.marchand@redhat.com \
    --cc=G.Singh@nxp.com \
    --cc=anatoly.burakov@intel.com \
    --cc=arybchenko@solarflare.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=drc@linux.vnet.ibm.com \
    --cc=gavin.hu@arm.com \
    --cc=hemant.agrawal@nxp.com \
    --cc=honnappa.nagarahalli@arm.com \
    --cc=jerinj@marvell.com \
    --cc=konstantin.ananyev@intel.com \
    --cc=nipun.gupta@nxp.com \
    --cc=olivier.matz@6wind.com \
    --cc=steve.capper@arm.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK-dev Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/dpdk-dev/0 dpdk-dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dpdk-dev dpdk-dev/ https://lore.kernel.org/dpdk-dev \
		dev@dpdk.org
	public-inbox-index dpdk-dev

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git