From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE4B1CA9EAF for ; Wed, 30 Oct 2019 08:04:16 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 6735D20717 for ; Wed, 30 Oct 2019 08:04:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6735D20717 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CE94F1BF2F; Wed, 30 Oct 2019 09:04:15 +0100 (CET) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id A61271BF1E for ; Wed, 30 Oct 2019 09:04:14 +0100 (CET) Received: from mail-vk1-f199.google.com (mail-vk1-f199.google.com [209.85.221.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 11E6BC04BE1B for ; Wed, 30 Oct 2019 08:04:14 +0000 (UTC) Received: by mail-vk1-f199.google.com with SMTP id k127so630489vka.10 for ; Wed, 30 Oct 2019 01:04:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=y1IBuB2D6f845MBywNrFmiUHVRLsbbJNWWSdfoOf0lg=; b=Nsho+0a7L/FiAASQ79Jxg1L6SIDkPApBE+MJRd4wlIctA6AsUZ3AFOg84rhk0QW6GT 5dD7CoDr/ioyFq5aBt59WeTpZ5q+6N3jcohsgKpPMEiSWw5xZxPk9LV1pP1bx6DQNS2F 3NNWl1Rs0/rbBRpc7htIVm4zWHasSxTA0i6z4LR/nSvxCT9zDZDq3PH7tOwlXj3RS5g+ +Jx4ujWre2aRlGTAC06WiFKx2a8V3/JBg9lIVqxdtwxtqHlWUfYxdW62UKkU29Neekyn wQM55QNoCoTkryyVLGpOw1eoj9570oQY8Fx5l6RjHBIJKslzo2cXpXUHey28yAUko/QF 7liw== X-Gm-Message-State: APjAAAUY83Sbt/Af7/eRb/gAJQwNW1Pafrg89Cad//V/WITJIHlUEzTL 2CJtOcTesiO+jJ1U6d4b7e4cwZjwTlQk0lup88M1Mih6CR8gdMsMCr644Y3YiO5fkURT4/PnVy/ ck6qqFCQXYSDIO31Evc0= X-Received: by 2002:a1f:2155:: with SMTP id h82mr10139650vkh.18.1572422653138; Wed, 30 Oct 2019 01:04:13 -0700 (PDT) X-Google-Smtp-Source: APXvYqwF3B1evcX1zQawiFVI5oUL0v/r8ivFUpoFyNUGq3AFGnFAJeHPZBsdNAUKGLhbJvr/P4sOlPOwQ//frWO46vU= X-Received: by 2002:a1f:2155:: with SMTP id h82mr10139641vkh.18.1572422652766; Wed, 30 Oct 2019 01:04:12 -0700 (PDT) MIME-Version: 1.0 References: <20191001125315.6191-1-ktraynor@redhat.com> <20191001130405.7076-1-ktraynor@redhat.com> <20191001130405.7076-5-ktraynor@redhat.com> In-Reply-To: <20191001130405.7076-5-ktraynor@redhat.com> From: David Marchand Date: Wed, 30 Oct 2019 09:04:01 +0100 Message-ID: To: Kevin Traynor Cc: dev , Rosen Xu , dpdk stable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH 6/9] net/ipn3ke: remove commented out code X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Oct 1, 2019 at 3:04 PM Kevin Traynor wrote: > > These struct members and variable were commented out. Remove them. > > Fixes: c01c748e4ae6 ("net/ipn3ke: add new driver") > Fixes: c820468ac99c ("net/ipn3ke: support TM") > Cc: rosen.xu@intel.com > Cc: stable@dpdk.org > > Signed-off-by: Kevin Traynor > --- > drivers/net/ipn3ke/ipn3ke_ethdev.h | 7 ------- > drivers/net/ipn3ke/ipn3ke_tm.c | 1 - > 2 files changed, 8 deletions(-) > > diff --git a/drivers/net/ipn3ke/ipn3ke_ethdev.h b/drivers/net/ipn3ke/ipn3ke_ethdev.h > index c7b336bbd..0d71dcd64 100644 > --- a/drivers/net/ipn3ke/ipn3ke_ethdev.h > +++ b/drivers/net/ipn3ke/ipn3ke_ethdev.h > @@ -97,18 +97,11 @@ struct ipn3ke_tm_node { > struct ipn3ke_tm_hierarchy { > struct ipn3ke_tm_node *port_node; > - /*struct ipn3ke_tm_node_list vt_node_list;*/ > - /*struct ipn3ke_tm_node_list cos_node_list;*/ > - > uint32_t n_shaper_profiles; > - /*uint32_t n_shared_shapers;*/ > uint32_t n_tdrop_profiles; > uint32_t n_vt_nodes; > uint32_t n_cos_nodes; > - > struct ipn3ke_tm_node *port_commit_node; > struct ipn3ke_tm_node_list vt_commit_node_list; > struct ipn3ke_tm_node_list cos_commit_node_list; > - > - /*uint32_t n_tm_nodes[IPN3KE_TM_NODE_LEVEL_MAX];*/ > }; > > diff --git a/drivers/net/ipn3ke/ipn3ke_tm.c b/drivers/net/ipn3ke/ipn3ke_tm.c > index a93145d59..5a16c5f96 100644 > --- a/drivers/net/ipn3ke/ipn3ke_tm.c > +++ b/drivers/net/ipn3ke/ipn3ke_tm.c > @@ -1088,5 +1088,4 @@ ipn3ke_tm_node_add_check_mount(uint32_t tm_id, > struct rte_tm_error *error) > { > - /*struct ipn3ke_tm_internals *tm = IPN3KE_DEV_PRIVATE_TO_TM(dev);*/ > uint32_t node_index; > uint32_t parent_index; > -- > 2.21.0 > Reviewed-by: David Marchand -- David Marchand