From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A0D9C4CEC6 for ; Thu, 12 Sep 2019 16:16:00 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id D6A5B2081B for ; Thu, 12 Sep 2019 16:15:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="a8Q0ThBO" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D6A5B2081B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 148CA1E4DE; Thu, 12 Sep 2019 18:15:59 +0200 (CEST) Received: from mail-io1-f68.google.com (mail-io1-f68.google.com [209.85.166.68]) by dpdk.org (Postfix) with ESMTP id C56FE1DFE2 for ; Thu, 12 Sep 2019 18:15:57 +0200 (CEST) Received: by mail-io1-f68.google.com with SMTP id n197so56123113iod.9 for ; Thu, 12 Sep 2019 09:15:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=mjKCzHugdyIzELOJema2kP313hQ8j47KfczwB44m+oE=; b=a8Q0ThBOinMgsaF13cbsv05Ek/WCE7YFIqXHUHc7bvKGDjbRfDi/rk8rQMp2z+fU4P mKDx1xrSKRUteKiXHMU0ShLLalmstvXrd45D3zxTiXkuum+3VZVz0I1I/vZ5VYvBtbQA SG6tK8fNIrUGsMToyfh75oeOmTS2ZhNu4d1ZWYLYU+WshwKsaQE4VUZEkrysJ7CnrOMT rRkOElei5ODQZ6zkWI1rTOTSch/eqiZo3T/av0Wxc4SsPUdQ60dAnzuQjN+Elxqzv1z4 oZc/ijw+Zrqmzld1fskCWrrmNx9VJXrOqPs5czYKOzls67AQChUocw2Szg8f7DJ8uzkN VMig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mjKCzHugdyIzELOJema2kP313hQ8j47KfczwB44m+oE=; b=hWODP8TutWvVGcXejmJK0K1sixwkVAOsPOD+BYyjuJaj3S84a2iH8JrcjoA6dm++eq Sk662YYbXBDeqvGXn02qD4VuN7vI6qmzFYShKAdwYndmf0XxHkK8Yy2/Mg5ZOc7xTs0B Xyg4XzXTZbTxAQxoV5OL3Hx3M4CrD32VJS6b/b0ABJuxAw7kIw7Fv2oJuo6XS41fQ4CE FpcINUgjP6U7g25z5X6RIZoIQhLsZkRGrNIX5UYQzFPP8qqXpDEzTc0lY6t7axvA404o ZYBxxr3wY9bB/9Ts9UElLcdhF2UteoM1C09ueGRxfc5LHilIH9FJcs2i/H3op93XFgUf zAqg== X-Gm-Message-State: APjAAAWWwtaVBt9ktnS5kyx6AYKavBdbHTLea84xpMbW5oN4z92nCyne F7b2Uc3w7IOZU45vfzqGM+xyIbMViQJ36GiaCis= X-Google-Smtp-Source: APXvYqw9fW8/o2xOYkn0dKenFLJEzNUB95H4EchTM0IB7oam66ftb4dxvo4AIhZkjDZAW20K+FlGzRM6BZ054YFlkng= X-Received: by 2002:a05:6602:c7:: with SMTP id z7mr2141961ioe.130.1568304957077; Thu, 12 Sep 2019 09:15:57 -0700 (PDT) MIME-Version: 1.0 References: <1561911676-37718-1-git-send-email-gavin.hu@arm.com> <1568287473-55306-1-git-send-email-gavin.hu@arm.com> <1568287473-55306-8-git-send-email-gavin.hu@arm.com> In-Reply-To: <1568287473-55306-8-git-send-email-gavin.hu@arm.com> From: Jerin Jacob Date: Thu, 12 Sep 2019 21:45:46 +0530 Message-ID: To: Gavin Hu Cc: dev@dpdk.org, nd@arm.com, Thomas Monjalon , stephen@networkplumber.org, hemant.agrawal@nxp.com, Jerin Jacob , Pavan Nikhilesh , Honnappa.Nagarahalli@arm.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v5 7/8] net/thunderx: use new API to save cycles on aarch64 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Sep 12, 2019 at 4:57 PM Gavin Hu wrote: > > Use the new API to wait in low power state instead of continuous > polling to save CPU cycles and power. > > Signed-off-by: Gavin Hu > Reviewed-by: Ruifeng Wang Acked-by: Jerin Jacob > --- > drivers/net/thunderx/nicvf_rxtx.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/net/thunderx/nicvf_rxtx.c b/drivers/net/thunderx/nicvf_rxtx.c > index 1c42874..16f34c6 100644 > --- a/drivers/net/thunderx/nicvf_rxtx.c > +++ b/drivers/net/thunderx/nicvf_rxtx.c > @@ -385,8 +385,7 @@ nicvf_fill_rbdr(struct nicvf_rxq *rxq, int to_fill) > ltail++; > } > > - while (__atomic_load_n(&rbdr->tail, __ATOMIC_RELAXED) != next_tail) > - rte_pause(); > + rte_wait_until_equal_relaxed_32(&rbdr->tail, next_tail); > > __atomic_store_n(&rbdr->tail, ltail, __ATOMIC_RELEASE); > nicvf_addr_write(door, to_fill); > -- > 2.7.4 >