From: Jerin Jacob <jerinjacobk@gmail.com>
To: Pavan Nikhilesh <pbhagavatula@marvell.com>
Cc: Jerin Jacob <jerinj@marvell.com>,
Marko Kovacevic <marko.kovacevic@intel.com>,
Ori Kam <orika@mellanox.com>,
Bruce Richardson <bruce.richardson@intel.com>,
Radu Nicolau <radu.nicolau@intel.com>,
Akhil Goyal <akhil.goyal@nxp.com>,
Tomasz Kantecki <tomasz.kantecki@intel.com>,
Sunil Kumar Kori <skori@marvell.com>, dpdk-dev <dev@dpdk.org>,
Satananda Burla <sburla@marvell.com>
Subject: Re: [dpdk-dev] [PATCH] examples/l2fwd-event: set RSS based on device capabilities
Date: Mon, 13 Jan 2020 15:04:27 +0530 [thread overview]
Message-ID: <CALBAE1M7L85YigjXL77MMvdJPQXoci80-PpA+ZqfHUqMAsDsCw@mail.gmail.com> (raw)
In-Reply-To: <CALBAE1MQ_LhiZxhSm9bNszZ7R_2eoA=k=3HyuyhX5bK5tzpgSg@mail.gmail.com>
On Mon, Dec 16, 2019 at 11:16 AM Jerin Jacob <jerinjacobk@gmail.com> wrote:
>
> On Mon, Dec 16, 2019 at 11:07 AM <pbhagavatula@marvell.com> wrote:
> >
> > From: Pavan Nikhilesh <pbhagavatula@marvell.com>
> >
> > Setup RSS configuration based on underlying device capabilities.
> >
> > Signed-off-by: Satananda Burla <sburla@marvell.com>
> > Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
> > ---
>
>
> Please add Fixes: and cc stable as well as it is a fix for the bug.
Ping
>
>
> > examples/l2fwd-event/l2fwd_common.c | 11 +++++++++++
> > 1 file changed, 11 insertions(+)
> >
> > diff --git a/examples/l2fwd-event/l2fwd_common.c b/examples/l2fwd-event/l2fwd_common.c
> > index 0c069ec35..2fae6f52c 100644
> > --- a/examples/l2fwd-event/l2fwd_common.c
> > +++ b/examples/l2fwd-event/l2fwd_common.c
> > @@ -46,6 +46,17 @@ l2fwd_event_init_ports(struct l2fwd_resources *rsrc)
> > if (ret != 0)
> > rte_panic("Error during getting device (port %u) info: %s\n",
> > port_id, strerror(-ret));
> > + local_port_conf.rx_adv_conf.rss_conf.rss_hf &=
> > + dev_info.flow_type_rss_offloads;
> > + if (local_port_conf.rx_adv_conf.rss_conf.rss_hf !=
> > + port_conf.rx_adv_conf.rss_conf.rss_hf) {
> > + printf("Port %u modified RSS hash function based on hardware support,"
> > + "requested:%#"PRIx64" configured:%#"PRIx64"",
> > + port_id,
> > + port_conf.rx_adv_conf.rss_conf.rss_hf,
> > + local_port_conf.rx_adv_conf.rss_conf.rss_hf);
> > + }
> > +
> > if (dev_info.tx_offload_capa & DEV_TX_OFFLOAD_MBUF_FAST_FREE)
> > local_port_conf.txmode.offloads |=
> > DEV_TX_OFFLOAD_MBUF_FAST_FREE;
> > --
> > 2.17.1
> >
next prev parent reply other threads:[~2020-01-13 9:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-16 5:37 [dpdk-dev] [PATCH] examples/l2fwd-event: set RSS based on device capabilities pbhagavatula
2019-12-16 5:46 ` Jerin Jacob
2020-01-13 9:34 ` Jerin Jacob [this message]
2020-01-14 5:52 ` [dpdk-dev] [PATCH v2] examples/l2fwd-event: fix ethdev RSS setup pbhagavatula
2020-01-14 20:37 ` Jerin Jacob
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALBAE1M7L85YigjXL77MMvdJPQXoci80-PpA+ZqfHUqMAsDsCw@mail.gmail.com \
--to=jerinjacobk@gmail.com \
--cc=akhil.goyal@nxp.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=marko.kovacevic@intel.com \
--cc=orika@mellanox.com \
--cc=pbhagavatula@marvell.com \
--cc=radu.nicolau@intel.com \
--cc=sburla@marvell.com \
--cc=skori@marvell.com \
--cc=tomasz.kantecki@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).