From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D11C2C4360C for ; Fri, 27 Sep 2019 07:58:17 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 5AF752075D for ; Fri, 27 Sep 2019 07:58:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HxQBXdYn" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5AF752075D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7E03F2BE5; Fri, 27 Sep 2019 09:58:16 +0200 (CEST) Received: from mail-io1-f67.google.com (mail-io1-f67.google.com [209.85.166.67]) by dpdk.org (Postfix) with ESMTP id 9457028EE for ; Fri, 27 Sep 2019 09:58:15 +0200 (CEST) Received: by mail-io1-f67.google.com with SMTP id b136so13999480iof.3 for ; Fri, 27 Sep 2019 00:58:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=GLsP9sI/iKhmdzwaxMwIlxjRGGqyQfySdEQptaZErWU=; b=HxQBXdYnLVT6zpTWeqbAIJa5q1H8J6EbHyEPlRzP1jb+f3Li0Mz67sQOeZ4MXvT7Ex tsvDVSt+fk7LitN/F20N2Q/vz2OgcWOR4rE3gjh/kSkJElsO7Wn/kB98ZBuy/pL2T+Pr mI6rrOtPIeXg8xevJcS6mMO5dhrSgRTfLIHBlHmNVDo5fNAkZhxdC6lLNMQjPe82JZZX bKiR0UqlRWC2DsvaoGhJT+bsowTRNdSVhnU4RaaYmfUsvLILUGhM+GCAWXKygjqoZL3H ufgRu8u4UiYOjIDsoNZluE9nt4PJ6iyWxUdR02PbtbZEf3V5lnn4kmn0xfhbnPQjKXel EGgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=GLsP9sI/iKhmdzwaxMwIlxjRGGqyQfySdEQptaZErWU=; b=DixCMJqWya2ICcdTAQdhhPJXgmmHbb9TqzHaPJQTebfActNs6TSvk9eM3lMGQd80sH 4y95Wg5XrPtkRIxxG77LeXV8XPZU69QFiTuw1L4/0n+I3vmJj+9C7Tjn2VeX8hyUmsZd Fn/rCqxfYX9pU+DEz3MGhdM4Hambi9SsN6cZLn7AqGYVNVP08N0kWIhESoRne8De5Seq dXVvYoiSmqiU3n49SjT+wjJnWl8nx8egEaJprLezgxLpYgJ9EZIUm8jXG8QpW79vOMT2 DOka/Fk8riqaU3hbJHcvuQXrvx/4G8Ke2btBp2A8b9F2YEOYCUX/9gyRvx64ZCvQ2o39 OLgQ== X-Gm-Message-State: APjAAAVxpqCxI2pzbfPtmkK8LUjC5VjtXPSJ482w2ADqxA8H0owmvIy3 ltiL2tYJ14sTN4b+V8LgFmhdKy3Ikdh2QQ5IDJk= X-Google-Smtp-Source: APXvYqyMpPUX8/76cn3Doe5aZEv7jcgqCshw5VRXqbPX9BOopqqUIT6ISp1VTHdzpysAJivGK+AbqM5gHTk9Mewr2Yo= X-Received: by 2002:a05:6638:3d4:: with SMTP id r20mr7353375jaq.104.1569571094771; Fri, 27 Sep 2019 00:58:14 -0700 (PDT) MIME-Version: 1.0 References: <20190909195404.4760-1-pallavi.kadam@intel.com> <20190926202924.6876-1-pallavi.kadam@intel.com> <20190926202924.6876-4-pallavi.kadam@intel.com> In-Reply-To: <20190926202924.6876-4-pallavi.kadam@intel.com> From: Jerin Jacob Date: Fri, 27 Sep 2019 13:28:03 +0530 Message-ID: To: Pallavi Kadam Cc: dpdk-dev , Thomas Monjalon , Harini.Ramakrishnan@microsoft.com, keith.wiles@intel.com, "Richardson, Bruce" , ranjit.menon@intel.com, antara.ganesh.kolar@intel.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2 3/9] eal: add windows compatible header files X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Sep 27, 2019 at 2:24 AM Pallavi Kadam wrote: > > Adding dlfcn.h on Windows to support common code. > > Adding eal_filesystem.h to support functions and > path defines for files and directories on Windows. > > Adding getopt.h to support parsing options on Windows. > > Adding rte_vect.h as Windows fails to compile: > \common\include\arch\x86\rte_vect.h. > > Signed-off-by: Antara Ganesh Kolar > Signed-off-by: Pallavi Kadam > Reviewed-by: Ranjit Menon > Reviewed-by: Keith Wiles > --- > diff --git a/lib/librte_eal/windows/eal/include/rte_vect.h b/lib/librte_eal/windows/eal/include/rte_vect.h > new file mode 100644 > index 000000000..630473e28 > --- /dev/null > +++ b/lib/librte_eal/windows/eal/include/rte_vect.h > @@ -0,0 +1,9 @@ > +/* SPDX-License-Identifier: BSD-3-Clause > + * Copyright(c) 2019 Intel Corporation > + */ > + > +#pragma once > + > +#define __ICC 1600 > + > +#include "..\..\common\include\arch\x86\rte_vect.h" I understand there is a compilation error with generic rte_vect.h with windows from the git commit. But above hardcoding to x86 will create an issue for another arch. Please fix the compilation for generic rte_vect.h or introduce vect.h as OS-specific and have implementation for Linux and FreeBSD. > -- > 2.18.0.windows.1 >