Re: [dpdk-dev] [RFC v4] regexdev: introduce regexdev subsystem

From: Jerin Jacob <jerinjacobk@gmail.com>
To: Ori Kam <orika@mellanox.com>
Cc: Jerin Jacob <jerinj@marvell.com>,
	xiang.w.wang@intel.com, dpdk-dev <dev@dpdk.org>,
	Pavan Nikhilesh <pbhagavatula@marvell.com>,
	Shahaf Shuler <shahafs@mellanox.com>,
	 Hemant Agrawal <hemant.agrawal@nxp.com>,
	Opher Reviv <opher@mellanox.com>,
	 Alex Rosenbaum <alexr@mellanox.com>,
	dovrat@marvell.com,  Prasun Kapoor <pkapoor@marvell.com>,
	Nipun Gupta <nipun.gupta@nxp.com>,
	 "Richardson, Bruce" <bruce.richardson@intel.com>,
	yang.a.hong@intel.com, harry.chang@intel.com,
	 gu.jian1@zte.com.cn, shanjiangh@chinatelecom.cn,
	zhangy.yun@chinatelecom.cn,  lixingfu@huachentel.com,
	wushuai@inspur.com, yuyingxia@yxlink.com,
	 fanchenggang@sunyainfo.com, davidfgao@tencent.com,
	liuzhong1@chinaunicom.cn,  zhaoyong11@huawei.com, oc@yunify.com,
	Jim Thompson <jim@netgate.com>,
	 hongjun.ni@intel.com, j.bromhead@titan-ic.com, deri@ntop.org,
	fc@napatech.com,  arthur.su@lionic.com,
	Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [dpdk-dev] [RFC v4] regexdev: introduce regexdev subsystem
Date: Thu, 27 Feb 2020 20:25:38 +0530	[thread overview]
Message-ID: <CALBAE1O9yHPK1+bZc1HdiWmMOZotpQ9t1MJ3Z8NqO8VNQt6Mxw@mail.gmail.com> (raw)
In-Reply-To: <1582814448-93489-1-git-send-email-orika@mellanox.com>

On Thu, Feb 27, 2020 at 8:11 PM Ori Kam <orika@mellanox.com> wrote:
>
> From: Jerin Jacob <jerinj@marvell.com>
>
> Even though there are some vendors which offer Regex HW offload, due to
> lack of standard API, It is diffcult for DPDK consumer to use them
> in a portable way.
>
> This _RFC_ attempts to standardize the RegEx/DPI offload APIs for DPDK.
>
> This RFC crafted based on SW Regex API frameworks such as libpcre and
> hyperscan and a few of the RegEx HW IPs which I am aware of.
>
> RegEx pattern matching applications:
> * Next Generation Firewalls (NGFW)
> * Deep Packet and Flow Inspection (DPI)
> * Intrusion Prevention Systems (IPS)
> * DDoS Mitigation
> * Network Monitoring
> * Data Loss Prevention (DLP)
> * Smart NICs
> * Grammar based content processing
> * URL, spam and adware filtering
> * Advanced auditing and policing of user/application security policies
> * Financial data mining - parsing of streamed financial feeds
> * Application recognition.
> * Dmemory introspection.
> * Natural Language Processing (NLP)
> * Sentiment Analysis.
> * Big data databse acceleration.
> * Computational storage.
>
> Request to review from HW and SW RegEx vendors and RegEx application
> users to have portable DPDK API for RegEx.
>
> The API schematics are based cryptodev, eventdev and ethdev existing
> device API.
>
> Signed-off-by: Jerin Jacob <jerinj@marvell.com>
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
> Signed-off-by: Ori Kam <orika@mellanox.com>
> ---
> V4:
>  * Replace iova with mbuf.
>  * Small ML comments.
> V3:
>  * Change subject title.
> V2:
>  * Address ML comments.

> +/** Struct to hold scatter gather elements in ops. */
> +struct rte_regex_iov {
> +       RTE_STD_C11
> +       union {
> +               uint64_t u64;
> +               /**<  Allow 8-byte reserved on 32-bit system */
> +               void *buf_addr;
> +               /**< Virtual address of the pattern to be matched. */
> +       };
> +       rte_iova_t buf_iova;
> +       /**< IOVA address of the pattern to be matched. */
> +       uint16_t buf_size; /**< The buf size. */
> +};

rte_regex_iov structure is stale . Please remove it.