From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C4CCCA9EC5 for ; Wed, 30 Oct 2019 11:43:05 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 18A0C2083E for ; Wed, 30 Oct 2019 11:43:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="n9d30tO/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 18A0C2083E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AAF5D1C025; Wed, 30 Oct 2019 12:43:03 +0100 (CET) Received: from mail-io1-f66.google.com (mail-io1-f66.google.com [209.85.166.66]) by dpdk.org (Postfix) with ESMTP id 9CA551C01F; Wed, 30 Oct 2019 12:43:02 +0100 (CET) Received: by mail-io1-f66.google.com with SMTP id s17so2101614iol.12; Wed, 30 Oct 2019 04:43:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=jRLJKl3vYVzuGrSYHJ/NLTrdtBKXzPWTRwFcY/zzT0Y=; b=n9d30tO/xZCeOMhotUQ540dIcF97a/41Ffxf/wUzmUx5yoOYubqtGRv4SYpt02x0o9 /ku2jDiwZbjFZDd7BoHqh0jMQzq5edWXJdGZBX+6qLLGkGFqt7WpfMEvdeV9cH7MZmyA sYyIWxcI6tXaHpH/dA2gdJ66VfoFudbmrOdlMFH74IJZuRTRtEl9Y4s/7tQWSpnhEfHM G2JqKAmEybNB4GYvzspPbdH8NrzXyHfDoc5SIIO//BRea7lmfhJDBJdlNude84m6U32p oa9htXvPnPwth4eRoRJkjKbmrKK+Mzwlq0UY28W+0w2SvXG+YyFXuLbPV8ETfgNpq4R8 PH6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=jRLJKl3vYVzuGrSYHJ/NLTrdtBKXzPWTRwFcY/zzT0Y=; b=P0NcsATCHZ81+Pcu88r5xxtEsXmmxWtwl8z3x22SM58bsHwPc41tQ7WsLURut3fQ/l tExmPc/R+mkhCzRGVMhPXRZ9TLGarQg0syEPwFhAbku1997IcC22GBZYk/eicR+ZfQNZ /i7UooGDBQmFPFY4A6V0yvZFowWrVLeX/Ch+OxIFP2GOGf1JEY9iciZwQESaYH+RxrWc ozyF2y5i01uvOAxgu4l7T7tlrdr9BXMOFcV640uS9UqQZkBsqdUxE+EvLQ3S0g7Uvogu F5Y3e7vMJDqLT3BToMldRHbq1QBfAnldnNUZ0BXHJOLnaGHLyTlj4YocvKHcdZqzaHOJ 4jyA== X-Gm-Message-State: APjAAAXBoHkt2m9itWvWefRbxbd14P/8Xl69MhIvtnXHOYQPVmt8zRw3 hQYFqGLz8QGALV9OcT4HvRdNDYlmD2egvqNImk4= X-Google-Smtp-Source: APXvYqwM8KHCZAXLO/kGB0Qazwa25amdfI8EIz+HXp/SQ9qJMFwjvkH42lm/fQkfaj6p8JrWbmSXgHFA3XUFajbB9bQ= X-Received: by 2002:a5d:8598:: with SMTP id f24mr8294027ioj.60.1572435781673; Wed, 30 Oct 2019 04:43:01 -0700 (PDT) MIME-Version: 1.0 References: <20191028112535.692-1-alialnu@mellanox.com> In-Reply-To: <20191028112535.692-1-alialnu@mellanox.com> From: Jerin Jacob Date: Wed, 30 Oct 2019 17:12:45 +0530 Message-ID: To: Ali Alnubani Cc: dpdk-dev , Jerin Jacob , Pavan Nikhilesh , stable@dpdk.org Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 1/2] mk: fix build on arm64 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Oct 28, 2019 at 4:56 PM Ali Alnubani wrote: > > OcteonTx was disabled for causing an internal compiler error on old gcc > versions. > See commit 4f760550a093 ("mk: disable OcteonTx for buggy compilers"). > > The condition that was added later to apply disabling OcteonTx > only on arm64 caused the condition to never be obeyed because it > compares ["arm64"] to [arm64]. > > This fixes the condition by using RTE_ARCH instead of CONFIG_RTE_ARCH, > because the former has the quotes removed, while the later doesn't. > > Fixes: f3af3e44a444 ("mk: disable OcteonTx for buggy compilers only on arm64") > Cc: stable@dpdk.org > > Signed-off-by: Ali Alnubani Acked-by: Jerin Jacob > --- > mk/toolchain/gcc/rte.toolchain-compat.mk | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mk/toolchain/gcc/rte.toolchain-compat.mk b/mk/toolchain/gcc/rte.toolchain-compat.mk > index ea40a11c0..00d6fd642 100644 > --- a/mk/toolchain/gcc/rte.toolchain-compat.mk > +++ b/mk/toolchain/gcc/rte.toolchain-compat.mk > @@ -99,7 +99,7 @@ else > endif > > # Disable octeontx event PMD for gcc < 4.8.6 & ARCH=arm64 > - ifeq ($(CONFIG_RTE_ARCH), arm64) > + ifeq ($(RTE_ARCH), arm64) > ifeq ($(shell test $(GCC_VERSION)$(GCC_PATCHLEVEL) -lt 486 && echo 1), 1) > CONFIG_RTE_LIBRTE_PMD_OCTEONTX_SSOVF=d > CONFIG_RTE_LIBRTE_OCTEONTX_MEMPOOL=d > -- > 2.23.0 >