From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4F77C2BA19 for ; Thu, 9 Apr 2020 18:52:56 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 3209120757 for ; Thu, 9 Apr 2020 18:52:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZfoOcg0n" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3209120757 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 060A21D157; Thu, 9 Apr 2020 20:52:55 +0200 (CEST) Received: from mail-io1-f65.google.com (mail-io1-f65.google.com [209.85.166.65]) by dpdk.org (Postfix) with ESMTP id 881D51C2BF for ; Thu, 9 Apr 2020 20:52:53 +0200 (CEST) Received: by mail-io1-f65.google.com with SMTP id n20so647327ioa.4 for ; Thu, 09 Apr 2020 11:52:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Jaei9a4OU3ry52cnhdZIL0meU0ONbycivpeBD//0EqE=; b=ZfoOcg0n9PWfluYIbLrn/HxbuNmJWROUN5e5LiighCVK+IT1fFS2m1tbpE3PkfyilA lIITBBJN1uLLJUtGl5dfxisvJGSoIytqFHokbfjllz6LE/eDhgx1qSuYqguY53dE4oLh /wCRLljehZhWFdvDW0pKg8PrP6tcotuMcberPLTsEqIXMTJ6ldi/+DHE4pAkkjjIOHVg PTTnOv+E+nzhxZnzJ6PFmuGJIR91sj0egZy40d0rFLnhkz+KfiOEAyXb+t3ofgaLXQiU IuN0hejBWSi6U9Z4tbM8gKsvb6j+2XlGLRfmURnmY2TiEbGg54EVcdhSL1LnXsD9i5KL RMNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Jaei9a4OU3ry52cnhdZIL0meU0ONbycivpeBD//0EqE=; b=CKeqRugEe4sw8Ou25iZ9UMn32k5uELTTeToZC5LeCBR2FYfu5CPMlDZlIlxS+myBWC W3iMlTO67w7G5qHOPGDk56U3WAXJZxFU0VpKIv3kppcVGPdWi17G2hYRHHZwJdstPtUO q2iBCzGsrb7iuivLXznuw/M9LorLM5fmbpKWnEtavDXlgzcdgn2gUwNLWTRZ04u9odVe ercmvhWo8gtODY0qqUzPXdSqjxGfPeIMnQagylLZNvAlA5tHvbaUMccQcxRip9TEcQfP bPsKgt6aoDvwvNN1hDtrbTtAgnFYNjrK+5OdS8piSA53YX7bC1P0PoKkpZFbuIt/HbMH uc6w== X-Gm-Message-State: AGi0PuaR2k+Ynj7mS31ws2ewqF3ghjlKoEzxyZ9t+gjPxH2kx1NFm8e0 G0QVROtW/AgWZkoZH9HlAHcnLiXRfquMUqyfX5Q= X-Google-Smtp-Source: APiQypJPnXP9vRntVYuij31otMIWapf4tBAmTN6lN/YlQlCXYr+R7TxHqhzOyYGdrujCf2lQGgHll6kTltmeija6Vig= X-Received: by 2002:a02:9a0d:: with SMTP id b13mr919662jal.60.1586458372807; Thu, 09 Apr 2020 11:52:52 -0700 (PDT) MIME-Version: 1.0 References: <20200329144342.1543749-1-jerinj@marvell.com> <6115809.K2JlShyGXD@thomas> <14100064.JCcGWNJJiE@thomas> In-Reply-To: From: Jerin Jacob Date: Fri, 10 Apr 2020 00:22:35 +0530 Message-ID: To: Thomas Monjalon Cc: Jerin Jacob , dpdk-dev , "Richardson, Bruce" , David Marchand , =?UTF-8?Q?Mattias_R=C3=B6nnblom?= , Sunil Kumar Kori , Olivier Matz Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v4 00/33] DPDK Trace support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Apr 9, 2020 at 11:57 PM Jerin Jacob wrote: > > > > > > > > > They are setting levels with regex or globbing. > > > > --log-level supports 3 syntaxes today: > > > > - int (global level) > > > > - globbing:int > > > > - regex,int > > > > > > Here is my understanding. > > > > > > IMO, Actual Syntax is > > > - int (global level) > > > - globbing: int (global level) > > > - regex: int (global level) > > > > The level apply to the logs matching the pattern (globbing or regex) > > so I don't understand why you call it "global". > > What I meant is, if there is no global, what is the point of changing > the trace level with EAL command-line argument with globbing and regex. Self reply on this: I understood where is the disconnect is: In case of log: ~~~~~~~~~~~ It will be printed when: a) When it is less than both the "global" and "log level" NOTE: in case of log, log level passed on to log function (see rte_log(uint32_t level..) In case of trace: ~~~~~~~~~~~~ it will be emitted when: a) The trace is enabled (rte_trace_enable() called on the tracepoint) b) When it is less than the global level. NOTE: in case of trace, Nothing like log level passed to trace emit function. The control lies with a slow path enable/disable decision(item (a)) due to performance requirements to instrumentation overhead.