From: Jerin Jacob <jerinjacobk@gmail.com> To: Andrzej Ostruszka <amo@semihalf.com> Cc: dpdk-dev <dev@dpdk.org> Subject: Re: [dpdk-dev] [PATCH v3 01/29] graph: define the public API for graph support Date: Mon, 6 Apr 2020 20:29:56 +0530 Message-ID: <CALBAE1OphsRyKsT15tvnpvCY+Y-mC6VNbgUhmUVzhU0bH8_62w@mail.gmail.com> (raw) In-Reply-To: <75092d70-d1c1-832e-047f-d24d82654e4c@semihalf.com> On Mon, Apr 6, 2020 at 6:06 PM Andrzej Ostruszka <amo@semihalf.com> wrote: > > Hello Jerin Hello Andrzej, > > I've started reviewing this and will go patch-by-patch so some of the > comments might sound silly and/or unnecessary. Thanks for the comments. > > + > > +/** > > + * @file rte_graph.h > > + * > > + * @warning > > + * @b EXPERIMENTAL: this API may change without prior notice > > I think this @warning doc at global level is enough - no need to repeat > it below (just keeping __rte_experimental should be fine). Will fix it v5. > > > + * > > + * Graph architecture abstracts the data processing functions as > > + * "node" and "link" them together to create a complex "graph" to enable > > + * reusable/modular data processing functions. > > + * > > + > > +typedef uint32_t rte_graph_off_t; /**< Graph offset type. */ > > +typedef uint32_t rte_node_t; /**< Node id type. */ > > +typedef uint16_t rte_edge_t; /**< Edge id type. */ > > +typedef uint16_t rte_graph_t; /**< Graph id type. */ > > I would use 'id' somewhere in the name of these typedefs - e.g. seeing > rte_node_t in the code (without knowing what it is) I'd be guessing this > is a pointer to 'struct rte_node'. > So maybe 'rte_node_id' or if we stick with _t convention and > rte_node_id_t is too long then maybe simple rte_nid_t/rte_eid_t/rte_gid_t? Considering typedef will not be pointers in Linux coding standard, I have chosen shorter name. considering eid, gid is cryptic and Since you think, rte_node_id better, I will change to that. > > > + > > +/** Burst size in terms of log2 */ > > +#if RTE_GRAPH_BURST_SIZE == 1 > > +#define RTE_GRAPH_BURST_SIZE_LOG2 0 /**< Object burst size of 1. */ > > +#elif RTE_GRAPH_BURST_SIZE == 2 > > +#define RTE_GRAPH_BURST_SIZE_LOG2 1 /**< Object burst size of 2. */ > > +#elif RTE_GRAPH_BURST_SIZE == 4 > > +#define RTE_GRAPH_BURST_SIZE_LOG2 2 /**< Object burst size of 4. */ > > +#elif RTE_GRAPH_BURST_SIZE == 8 > > +#define RTE_GRAPH_BURST_SIZE_LOG2 3 /**< Object burst size of 8. */ > > +#elif RTE_GRAPH_BURST_SIZE == 16 > > +#define RTE_GRAPH_BURST_SIZE_LOG2 4 /**< Object burst size of 16. */ > > +#elif RTE_GRAPH_BURST_SIZE == 32 > > +#define RTE_GRAPH_BURST_SIZE_LOG2 5 /**< Object burst size of 32. */ > > +#elif RTE_GRAPH_BURST_SIZE == 64 > > +#define RTE_GRAPH_BURST_SIZE_LOG2 6 /**< Object burst size of 64. */ > > +#elif RTE_GRAPH_BURST_SIZE == 128 > > +#define RTE_GRAPH_BURST_SIZE_LOG2 7 /**< Object burst size of 128. */ > > +#elif RTE_GRAPH_BURST_SIZE == 256 > > +#define RTE_GRAPH_BURST_SIZE_LOG2 8 /**< Object burst size of 256. */ > > +#else > > +#error "Unsupported burst size" > > If other sizes are not supported then maybe it would be better to have > in options RTE_GRAPH_BURST_SIZE_LOG2 and define BURST_SIZE in terms of > this LOG2? Since RTE_GRAPH_BURST_SIZE used in fastpath, I thought of avoiding any operation in the fastpath, even though the compiler most probably optimizes it. The RTE_CACHE_LINE_SIZE also taken a similar path. > > > +#endif > > + > > +/* Forward declaration */ > > +struct rte_node; /**< Node data */ > > +struct rte_graph; /**< Graph data */ > > 'data'? Maybe 'object' or something like that. Yes. I will change to data. > > [...] > > +/** > > + * @warning > > + * @b EXPERIMENTAL: this API may change without prior notice > > + * > > + * Structure defines the node registration parameters. > > + * > > + * @see __rte_node_register(), RTE_NODE_REGISTER() > > + */ > > +struct rte_node_register { > > + char name[RTE_NODE_NAMESIZE]; /**< Name of the node. */ > > + uint64_t flags; /**< Node configuration flag. */ > > +#define RTE_NODE_SOURCE_F (1ULL << 0) /**< Node type is source. */ > > + rte_node_process_t process; /**< Node process function. */ > > + rte_node_init_t init; /**< Node init function. */ > > + rte_node_fini_t fini; /**< Node fini function. */ > > + rte_node_t id; /**< Node Identifier. */ > > + rte_node_t parent_id; /**< Identifier of parent node. */ > > + rte_edge_t nb_edges; /**< Number of edges from this node. */ > > + const char *next_nodes[]; /**< Names of next nodes. */ > > Not nodes ids? It seems that basic handle for graph/node is its name - > not an id or pointer. Is it so? If so could you shed some light why it > is better/more convenient? Late binding of nodes during graph creation? Yes. This node name can be filled in registration time when NODE ID is not known. > > +/** > > + * @warning > > + * @b EXPERIMENTAL: this API may change without prior notice > > + * > > + * Destroy Graph. > > + * > > + * Free Graph memory reel. > > + * > > + * @param name > > + * Name of the graph to destroy. > > + * > > + * @return > > + * 0 on success, error otherwise. > > + */ > > +__rte_experimental > > +rte_graph_t rte_graph_destroy(const char *name); > > Why rte_graph_t on return? I have no experience with this but would > expect to have rte_graph_t (id) to be the handle via which graph is kept > (this is what rte_graph_create() returns) so would expect rte_graph_t to > be the input arg here. In order to look API synergy, I have returned rte_graph_t everywhere. But you are right. I will change "int" and pass the ID. > > [...] > > +/** > > + * @warning > > + * @b EXPERIMENTAL: this API may change without prior notice > > + * > > + * Export the graph as graph viz dot file > > + * > > + * @param name > > + * Name of the graph to export. > > + * @param f > > + * File pointer to export the graph. > > + * > > + * @return > > + * 0 on success, error otherwise. > > + */ > > +__rte_experimental > > +rte_graph_t rte_graph_export(const char *name, FILE *f); > > Why rte_graph_t on return? Will change to int. > > [...] > > +/** > > + * @warning > > + * @b EXPERIMENTAL: this API may change without prior notice > > + * > > + * Get maximum number of graph available. > > + * > > + * @return > > + * Maximum graph count on success, RTE_GRAPH_ID_INVALID otherwise. > > + */ > > +__rte_experimental > > +rte_graph_t rte_graph_max_count(void); > > Why rte_graph_t on return? And why RTE_GRAPH_ID_IVALID can be returned? Graph node ID is expressed in rte_graph_t. Yes RTE_GRAPH_ID_IVALID can not be returned, I will remove it. > > [...] > > +/** > > + * @warning > > + * @b EXPERIMENTAL: this API may change without prior notice > > + * > > + * Get node object with in graph from id. > > + * > > + * @param graph_id > > + * Graph id to get node pointer from. > > + * @param node_id > > + * Node id to get node pointer. > > + * > > + * @return > > + * Node pointer on success, NULL otherwise. > > + */ > > +__rte_experimental > > +struct rte_node *rte_graph_node_get(rte_graph_t graph_id, uint32_t node_id); > > Maybe rte_node_t (or its changed name if you accept earlier comment) > instead of uint32_t? Yes. I will change to rte_node_id_t. > > [...] > > +/** > > + * @warning > > + * @b EXPERIMENTAL: this API may change without prior notice > > + * > > + * Register new packet processing node. Nodes can be registered > > + * dynamically via this call or statically via the RTE_NODE_REGISTER > > + * macro. > > + * > > + * @param node > > + * Valid node pointer with name, process function and next_nodes. > > + * > > + * @return > > + * Valid node id on success, RTE_NODE_ID_INVALID otherwise. > > + * > > + * @see RTE_NODE_REGISTER() > > + */ > > +__rte_experimental > > +rte_node_t __rte_node_register(const struct rte_node_register *node); > > + > > +/** > > + * Register a static node. > > + * > > + * The static node is registered through the constructor scheme, thereby, it can > > + * be used in a multi-process scenario. > > + * > > + * @param node > > + * Valid node pointer with name, process function, and next_nodes. > > + */ > > +#define RTE_NODE_REGISTER(node) \ > > + RTE_INIT(rte_node_register_##node) \ > > + { \ > > + node.parent_id = RTE_NODE_ID_INVALID; \ > > + node.id = __rte_node_register(&node); \ > > + } > > I would position rte_node_register struct definition near these so they > are grouped by "topic". No strong opinion on this. I will take your suggestion. > > [...] > > +/** > > + * @warning > > + * @b EXPERIMENTAL: this API may change without prior notice > > + * > > + * Get the number of edges for a node from node id. > > + * > > + * @param id > > + * Valid node id. > > + * > > + * @return > > + * Valid edge count on success, RTE_EDGE_ID_INVALID otherwise. > > + */ > > +__rte_experimental > > +rte_edge_t rte_node_edge_count(rte_node_t id); > > I would clarify here what edge is? Incoming nodes, next-nodes or both. It is next-node. I will update the doc. > Why edge-id typedef on return and why EDGE_ID_INVALID returned. Would > int/-EINVAL (for wrong 'id') be better? Edge node ID is expressed in rte_edge_id_t. SO, I think, it fine to return rte_edge_id_t. "This would avoid any compassion issue as well." > > > + > > +/** > > + * @warning > > + * @b EXPERIMENTAL: this API may change without prior notice > > + * > > + * Update the edges for a node from node id. > > + * > > + * @param id > > + * Valid node id. > > + * @param from > > + * Index to update the edges from. RTE_EDGE_ID_INVALID is valid, > > + * in that case, it will be added to the end of the list. > > + * @param next_nodes > > + * Name of the edges to update. > > + * @param nb_edges > > + * Number of edges to update. > > + * > > + * @return > > + * Valid edge count on success, 0 otherwise. > > + */ > > +__rte_experimental > > +rte_edge_t rte_node_edge_update(rte_node_t id, rte_edge_t from, > > + const char **next_nodes, uint16_t nb_edges); > > So from this I infer that edge is either incoming or outgoing - right? Next node. > > > + > > +/** > > + * @warning > > + * @b EXPERIMENTAL: this API may change without prior notice > > + * > > + * Shrink the edges to a given size. > > + * > > + * @param id > > + * Valid node id. > > + * @param size > > + * New size to shrink the edges. > > + * > > + * @return > > + * New size on success, RTE_EDGE_ID_INVALID otherwise. > > + */ > > +__rte_experimental > > +rte_edge_t rte_node_edge_shrink(rte_node_t id, rte_edge_t size); > > + > > +/** > > + * @warning > > + * @b EXPERIMENTAL: this API may change without prior notice > > + * > > + * Get the edge names from a given node. > > + * > > + * @param id > > + * Valid node id. > > + * @param[out] next_nodes > > + * Buffer to copy the edge names. The NULL value is allowed in that case, > > + * the function returns the size of the array that needs to be allocated. > > + * > > + * @return > > + * When next_nodes == NULL, it returns the size of the array else > > + * number of item copied. > > + */ > > +__rte_experimental > > +rte_node_t rte_node_edge_get(rte_node_t id, char *next_nodes[]); > > I guess this doesn't copy names just stores pointers to names. Copy the names too. > > > +/** > > + * @warning > > + * @b EXPERIMENTAL: this API may change without prior notice > > + * > > + * Get maximum nodes created so far. > > + * > > + * @return > > + * Maximum nodes count on success, 0 otherwise. > > + */ > > +__rte_experimental > > +rte_node_t rte_node_max_count(void); > > If this is "created so far" then why call it 'max'? I guess this is max > possible so I would update description. Yes. I will change to max possible in the description. > > [...] > > With regards > Andrzej Ostruszka
next prev parent reply index Thread overview: 219+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-03-18 21:35 [dpdk-dev] [PATCH v1 00/26] graph: introduce graph subsystem jerinj 2020-03-18 21:35 ` [dpdk-dev] [PATCH v1 01/26] graph: define the public API for graph support jerinj 2020-03-18 21:35 ` [dpdk-dev] [PATCH v1 02/26] graph: implement node registration jerinj 2020-03-18 21:35 ` [dpdk-dev] [PATCH v1 03/26] graph: implement node operations jerinj 2020-03-18 21:35 ` [dpdk-dev] [PATCH v1 04/26] graph: implement node debug routines jerinj 2020-03-18 21:35 ` [dpdk-dev] [PATCH v1 05/26] graph: implement internal graph operation helpers jerinj 2020-03-18 21:35 ` [dpdk-dev] [PATCH v1 06/26] graph: populate fastpath memory for graph reel jerinj 2020-03-18 21:35 ` [dpdk-dev] [PATCH v1 07/26] graph: implement create and destroy APIs jerinj 2020-03-18 21:35 ` [dpdk-dev] [PATCH v1 08/26] graph: implement graph operation APIs jerinj 2020-03-18 21:35 ` [dpdk-dev] [PATCH v1 09/26] graph: implement Graphviz export jerinj 2020-03-18 21:35 ` [dpdk-dev] [PATCH v1 10/26] graph: implement debug routines jerinj 2020-03-18 21:35 ` [dpdk-dev] [PATCH v1 11/26] graph: implement stats support jerinj 2020-03-18 21:35 ` [dpdk-dev] [PATCH v1 12/26] graph: implement fastpath API routines jerinj 2020-03-18 21:35 ` [dpdk-dev] [PATCH v1 13/26] graph: add unit test case jerinj 2020-03-18 21:35 ` [dpdk-dev] [PATCH v1 14/26] graph: add performance testcase jerinj 2020-03-18 21:35 ` [dpdk-dev] [PATCH v1 15/26] node: add log infra and null node jerinj 2020-03-18 21:35 ` [dpdk-dev] [PATCH v1 16/26] node: add ethdev Rx node jerinj 2020-03-18 21:35 ` [dpdk-dev] [PATCH v1 17/26] node: add ethdev Tx node jerinj 2020-03-18 21:35 ` [dpdk-dev] [PATCH v1 18/26] node: add ethdev Rx and Tx node ctrl API jerinj 2020-03-18 21:35 ` [dpdk-dev] [PATCH v1 19/26] node: ipv4 lookup for arm64 jerinj 2020-03-18 21:35 ` [dpdk-dev] [PATCH v1 20/26] node: ipv4 lookup for x86 jerinj 2020-03-19 12:25 ` Ray Kinsella 2020-03-19 14:22 ` [dpdk-dev] [EXT] " Pavan Nikhilesh Bhagavatula 2020-03-19 15:50 ` Ray Kinsella 2020-03-19 16:13 ` Pavan Nikhilesh Bhagavatula 2020-03-20 9:14 ` Ray Kinsella 2020-03-24 9:40 ` Pavan Nikhilesh Bhagavatula 2020-03-24 14:38 ` Ray Kinsella 2020-03-26 9:56 ` Pavan Nikhilesh Bhagavatula 2020-03-26 16:54 ` Ray Kinsella 2020-03-18 21:35 ` [dpdk-dev] [PATCH v1 21/26] node: add ipv4 rewrite node jerinj 2020-03-18 21:35 ` [dpdk-dev] [PATCH v1 22/26] node: add ipv4 rewrite and lookup ctrl API jerinj 2020-03-18 21:35 ` [dpdk-dev] [PATCH v1 23/26] node: add pkt drop node jerinj 2020-03-18 21:35 ` [dpdk-dev] [PATCH v1 24/26] l3fwd-graph: add graph based l3fwd skeleton jerinj 2020-03-18 21:35 ` [dpdk-dev] [PATCH v1 25/26] l3fwd-graph: add ethdev configuration changes jerinj 2020-03-18 21:35 ` [dpdk-dev] [PATCH v1 26/26] l3fwd-graph: add graph config and main loop jerinj 2020-03-26 16:56 ` [dpdk-dev] [PATCH v2 00/28] graph: introduce graph subsystem jerinj 2020-03-26 16:56 ` [dpdk-dev] [PATCH v2 01/28] graph: define the public API for graph support jerinj 2020-03-26 16:56 ` [dpdk-dev] [PATCH v2 02/28] graph: implement node registration jerinj 2020-03-26 16:56 ` [dpdk-dev] [PATCH v2 03/28] graph: implement node operations jerinj 2020-03-26 16:56 ` [dpdk-dev] [PATCH v2 04/28] graph: implement node debug routines jerinj 2020-03-26 16:56 ` [dpdk-dev] [PATCH v2 05/28] graph: implement internal graph operation helpers jerinj 2020-03-26 16:56 ` [dpdk-dev] [PATCH v2 06/28] graph: populate fastpath memory for graph reel jerinj 2020-03-26 16:56 ` [dpdk-dev] [PATCH v2 07/28] graph: implement create and destroy APIs jerinj 2020-03-26 16:56 ` [dpdk-dev] [PATCH v2 08/28] graph: implement graph operation APIs jerinj 2020-03-26 16:56 ` [dpdk-dev] [PATCH v2 09/28] graph: implement Graphviz export jerinj 2020-03-26 16:56 ` [dpdk-dev] [PATCH v2 10/28] graph: implement debug routines jerinj 2020-03-26 16:56 ` [dpdk-dev] [PATCH v2 11/28] graph: implement stats support jerinj 2020-03-26 16:56 ` [dpdk-dev] [PATCH v2 12/28] graph: implement fastpath API routines jerinj 2020-03-26 16:56 ` [dpdk-dev] [PATCH v2 13/28] graph: add unit test case jerinj 2020-03-26 16:56 ` [dpdk-dev] [PATCH v2 14/28] graph: add performance testcase jerinj 2020-03-26 16:56 ` [dpdk-dev] [PATCH v2 15/28] node: add log infra and null node jerinj 2020-03-26 16:56 ` [dpdk-dev] [PATCH v2 16/28] node: add ethdev Rx node jerinj 2020-03-26 16:56 ` [dpdk-dev] [PATCH v2 17/28] node: add ethdev Tx node jerinj 2020-03-26 16:56 ` [dpdk-dev] [PATCH v2 18/28] node: add ethdev Rx and Tx node ctrl API jerinj 2020-03-26 16:56 ` [dpdk-dev] [PATCH v2 19/28] node: ipv4 lookup for arm64 jerinj 2020-03-26 16:56 ` [dpdk-dev] [PATCH v2 20/28] node: ipv4 lookup for x86 jerinj 2020-03-27 8:40 ` Jerin Jacob 2020-03-26 16:56 ` [dpdk-dev] [PATCH v2 21/28] node: add ipv4 rewrite node jerinj 2020-03-26 16:56 ` [dpdk-dev] [PATCH v2 22/28] node: add ipv4 rewrite and lookup ctrl API jerinj 2020-03-26 16:56 ` [dpdk-dev] [PATCH v2 23/28] node: add pkt drop node jerinj 2020-03-26 16:56 ` [dpdk-dev] [PATCH v2 24/28] l3fwd-graph: add graph based l3fwd skeleton jerinj 2020-03-26 16:56 ` [dpdk-dev] [PATCH v2 25/28] l3fwd-graph: add ethdev configuration changes jerinj 2020-03-26 16:56 ` [dpdk-dev] [PATCH v2 26/28] l3fwd-graph: add graph config and main loop jerinj 2020-03-26 16:56 ` [dpdk-dev] [PATCH v2 27/28] doc: add graph library programmer's guide guide jerinj 2020-03-26 16:56 ` [dpdk-dev] [PATCH v2 28/28] doc: add l3fwd graph application user guide jerinj 2020-03-27 6:49 ` [dpdk-dev] [PATCH v2 00/28] graph: introduce graph subsystem Jerin Jacob 2020-03-27 10:42 ` Thomas Monjalon 2020-03-31 19:29 ` [dpdk-dev] [PATCH v3 00/29] " jerinj 2020-03-31 19:29 ` [dpdk-dev] [PATCH v3 01/29] graph: define the public API for graph support jerinj 2020-04-03 9:26 ` Wang, Xiao W 2020-04-04 12:15 ` Jerin Jacob 2020-04-06 12:36 ` Andrzej Ostruszka 2020-04-06 14:59 ` Jerin Jacob [this message] 2020-04-06 16:09 ` Andrzej Ostruszka 2020-04-07 10:27 ` Jerin Jacob 2020-03-31 19:29 ` [dpdk-dev] [PATCH v3 02/29] graph: implement node registration jerinj 2020-04-03 10:44 ` Wang, Xiao W 2020-04-04 12:29 ` Jerin Jacob 2020-03-31 19:29 ` [dpdk-dev] [PATCH v3 03/29] graph: implement node operations jerinj 2020-04-03 10:54 ` Wang, Xiao W 2020-04-04 13:07 ` Jerin Jacob 2020-03-31 19:29 ` [dpdk-dev] [PATCH v3 04/29] graph: implement node debug routines jerinj 2020-04-04 7:57 ` Wang, Xiao W 2020-04-04 13:12 ` Jerin Jacob 2020-03-31 19:29 ` [dpdk-dev] [PATCH v3 05/29] graph: implement internal graph operation helpers jerinj 2020-04-06 13:47 ` Wang, Xiao W 2020-04-06 14:08 ` Jerin Jacob 2020-03-31 19:29 ` [dpdk-dev] [PATCH v3 06/29] graph: populate fastpath memory for graph reel jerinj 2020-03-31 19:29 ` [dpdk-dev] [PATCH v3 07/29] graph: implement create and destroy APIs jerinj 2020-03-31 19:29 ` [dpdk-dev] [PATCH v3 08/29] graph: implement graph operation APIs jerinj 2020-03-31 19:29 ` [dpdk-dev] [PATCH v3 09/29] graph: implement Graphviz export jerinj 2020-03-31 19:29 ` [dpdk-dev] [PATCH v3 10/29] graph: implement debug routines jerinj 2020-03-31 19:29 ` [dpdk-dev] [PATCH v3 11/29] graph: implement stats support jerinj 2020-03-31 19:29 ` [dpdk-dev] [PATCH v3 12/29] graph: implement fastpath API routines jerinj 2020-03-31 19:29 ` [dpdk-dev] [PATCH v3 13/29] graph: add unit test case jerinj 2020-03-31 19:29 ` [dpdk-dev] [PATCH v3 14/29] graph: add performance testcase jerinj 2020-03-31 19:29 ` [dpdk-dev] [PATCH v3 15/29] node: add log infra and null node jerinj 2020-03-31 19:29 ` [dpdk-dev] [PATCH v3 16/29] node: add ethdev Rx node jerinj 2020-03-31 19:29 ` [dpdk-dev] [PATCH v3 17/29] node: add ethdev Tx node jerinj 2020-03-31 19:29 ` [dpdk-dev] [PATCH v3 18/29] node: add ethdev Rx and Tx node ctrl API jerinj 2020-03-31 19:29 ` [dpdk-dev] [PATCH v3 19/29] node: add generic ipv4 lookup node jerinj 2020-03-31 19:29 ` [dpdk-dev] [PATCH v3 20/29] node: ipv4 lookup for arm64 jerinj 2020-03-31 19:29 ` [dpdk-dev] [PATCH v3 21/29] node: ipv4 lookup for x86 jerinj 2020-03-31 19:29 ` [dpdk-dev] [PATCH v3 22/29] node: add ipv4 rewrite node jerinj 2020-03-31 19:29 ` [dpdk-dev] [PATCH v3 23/29] node: add ipv4 rewrite and lookup ctrl API jerinj 2020-03-31 19:29 ` [dpdk-dev] [PATCH v3 24/29] node: add packet drop node jerinj 2020-03-31 19:29 ` [dpdk-dev] [PATCH v3 25/29] l3fwd-graph: add graph based l3fwd skeleton jerinj 2020-03-31 19:29 ` [dpdk-dev] [PATCH v3 26/29] l3fwd-graph: add ethdev configuration changes jerinj 2020-03-31 19:29 ` [dpdk-dev] [PATCH v3 27/29] l3fwd-graph: add graph config and main loop jerinj 2020-03-31 19:29 ` [dpdk-dev] [PATCH v3 28/29] doc: add graph library programmer's guide guide jerinj 2020-03-31 19:29 ` [dpdk-dev] [PATCH v3 29/29] doc: add l3fwd graph application user guide jerinj 2020-04-05 8:55 ` [dpdk-dev] [PATCH v4 00/29] graph: introduce graph subsystem jerinj 2020-04-05 8:55 ` [dpdk-dev] [PATCH v4 01/29] graph: define the public API for graph support jerinj 2020-04-05 8:55 ` [dpdk-dev] [PATCH v4 02/29] graph: implement node registration jerinj 2020-04-05 8:55 ` [dpdk-dev] [PATCH v4 03/29] graph: implement node operations jerinj 2020-04-06 17:57 ` Andrzej Ostruszka 2020-04-07 2:43 ` [dpdk-dev] [EXT] " Kiran Kumar Kokkilagadda 2020-04-07 8:47 ` Andrzej Ostruszka 2020-04-07 10:20 ` Jerin Jacob 2020-04-05 8:55 ` [dpdk-dev] [PATCH v4 04/29] graph: implement node debug routines jerinj 2020-04-06 18:17 ` Andrzej Ostruszka 2020-04-07 10:22 ` Jerin Jacob 2020-04-07 11:50 ` Andrzej Ostruszka 2020-04-07 12:09 ` Jerin Jacob 2020-04-07 12:50 ` Andrzej Ostruszka 2020-04-05 8:55 ` [dpdk-dev] [PATCH v4 05/29] graph: implement internal graph operation helpers jerinj 2020-04-07 12:16 ` Andrzej Ostruszka 2020-04-07 12:27 ` Jerin Jacob 2020-04-07 12:54 ` Andrzej Ostruszka 2020-04-07 13:31 ` Jerin Jacob 2020-04-05 8:55 ` [dpdk-dev] [PATCH v4 06/29] graph: populate fastpath memory for graph reel jerinj 2020-04-08 17:30 ` Andrzej Ostruszka 2020-04-09 2:44 ` Kiran Kumar Kokkilagadda 2020-04-05 8:55 ` [dpdk-dev] [PATCH v4 07/29] graph: implement create and destroy APIs jerinj 2020-04-08 16:57 ` Andrzej Ostruszka 2020-04-08 17:23 ` Jerin Jacob 2020-04-05 8:55 ` [dpdk-dev] [PATCH v4 08/29] graph: implement graph operation APIs jerinj 2020-04-08 17:49 ` Andrzej Ostruszka 2020-04-08 19:18 ` Jerin Jacob 2020-04-05 8:55 ` [dpdk-dev] [PATCH v4 09/29] graph: implement Graphviz export jerinj 2020-04-05 8:55 ` [dpdk-dev] [PATCH v4 10/29] graph: implement debug routines jerinj 2020-04-05 8:55 ` [dpdk-dev] [PATCH v4 11/29] graph: implement stats support jerinj 2020-04-05 8:55 ` [dpdk-dev] [PATCH v4 12/29] graph: implement fastpath API routines jerinj 2020-04-09 23:07 ` Andrzej Ostruszka 2020-04-10 9:18 ` Jerin Jacob 2020-04-05 8:55 ` [dpdk-dev] [PATCH v4 13/29] graph: add unit test case jerinj 2020-04-05 8:55 ` [dpdk-dev] [PATCH v4 14/29] graph: add performance testcase jerinj 2020-04-05 8:55 ` [dpdk-dev] [PATCH v4 15/29] node: add log infra and null node jerinj 2020-04-05 8:56 ` [dpdk-dev] [PATCH v4 16/29] node: add ethdev Rx node jerinj 2020-04-09 23:05 ` Andrzej Ostruszka 2020-04-10 7:00 ` Nithin Dabilpuram 2020-04-05 8:56 ` [dpdk-dev] [PATCH v4 17/29] node: add ethdev Tx node jerinj 2020-04-05 8:56 ` [dpdk-dev] [PATCH v4 18/29] node: add ethdev Rx and Tx node ctrl API jerinj 2020-04-09 23:07 ` Andrzej Ostruszka 2020-04-10 5:09 ` Nithin Dabilpuram 2020-04-10 8:22 ` Nithin Dabilpuram 2020-04-10 12:52 ` Andrzej Ostruszka 2020-04-10 14:54 ` [dpdk-dev] [EXT] " Nithin Dabilpuram 2020-04-05 8:56 ` [dpdk-dev] [PATCH v4 19/29] node: add generic ipv4 lookup node jerinj 2020-04-09 23:07 ` Andrzej Ostruszka 2020-04-10 10:20 ` Nithin Dabilpuram 2020-04-10 14:41 ` Nithin Dabilpuram 2020-04-10 15:17 ` Andrzej Ostruszka 2020-04-05 8:56 ` [dpdk-dev] [PATCH v4 20/29] node: ipv4 lookup for arm64 jerinj 2020-04-05 8:56 ` [dpdk-dev] [PATCH v4 21/29] node: ipv4 lookup for x86 jerinj 2020-04-05 8:56 ` [dpdk-dev] [PATCH v4 22/29] node: add ipv4 rewrite node jerinj 2020-04-05 8:56 ` [dpdk-dev] [PATCH v4 23/29] node: add ipv4 rewrite and lookup ctrl API jerinj 2020-04-09 23:04 ` Andrzej Ostruszka 2020-04-10 7:24 ` Nithin Dabilpuram 2020-04-05 8:56 ` [dpdk-dev] [PATCH v4 24/29] node: add packet drop node jerinj 2020-04-05 8:56 ` [dpdk-dev] [PATCH v4 25/29] l3fwd-graph: add graph based l3fwd skeleton jerinj 2020-04-09 23:04 ` Andrzej Ostruszka 2020-04-10 8:23 ` Nithin Dabilpuram 2020-04-05 8:56 ` [dpdk-dev] [PATCH v4 26/29] l3fwd-graph: add ethdev configuration changes jerinj 2020-04-05 8:56 ` [dpdk-dev] [PATCH v4 27/29] l3fwd-graph: add graph config and main loop jerinj 2020-04-09 23:04 ` Andrzej Ostruszka 2020-04-10 9:29 ` Nithin Dabilpuram 2020-04-05 8:56 ` [dpdk-dev] [PATCH v4 28/29] doc: add graph library programmer's guide guide jerinj 2020-04-05 8:56 ` [dpdk-dev] [PATCH v4 29/29] doc: add l3fwd graph application user guide jerinj 2020-04-09 23:13 ` [dpdk-dev] [PATCH v4 00/29] graph: introduce graph subsystem Andrzej Ostruszka 2020-04-10 9:07 ` Jerin Jacob 2020-04-11 14:13 ` [dpdk-dev] [PATCH v5 " jerinj 2020-04-11 14:14 ` [dpdk-dev] [PATCH v5 01/29] graph: define the public API for graph support jerinj 2020-04-11 14:14 ` [dpdk-dev] [PATCH v5 02/29] graph: implement node registration jerinj 2020-04-11 14:14 ` [dpdk-dev] [PATCH v5 03/29] graph: implement node operations jerinj 2020-04-11 14:14 ` [dpdk-dev] [PATCH v5 04/29] graph: implement node debug routines jerinj 2020-04-11 14:14 ` [dpdk-dev] [PATCH v5 05/29] graph: implement internal graph operation helpers jerinj 2020-04-11 14:14 ` [dpdk-dev] [PATCH v5 06/29] graph: populate fastpath memory for graph reel jerinj 2020-04-11 14:14 ` [dpdk-dev] [PATCH v5 07/29] graph: implement create and destroy APIs jerinj 2020-04-11 14:14 ` [dpdk-dev] [PATCH v5 08/29] graph: implement graph operation APIs jerinj 2020-04-11 14:14 ` [dpdk-dev] [PATCH v5 09/29] graph: implement Graphviz export jerinj 2020-04-11 14:14 ` [dpdk-dev] [PATCH v5 10/29] graph: implement debug routines jerinj 2020-04-11 14:14 ` [dpdk-dev] [PATCH v5 11/29] graph: implement stats support jerinj 2020-04-11 14:14 ` [dpdk-dev] [PATCH v5 12/29] graph: implement fastpath API routines jerinj 2020-04-11 14:14 ` [dpdk-dev] [PATCH v5 13/29] graph: add unit test case jerinj 2020-04-11 14:14 ` [dpdk-dev] [PATCH v5 14/29] graph: add performance testcase jerinj 2020-04-11 14:14 ` [dpdk-dev] [PATCH v5 15/29] node: add log infra and null node jerinj 2020-04-11 14:14 ` [dpdk-dev] [PATCH v5 16/29] node: add ethdev Rx node jerinj 2020-04-11 14:14 ` [dpdk-dev] [PATCH v5 17/29] node: add ethdev Tx node jerinj 2020-04-11 14:14 ` [dpdk-dev] [PATCH v5 18/29] node: add ethdev Rx and Tx node ctrl API jerinj 2020-04-11 14:14 ` [dpdk-dev] [PATCH v5 19/29] node: add generic ipv4 lookup node jerinj 2020-04-11 14:14 ` [dpdk-dev] [PATCH v5 20/29] node: ipv4 lookup for arm64 jerinj 2020-05-12 9:31 ` David Marchand 2020-05-12 9:50 ` [dpdk-dev] [EXT] " Nithin Dabilpuram 2020-04-11 14:14 ` [dpdk-dev] [PATCH v5 21/29] node: ipv4 lookup for x86 jerinj 2020-04-11 14:14 ` [dpdk-dev] [PATCH v5 22/29] node: add ipv4 rewrite node jerinj 2020-04-11 14:14 ` [dpdk-dev] [PATCH v5 23/29] node: add ipv4 rewrite and lookup ctrl API jerinj 2020-04-11 14:14 ` [dpdk-dev] [PATCH v5 24/29] node: add packet drop node jerinj 2020-04-11 14:14 ` [dpdk-dev] [PATCH v5 25/29] l3fwd-graph: add graph based l3fwd skeleton jerinj 2020-04-11 14:14 ` [dpdk-dev] [PATCH v5 26/29] l3fwd-graph: add ethdev configuration changes jerinj 2020-04-11 14:14 ` [dpdk-dev] [PATCH v5 27/29] l3fwd-graph: add graph config and main loop jerinj 2020-04-11 14:14 ` [dpdk-dev] [PATCH v5 28/29] doc: add graph library programmer's guide guide jerinj 2020-05-11 9:27 ` David Marchand 2020-05-11 9:30 ` Jerin Jacob 2020-04-11 14:14 ` [dpdk-dev] [PATCH v5 29/29] doc: add l3fwd graph application user guide jerinj 2020-04-30 8:07 ` [dpdk-dev] [PATCH v5 00/29] graph: introduce graph subsystem Tom Barbette 2020-04-30 8:42 ` Jerin Jacob 2020-05-05 21:44 ` Thomas Monjalon
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CALBAE1OphsRyKsT15tvnpvCY+Y-mC6VNbgUhmUVzhU0bH8_62w@mail.gmail.com \ --to=jerinjacobk@gmail.com \ --cc=amo@semihalf.com \ --cc=dev@dpdk.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK-dev Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/dpdk-dev/0 dpdk-dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dpdk-dev dpdk-dev/ https://lore.kernel.org/dpdk-dev \ dev@dpdk.org public-inbox-index dpdk-dev Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git