From: Jerin Jacob <jerinjacobk@gmail.com> To: Thomas Monjalon <thomas@monjalon.net> Cc: Joyce Kong <Joyce.Kong@arm.com>, Gavin Hu <Gavin.Hu@arm.com>, "stephen@networkplumber.org" <stephen@networkplumber.org>, "david.marchand@redhat.com" <david.marchand@redhat.com>, "mb@smartsharesystems.com" <mb@smartsharesystems.com>, "jerinj@marvell.com" <jerinj@marvell.com>, "bruce.richardson@intel.com" <bruce.richardson@intel.com>, "ravi1.kumar@amd.com" <ravi1.kumar@amd.com>, "rmody@marvell.com" <rmody@marvell.com>, "shshaikh@marvell.com" <shshaikh@marvell.com>, "xuanziyang2@huawei.com" <xuanziyang2@huawei.com>, "cloud.wangxiaoyun@huawei.com" <cloud.wangxiaoyun@huawei.com>, "zhouguoyang@huawei.com" <zhouguoyang@huawei.com>, Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>, Phil Yang <Phil.Yang@arm.com>, nd <nd@arm.com>, "dev@dpdk.org" <dev@dpdk.org> Subject: Re: [dpdk-dev] [PATCH v7 1/6] lib/eal: implement the family of PMD bit operation APIs Date: Thu, 2 Apr 2020 13:41:59 +0530 Message-ID: <CALBAE1PHC144jvvO4jPb9y_yaFaZAbKMFh68eGvGcq+LEZHrOA@mail.gmail.com> (raw) In-Reply-To: <2838900.VqyquhjGfd@xps> On Thu, Apr 2, 2020 at 1:37 PM Thomas Monjalon <thomas@monjalon.net> wrote: > > 02/04/2020 09:20, Gavin Hu: > > Hi Thomas, > > > > > -----Original Message----- > > > From: Thomas Monjalon <thomas@monjalon.net> > > > Sent: Wednesday, April 1, 2020 5:45 PM > > > To: Joyce Kong <Joyce.Kong@arm.com>; Gavin Hu <Gavin.Hu@arm.com> > > > Cc: stephen@networkplumber.org; david.marchand@redhat.com; > > > mb@smartsharesystems.com; jerinj@marvell.com; > > > bruce.richardson@intel.com; ravi1.kumar@amd.com; rmody@marvell.com; > > > shshaikh@marvell.com; xuanziyang2@huawei.com; > > > cloud.wangxiaoyun@huawei.com; zhouguoyang@huawei.com; Honnappa > > > Nagarahalli <Honnappa.Nagarahalli@arm.com>; Phil Yang > > > <Phil.Yang@arm.com>; nd <nd@arm.com>; dev@dpdk.org; nd > > > <nd@arm.com> > > > Subject: Re: [dpdk-dev] [PATCH v7 1/6] lib/eal: implement the family of PMD > > > bit operation APIs > > > > > > 01/04/2020 10:27, Gavin Hu: > > > > Hi Thomas, > > > > > > > > From: Thomas Monjalon <thomas@monjalon.net> > > > > > > > > > > Hi, > > > > > > > > > > 09/03/2020 10:54, Joyce Kong: > > > > > > Bitwise operation APIs are defined and used in a lot of PMDs, > > > > > > which caused a huge code duplication. > > > > > > > > > > Statistics of the series: 653 insertions(+), 326 deletions(-) > > > > > I would not say it is a huge duplication. > > > > We did not include all PMDs, just a few for piloting and seeking opinions. > > > > It is a huge duplication when counting all the PMDs. > > > > > > > > > > > To reduce duplication, > > > > > > this patch consolidates them into a common API family. > > > > > [...] > > > > > > +PMD Bitops > > > > > > +M: Joyce Kong <joyce.kong@arm.com> > > > > > > +F: lib/librte_eal/common/include/rte_pmd_bitops.h Change to lib/librte_eal/include/rte_pmd_bitops.h. Check top of tree. > > > > > > > > > > Why is it called PMD bitops and not simply bitops? > > > > > > > > The scope of these APIs are decreased to PMD use only, for > > > libraries/applications, it is recommended to use C11 directly as there are > > > complications of more ordering models involved. > > > > > > OK, but PMD means nothing, except this is where it is used *now*. > > > Please describe and name the API with memory ordering words. > > Will remove 'PMD' in v8. > > The APIs were already named with a '_relaxed' suffix, for example 'rte_get_bit64_relaxed'. > > According to Honnappa, this patch set just address PMD's requirement, and the current PMDs are not using C11, so only '_relaxed' version is offered. > > http://inbox.dpdk.org/dev/VE1PR08MB514983C3200859B27F166EBB983F0@VE1PR08MB5149.eurprd08.prod.outlook.com/ > > So why not calling this component "relaxed bitops"? In the future, we can extend to more memory orders as needed. IMO, Just changing to rte_bitops.h is enough. > > > >
next prev parent reply index Thread overview: 139+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-10-15 7:49 [dpdk-dev] [PATCH v1 0/5] implement common rte bit operation APIs in PMDs Joyce Kong 2019-10-15 7:49 ` [dpdk-dev] [PATCH v1 1/5] lib/eal: implement the family of rte bit operation APIs Joyce Kong 2019-10-15 16:53 ` Stephen Hemminger 2019-10-18 9:00 ` Joyce Kong (Arm Technology China) 2019-10-16 7:54 ` Jerin Jacob 2019-10-18 9:02 ` Joyce Kong (Arm Technology China) 2019-10-23 3:12 ` Joyce Kong (Arm Technology China) 2019-10-16 19:05 ` Stephen Hemminger 2019-10-17 13:32 ` [dpdk-dev] [PATCH v1 1/5] lib/eal: implement the family of rte bitoperation APIs Morten Brørup 2019-10-18 8:58 ` Joyce Kong (Arm Technology China) 2019-10-23 3:07 ` Joyce Kong (Arm Technology China) 2019-10-23 7:45 ` Morten Brørup 2019-10-23 17:30 ` Honnappa Nagarahalli 2019-10-24 3:38 ` Gavin Hu (Arm Technology China) 2019-11-01 13:48 ` Honnappa Nagarahalli 2019-11-03 15:45 ` Gavin Hu (Arm Technology China) 2019-10-15 7:49 ` [dpdk-dev] [PATCH v1 2/5] net/axgbe: use common rte bit operation APIs instead Joyce Kong 2019-10-15 7:49 ` [dpdk-dev] [PATCH v1 3/5] net/bnx2x: " Joyce Kong 2019-10-15 7:50 ` [dpdk-dev] [PATCH v1 4/5] net/hinic: " Joyce Kong 2019-10-15 7:50 ` [dpdk-dev] [PATCH v1 5/5] net/qede: " Joyce Kong 2019-10-15 16:51 ` [dpdk-dev] [PATCH v1 0/5] implement common rte bit operation APIs in PMDs Stephen Hemminger 2019-10-18 9:01 ` Joyce Kong (Arm Technology China) 2019-10-23 2:54 ` [dpdk-dev] [PATCH v2 0/6] " Joyce Kong 2019-10-25 13:14 ` David Marchand 2019-10-29 16:42 ` Thomas Monjalon 2019-10-30 9:55 ` Gavin Hu (Arm Technology China) 2019-10-30 10:17 ` Thomas Monjalon 2019-10-30 12:32 ` Jerin Jacob 2019-10-30 13:02 ` Morten Brørup 2019-10-31 10:39 ` Gavin Hu (Arm Technology China) 2019-10-23 2:54 ` [dpdk-dev] [PATCH v2 1/6] lib/eal: implement the family of rte bit operation APIs Joyce Kong 2019-10-23 3:09 ` Honnappa Nagarahalli 2019-10-23 4:56 ` Jerin Jacob 2019-10-23 7:46 ` Morten Brørup 2019-10-23 2:54 ` [dpdk-dev] [PATCH v2 2/6] test/iobitops: add io bit operation test case Joyce Kong 2019-10-23 2:54 ` [dpdk-dev] [PATCH v2 3/6] net/axgbe: use common rte bit operation APIs instead Joyce Kong 2019-10-23 3:16 ` Honnappa Nagarahalli 2019-10-23 2:54 ` [dpdk-dev] [PATCH v2 4/6] net/bnx2x: " Joyce Kong 2019-10-23 2:54 ` [dpdk-dev] [PATCH v2 5/6] net/hinic: " Joyce Kong 2019-10-23 2:54 ` [dpdk-dev] [PATCH v2 6/6] net/qede: " Joyce Kong 2019-11-18 10:06 ` [dpdk-dev] [PATCH v3 0/6] implement common rte bit operation APIs in PMDs Joyce Kong 2019-11-18 10:06 ` [dpdk-dev] [PATCH v3 1/6] lib/eal: implement the family of rte bit operation APIs Joyce Kong 2019-11-18 10:52 ` [dpdk-dev] [PATCH v3 1/6] lib/eal: implement the family of rte bitoperation APIs Morten Brørup 2019-11-19 9:22 ` Joyce Kong (Arm Technology China) 2019-11-18 10:06 ` [dpdk-dev] [PATCH v3 2/6] test/bitops: add bit operation test case Joyce Kong 2019-11-18 10:06 ` [dpdk-dev] [PATCH v3 3/6] net/axgbe: use common rte bit operation APIs instead Joyce Kong 2019-11-18 10:06 ` [dpdk-dev] [PATCH v3 4/6] net/bnx2x: " Joyce Kong 2019-11-18 10:06 ` [dpdk-dev] [PATCH v3 5/6] net/qede: " Joyce Kong 2019-11-18 10:06 ` [dpdk-dev] [PATCH v3 6/6] net/hinic: " Joyce Kong 2019-11-20 10:12 ` [dpdk-dev] [PATCH v4 0/6] implement common rte bit operation APIs in PMDs Joyce Kong 2019-11-20 10:12 ` [dpdk-dev] [PATCH v4 1/6] lib/eal: implement the family of rte bit operation APIs Joyce Kong 2019-11-20 13:40 ` [dpdk-dev] [PATCH v4 1/6] lib/eal: implement the family of rte bitoperation APIs Morten Brørup 2019-11-20 10:12 ` [dpdk-dev] [PATCH v4 2/6] test/bitops: add bit operation test case Joyce Kong 2019-11-20 10:12 ` [dpdk-dev] [PATCH v4 3/6] net/axgbe: use common rte bit operation APIs instead Joyce Kong 2019-11-20 10:12 ` [dpdk-dev] [PATCH v4 4/6] net/bnx2x: " Joyce Kong 2019-11-20 10:12 ` [dpdk-dev] [PATCH v4 5/6] net/qede: " Joyce Kong 2019-11-20 10:12 ` [dpdk-dev] [PATCH v4 6/6] net/hinic: " Joyce Kong 2019-11-28 6:44 ` [dpdk-dev] [PATCH v5 0/6] implement common rte bit operation APIs in PMDs Joyce Kong 2019-11-28 6:44 ` [dpdk-dev] [PATCH v5 1/6] lib/eal: implement the family of rte bit operation APIs Joyce Kong 2019-11-28 6:44 ` [dpdk-dev] [PATCH v5 2/6] test/bitops: add bit operation test case Joyce Kong 2019-11-28 6:44 ` [dpdk-dev] [PATCH v5 3/6] net/axgbe: use common rte bit operation APIs instead Joyce Kong 2019-12-02 6:09 ` Gavin Hu (Arm Technology China) 2019-12-02 9:12 ` Thomas Monjalon 2019-12-02 9:24 ` [dpdk-dev] [PATCH v5 3/6] net/axgbe: use common rte bitoperation " Morten Brørup 2019-12-02 9:30 ` Thomas Monjalon 2019-12-02 16:53 ` Stephen Hemminger 2019-12-03 6:52 ` Gavin Hu (Arm Technology China) 2019-11-28 6:44 ` [dpdk-dev] [PATCH v5 4/6] net/bnx2x: use common rte bit operation " Joyce Kong 2019-11-28 6:44 ` [dpdk-dev] [PATCH v5 5/6] net/qede: " Joyce Kong 2019-11-28 6:44 ` [dpdk-dev] [PATCH v5 6/6] net/hinic: " Joyce Kong 2019-12-18 6:00 ` [dpdk-dev] [PATCH v6 0/6] implement common rte bit operation APIs in PMDs Joyce Kong 2019-12-18 6:55 ` Gavin Hu 2020-01-17 13:03 ` David Marchand 2019-12-18 6:00 ` [dpdk-dev] [PATCH v6 1/6] lib/eal: implement the family of rte bit operation APIs Joyce Kong 2019-12-20 6:52 ` Honnappa Nagarahalli 2019-12-21 16:07 ` Honnappa Nagarahalli 2019-12-21 18:07 ` Stephen Hemminger 2019-12-23 5:04 ` Honnappa Nagarahalli 2019-12-23 16:36 ` Stephen Hemminger 2019-12-30 3:02 ` Gavin Hu 2020-01-07 0:44 ` Honnappa Nagarahalli 2020-01-07 1:26 ` Stephen Hemminger 2020-01-07 4:41 ` Honnappa Nagarahalli 2020-01-07 0:41 ` Honnappa Nagarahalli 2019-12-21 18:08 ` Stephen Hemminger 2019-12-23 5:45 ` Honnappa Nagarahalli 2019-12-23 8:59 ` Jerin Jacob 2019-12-18 6:00 ` [dpdk-dev] [PATCH v6 2/6] test/bitops: add bit operation test case Joyce Kong 2019-12-18 6:00 ` [dpdk-dev] [PATCH v6 3/6] net/axgbe: use common rte bit operation APIs instead Joyce Kong 2019-12-18 6:00 ` [dpdk-dev] [PATCH v6 4/6] net/bnx2x: " Joyce Kong 2019-12-18 6:00 ` [dpdk-dev] [PATCH v6 5/6] net/qede: " Joyce Kong 2019-12-18 6:00 ` [dpdk-dev] [PATCH v6 6/6] net/hinic: " Joyce Kong 2020-03-09 9:54 ` [dpdk-dev] [PATCH v7 0/6] implement common rte bit operation APIs in PMDs Joyce Kong 2020-03-09 9:54 ` [dpdk-dev] [PATCH v7 1/6] lib/eal: implement the family of PMD bit operation APIs Joyce Kong 2020-03-09 15:50 ` Stephen Hemminger 2020-03-31 22:35 ` Thomas Monjalon 2020-04-01 8:27 ` Gavin Hu 2020-04-01 9:45 ` Thomas Monjalon 2020-04-02 7:20 ` Gavin Hu 2020-04-02 8:07 ` Thomas Monjalon 2020-04-02 8:11 ` Jerin Jacob [this message] 2020-04-02 9:02 ` Gavin Hu 2020-03-09 9:54 ` [dpdk-dev] [PATCH v7 2/6] test/pmdbitops: add PMD bit operation test case Joyce Kong 2020-03-09 9:54 ` [dpdk-dev] [PATCH v7 3/6] net/axgbe: use common rte bit operation APIs instead Joyce Kong 2020-03-09 9:54 ` [dpdk-dev] [PATCH v7 4/6] net/bnx2x: " Joyce Kong 2020-03-09 9:54 ` [dpdk-dev] [PATCH v7 5/6] net/qede: " Joyce Kong 2020-03-09 9:54 ` [dpdk-dev] [PATCH v7 6/6] net/hinic: " Joyce Kong 2020-04-16 5:38 ` [dpdk-dev] [PATCH v8 0/6] implement common bit operation APIs Joyce Kong 2020-04-16 5:38 ` [dpdk-dev] [PATCH v8 1/6] lib/eal: implement the family of " Joyce Kong 2020-04-16 18:55 ` [dpdk-dev] [PATCH v8 1/6] lib/eal: implement the family of commonbit " Morten Brørup 2020-04-17 8:18 ` Joyce Kong 2020-04-17 9:38 ` [dpdk-dev] [PATCH v8 1/6] lib/eal: implement the family of common bit " Jerin Jacob 2020-04-20 2:46 ` Joyce Kong 2020-04-16 5:38 ` [dpdk-dev] [PATCH v8 2/6] test/bitops: add bit operation test case Joyce Kong 2020-04-16 5:38 ` [dpdk-dev] [PATCH v8 3/6] net/axgbe: use common rte bit operation APIs instead Joyce Kong 2020-04-16 5:38 ` [dpdk-dev] [PATCH v8 4/6] net/bnx2x: " Joyce Kong 2020-04-16 5:38 ` [dpdk-dev] [PATCH v8 5/6] net/qede: " Joyce Kong 2020-04-16 5:38 ` [dpdk-dev] [PATCH v8 6/6] net/hinic: " Joyce Kong 2020-04-24 3:21 ` [dpdk-dev] [PATCH v9 0/6] implement common bit operation APIs Joyce Kong 2020-04-24 3:21 ` [dpdk-dev] [PATCH v9 1/6] lib/eal: implement the family of " Joyce Kong 2020-04-24 8:08 ` Thomas Monjalon 2020-04-26 2:07 ` Joyce Kong 2020-04-25 19:59 ` Thomas Monjalon 2020-04-26 7:18 ` Joyce Kong 2020-04-26 9:23 ` Thomas Monjalon 2020-04-24 3:21 ` [dpdk-dev] [PATCH v9 2/6] test/bitops: add bit operation test case Joyce Kong 2020-04-24 3:21 ` [dpdk-dev] [PATCH v9 3/6] net/axgbe: use common rte bit operation APIs instead Joyce Kong 2020-04-24 3:21 ` [dpdk-dev] [PATCH v9 4/6] net/bnx2x: " Joyce Kong 2020-04-24 3:21 ` [dpdk-dev] [PATCH v9 5/6] net/qede: " Joyce Kong 2020-04-24 3:21 ` [dpdk-dev] [PATCH v9 6/6] net/hinic: " Joyce Kong 2020-04-27 7:58 ` [dpdk-dev] [PATCH v10 0/6] implement common bit operation APIs Joyce Kong 2020-06-16 12:36 ` Thomas Monjalon 2020-04-27 7:58 ` [dpdk-dev] [PATCH v10 1/6] lib/eal: implement the family of " Joyce Kong 2020-04-27 7:58 ` [dpdk-dev] [PATCH v10 2/6] test/bitops: add bit operation test case Joyce Kong 2020-04-27 7:58 ` [dpdk-dev] [PATCH v10 3/6] net/axgbe: use common rte bit operation APIs instead Joyce Kong 2020-04-27 7:58 ` [dpdk-dev] [PATCH v10 4/6] net/bnx2x: " Joyce Kong 2020-04-27 7:58 ` [dpdk-dev] [PATCH v10 5/6] net/qede: " Joyce Kong 2020-04-27 7:58 ` [dpdk-dev] [PATCH v10 6/6] net/hinic: " Joyce Kong 2020-06-16 12:31 ` Thomas Monjalon
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CALBAE1PHC144jvvO4jPb9y_yaFaZAbKMFh68eGvGcq+LEZHrOA@mail.gmail.com \ --to=jerinjacobk@gmail.com \ --cc=Gavin.Hu@arm.com \ --cc=Honnappa.Nagarahalli@arm.com \ --cc=Joyce.Kong@arm.com \ --cc=Phil.Yang@arm.com \ --cc=bruce.richardson@intel.com \ --cc=cloud.wangxiaoyun@huawei.com \ --cc=david.marchand@redhat.com \ --cc=dev@dpdk.org \ --cc=jerinj@marvell.com \ --cc=mb@smartsharesystems.com \ --cc=nd@arm.com \ --cc=ravi1.kumar@amd.com \ --cc=rmody@marvell.com \ --cc=shshaikh@marvell.com \ --cc=stephen@networkplumber.org \ --cc=thomas@monjalon.net \ --cc=xuanziyang2@huawei.com \ --cc=zhouguoyang@huawei.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK-dev Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/dpdk-dev/0 dpdk-dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dpdk-dev dpdk-dev/ https://lore.kernel.org/dpdk-dev \ dev@dpdk.org public-inbox-index dpdk-dev Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git