From mboxrd@z Thu Jan  1 00:00:00 1970
From: Vladimir Medvedkin <medvedkinv@gmail.com>
Subject: Re: [PATCH v4 1/4] Add RIB library
Date: Fri, 27 Apr 2018 09:45:40 +0300
Message-ID: <CANDrEHmgjCnhjqxwBV0XGq=Ytoqc8vVfn5WH_-ZbTgFrcfzG2w@mail.gmail.com>
References: <1524780214-23196-1-git-send-email-medvedkinv@gmail.com>
 <1524780214-23196-2-git-send-email-medvedkinv@gmail.com>
 <20180426152045.07c20b45@xeon-e3>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Cc: dev@dpdk.org, Bruce Richardson <bruce.richardson@intel.com>,
 thomas@monjalon.net, cristian.dumitrescu@intel.com
To: Stephen Hemminger <stephen@networkplumber.org>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-qk0-f181.google.com (mail-qk0-f181.google.com
 [209.85.220.181]) by dpdk.org (Postfix) with ESMTP id 4E05D726F
 for <dev@dpdk.org>; Fri, 27 Apr 2018 08:45:41 +0200 (CEST)
Received: by mail-qk0-f181.google.com with SMTP id p186so627611qkd.1
 for <dev@dpdk.org>; Thu, 26 Apr 2018 23:45:41 -0700 (PDT)
In-Reply-To: <20180426152045.07c20b45@xeon-e3>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Stephen,

Thanks for comments! Will fix in next version.

2018-04-27 1:20 GMT+03:00 Stephen Hemminger <stephen@networkplumber.org>:

> On Fri, 27 Apr 2018 01:03:31 +0300
> Medvedkin Vladimir <medvedkinv@gmail.com> wrote:
>
> > +             /**
> > +              * Intermediate node found.
> > +              * Previous rte_rib_tree_lookup_exact() returned NULL
> > +              * but node with proper search criteria is found.
> > +              * Validate intermediate node and return.
> > +              */
> > +             if ((key == (*tmp)->key) && (depth == (*tmp)->depth)) {
>
> Comments with /** are intended to be docbook comments.
> This is not a docbook comment for a function.
>



-- 
Regards,
Vladimir