From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 923B6C0650E for ; Mon, 1 Jul 2019 13:51:35 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 2183D214AE for ; Mon, 1 Jul 2019 13:51:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=marvell.com header.i=@marvell.com header.b="TCzYOx0s"; dkim=temperror (0-bit key) header.d=marvell.onmicrosoft.com header.i=@marvell.onmicrosoft.com header.b="UHQYO3lI" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2183D214AE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=marvell.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CC2211B9AD; Mon, 1 Jul 2019 15:51:33 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 6F4F01B9AB for ; Mon, 1 Jul 2019 15:51:32 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x61DlV0M016602; Mon, 1 Jul 2019 06:51:31 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : mime-version; s=pfpt0818; bh=Yl0Vw5PJPjBpFJBZsTIowtf5U9rKzlnZt5TNq6/zgg0=; b=TCzYOx0sZpMTzws58NyOUWe/94Ttx0WTxmSDLCxc57Znjxq8ToKDXQkMpmwCugH79lMo YKhQMZeMgahr3sY/nj/8dgPF3ApdgatY8Hm5/UNJJQveo6u59ZS++7FdCYaHk/oZW/v8 HW1wu1vX2xOVypjgIWivvJUAKs80SoqQrTgSgoihUHxN4CYjUeaLTfEZlIv+uN/VlUaY 105ccUw+zPbf2wy+zH+a/QqzrJnydeFpvsEAI0FEhO0ETatyOb95fnk7IrSMqGzMdy59 l8TYZRii4pHfBG57ZHtqIcZC2pXR766JVvioIbUn7HN1KuimnrBsJ4QUjN9pD+HMq+W+ +Q== Received: from sc-exch02.marvell.com ([199.233.58.182]) by mx0b-0016f401.pphosted.com with ESMTP id 2tfcme9csq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Mon, 01 Jul 2019 06:51:30 -0700 Received: from SC-EXCH03.marvell.com (10.93.176.83) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Mon, 1 Jul 2019 06:51:28 -0700 Received: from NAM04-CO1-obe.outbound.protection.outlook.com (104.47.45.50) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Mon, 1 Jul 2019 06:51:28 -0700 ARC-Seal: i=1; a=rsa-sha256; s=testarcselector01; d=microsoft.com; cv=none; b=oUp3VckxovKNZ8yje1ROFmQ+P83bDiN2UXArQZH/5FzVn9y4Us7j0iaIt5fdlL+iIBUeGCfSP4mnNLtZMuNF2QwGvKL/HshLWsEgOkm+zx77R+7wrWdFqDl7ibVl1wv01EZ6qH7+76sVBXmMW0JfO+TUipRiZUUUMobOlOlrgrM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=testarcselector01; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Yl0Vw5PJPjBpFJBZsTIowtf5U9rKzlnZt5TNq6/zgg0=; b=FWBRbzUxK5NyXnwvuNsgni4pN/n34yfSHjQLF1YzCPQ1qynrugmz7+sDaQ8kroFLWVuocSmLfQEjPkZ9NZyClSSN01Uy2h/xfl1Xorqwu8HTeLoVQa/cQC0j9/VzyZqzeQAbmkYgWNHB4KvJGXoQaabhlEfRO+gG/a+20ZELzp8= ARC-Authentication-Results: i=1; test.office365.com 1;spf=none;dmarc=none;dkim=none;arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector2-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Yl0Vw5PJPjBpFJBZsTIowtf5U9rKzlnZt5TNq6/zgg0=; b=UHQYO3lIAjUaABUl+ApxHaCqSdf6xVA8j8eket3UR3kJHniwrQG6BXRPVuzO3o/9KfhMNxrOiSFfPPc2qL6vwpdjfH8jDwN+ZvNmpdY5Yc7SKHJzDYUNpYFSvHrom6AdQzyu6HY4eyB8vw3C6lFnPj10YyGBHhaJQ1+CfwE/Fh4= Received: from CH2PR18MB3381.namprd18.prod.outlook.com (52.132.246.204) by CH2PR18MB3399.namprd18.prod.outlook.com (52.132.246.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2008.17; Mon, 1 Jul 2019 13:51:22 +0000 Received: from CH2PR18MB3381.namprd18.prod.outlook.com ([fe80::189c:3889:b207:8922]) by CH2PR18MB3381.namprd18.prod.outlook.com ([fe80::189c:3889:b207:8922%5]) with mapi id 15.20.2032.019; Mon, 1 Jul 2019 13:51:22 +0000 From: Vamsi Krishna Attunuru To: Jerin Jacob Kollanukkaran , "Burakov, Anatoly" , "dev@dpdk.org" CC: "ferruh.yigit@intel.com" , "olivier.matz@6wind.com" , "arybchenko@solarflare.com" Thread-Topic: [dpdk-dev] [PATCH v6 0/4] add IOVA = VA support in KNI Thread-Index: AQHVLMuXusCcn4VbWE2ZRwEk1wJ3HKa1zmsC Date: Mon, 1 Jul 2019 13:51:22 +0000 Message-ID: References: <20190422061533.17538-1-kirankumark@marvell.com> <20190625035700.2953-1-vattunuru@marvell.com> <51e1b2c8-4290-c9b5-701f-5be55e763425@intel.com> <4906aad7-47a2-6707-cf69-417043c46c8c@intel.com> <7bfd30cf-aec6-9fd3-00b0-ed8964849869@intel.com>, In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [157.44.99.71] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ab398bb3-e2df-4ac6-58b3-08d6fe2b33a8 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328)(7193020); SRVR:CH2PR18MB3399; x-ms-traffictypediagnostic: CH2PR18MB3399: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 00851CA28B x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(366004)(376002)(396003)(136003)(346002)(39860400002)(13464003)(199004)(189003)(54896002)(74316002)(55016002)(7736002)(9686003)(8676002)(52536014)(81156014)(81166006)(229853002)(8936002)(110136005)(14454004)(2501003)(6506007)(3846002)(19627405001)(71190400001)(71200400001)(6116002)(7696005)(33656002)(54906003)(316002)(66066001)(53546011)(6246003)(186003)(5660300002)(76176011)(26005)(99286004)(476003)(102836004)(6606003)(446003)(25786009)(73956011)(66556008)(64756008)(66946007)(66476007)(11346002)(478600001)(6436002)(4326008)(486006)(86362001)(68736007)(66446008)(91956017)(76116006)(53936002)(256004)(2906002); DIR:OUT; SFP:1101; SCL:1; SRVR:CH2PR18MB3399; H:CH2PR18MB3381.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: OMmmN5pDy8vhhQ2QMggW2sNDARuUQNX4GDZspvhohmZHk5QG4uYRu6fr7qH6+VxepNkT7tSxhanbQMFu4yUNM8Nw/E8XKuakX1RbY8rLEpzBUMTATMcN6Mkj1P9/5vsKaA1ia2/acIoxGEM97SVQ3xqAfVgvo6t8Z9I4kvR3Otanwz6XJ+CN0BjSFRxtLwFOcuVrKVSRhe6GKSdHYHrRMi0j6RP00a2KTugA/ci/qaD8KEloJa/2ok4r5q6uJ8aG9fYFO7SkwQOg9WWiW/uDIiNbF7en1FT3i9Ru6KWv8g+L/+m7kKuxV8FM29Q6BT422U84Zl9xDvHYxoilKdrLFruQrrjHZXKbgpXoXNnBzjbgXtI2c6pcHUK/nuggcurGR88yWPLYuE0+rw5HB5+Q5tScxrXMwD3cCrWbW67M5cE= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: ab398bb3-e2df-4ac6-58b3-08d6fe2b33a8 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Jul 2019 13:51:22.2044 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: vattunuru@marvell.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR18MB3399 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-07-01_09:, , signatures=0 Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v6 0/4] add IOVA = VA support in KNI X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" ping.. ________________________________ From: Jerin Jacob Kollanukkaran Sent: Thursday, June 27, 2019 3:04:58 PM To: Burakov, Anatoly; Vamsi Krishna Attunuru; dev@dpdk.org Cc: ferruh.yigit@intel.com; olivier.matz@6wind.com; arybchenko@solarflare.c= om Subject: RE: [dpdk-dev] [PATCH v6 0/4] add IOVA =3D VA support in KNI > -----Original Message----- > From: Burakov, Anatoly > Sent: Tuesday, June 25, 2019 7:09 PM > To: Jerin Jacob Kollanukkaran ; Vamsi Krishna Attunur= u > ; dev@dpdk.org > Cc: ferruh.yigit@intel.com; olivier.matz@6wind.com; > arybchenko@solarflare.com > Subject: Re: [dpdk-dev] [PATCH v6 0/4] add IOVA =3D VA support in KNI > > On 25-Jun-19 12:30 PM, Burakov, Anatoly wrote: > > On 25-Jun-19 12:15 PM, Jerin Jacob Kollanukkaran wrote: > >>> -----Original Message----- > >>> From: dev On Behalf Of Burakov, Anatoly > >>> Sent: Tuesday, June 25, 2019 3:30 PM > >>> To: Vamsi Krishna Attunuru ; dev@dpdk.org > >>> Cc: ferruh.yigit@intel.com; olivier.matz@6wind.com; > >>> arybchenko@solarflare.com > >>> Subject: Re: [dpdk-dev] [PATCH v6 0/4] add IOVA =3D VA support in KNI > >>> > >>> On 25-Jun-19 4:56 AM, vattunuru@marvell.com wrote: > >>>> From: Vamsi Attunuru > >>>> > >>>> ---- > >>>> V6 Changes: > >>>> * Added new mempool flag to ensure mbuf memory is not scattered > >>>> across page boundaries. > >>>> * Added KNI kernel module required PCI device information. > >>>> * Modified KNI example application to create mempool with new > >>>> mempool flag. > >>>> > >>> Others can chime in, but my 2 cents: this reduces the usefulness of > >>> KNI because it limits the kinds of mempools one can use them with, > >>> and makes it so that the code that works with every other PMD > >>> requires changes to work with KNI. > >> > >> # One option to make this flag as default only for packet mempool(not > >> allow allocate on page boundary). > >> In real world the overhead will be very minimal considering Huge page > >> size is 1G or 512M # Enable this flag explicitly only IOVA =3D VA mode > >> in library. Not need to expose to application # I don=92t think, there > >> needs to be any PMD specific change to make KNI with IOVA =3D VA mode = # > >> No preference on flags to be passed by application vs in library. > >> But IMO this change would be > >> needed in mempool support KNI in IOVA =3D VA mode. > >> > > > > I would be OK to just make it default behavior to not cross page > > boundaries when allocating buffers. This would solve the problem for > > KNI and for any other use case that would rely on PA-contiguous > > buffers in face of IOVA as VA mode. > > > > We could also add a flag to explicitly allow page crossing without > > also making mbufs IOVA-non-contiguous, but i'm not sure if there are > > use cases that would benefit from this. > > On another thought, such a default would break 4K pages in case for packe= ts > bigger than page size (i.e. jumbo frames). Should we care? The hugepage size will not be 4K. Right? Olivier, As a maintainer any thoughts of exposing/not exposing the new mepool flag t= o Skip the page boundaries? All, Either option is fine, Asking for feedback to processed further?