From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D80BECAAD8 for ; Fri, 23 Sep 2022 16:31:15 +0000 (UTC) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 948B6406A2; Fri, 23 Sep 2022 18:31:14 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id B5D8240156 for ; Fri, 23 Sep 2022 18:31:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1663950672; x=1695486672; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=IXdfdIO6LMfEm4829emWqIxsrew7Liw2ouyfs5IHnOA=; b=Ck1NQsH6jxj2uM/fZH21pfmYXA4B7iynCG2t7fZ59M48Kz0AO8myExOb pj3tn3q54s15GIJ/bJNDeJVUb9d5B2Y9ecfFnhTMCyBIskAZjJtRJ/JhF 574nvbpG8mUd5F4osPL6gADAiVGFI6XUHbhmTVg8uusmNl5c5XAV9a/Yc /AK5J85H4h1Jo29k9aFW9ikyw30xG5Rxi7SeJclI+E2BlYQwOGzF9hy0y wgY3usBRhvDsGU8FViAF34iAD6N5I5Y8YKF9RLtaWi92DbA6pl7ht1pc9 j6sFxZkxrNG9JNtNP4inx1wU6Yclf+Ft3mq6yWpQfklySv8B01yaUu/EI A==; X-IronPort-AV: E=McAfee;i="6500,9779,10479"; a="280355015" X-IronPort-AV: E=Sophos;i="5.93,339,1654585200"; d="scan'208";a="280355015" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Sep 2022 09:26:06 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,339,1654585200"; d="scan'208";a="762666636" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmsmga001.fm.intel.com with ESMTP; 23 Sep 2022 09:26:05 -0700 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 23 Sep 2022 09:26:05 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 23 Sep 2022 09:26:05 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Fri, 23 Sep 2022 09:26:05 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.109) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Fri, 23 Sep 2022 09:25:34 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DIrEKXmROVZUD8vMw81huVNf/ZrmxB0vCzuP3NePjAg4DxZkOlwtp6YrDCx7nHW34Hv9VALUd8Q5t+T9Mqy+dP/wW2TSyBHWS5D551R1HC6r9UD89/wXs8J4ncmPuGBTue6VtCDii69XEXLMmcYlZSKpMlVL3f3KsaNNJa4jiBmIRDFXeEFKp+jIGiyVccsB3RO7+6c+pC3dqNWual1DVoMxcPpHs68Hdu+80GZo32493CDJ4m/CipbgrBtQQ6t1L/V7vsmwECmAtOZdldA9ovKPqLK2Q7pEx0V1wHsI0NkQwgeoXYAWvnl2chQvAMPRHI66L85u+DDaL41Q5laBjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+vB+cjNpvbyNbLwBJEJD38cm9tabPEtXPcPPwIE/I2I=; b=S2LHuO9P+AolhSgLRtsBqrEy73SvfD9TiBbQDWc3YwErUt9HqM2Xo+MHRwOjiN5kcY6Hu/6PxsGIPmwQiw1AnxuoHJG/8imNQWN0ngArPcvb5nQLrCfD3QH+nFr0iW7btUbkx5QCOIRsAeIiH+G6yEnSN3gw8e70rKObmDhXrNMp4R//+2tEEhx1NCGtrYKAXdbKFo9t1FQqR/BWVF4wiyEsO7OY6hTlMGq0CX/tlBWcFQgCFngHuLIwvuHRFdMS5Xs159cmNd5CJGWyJ/AKnkiAwM0nV2ad6yiCdbOvkAqq0IhjC7fY+v2Q+lk/ethYYhQsmLRIBici86iANPSBMw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from CY4PR11MB1848.namprd11.prod.outlook.com (2603:10b6:903:123::22) by BN9PR11MB5257.namprd11.prod.outlook.com (2603:10b6:408:132::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.20; Fri, 23 Sep 2022 16:25:32 +0000 Received: from CY4PR11MB1848.namprd11.prod.outlook.com ([fe80::917f:87a9:4204:a8d1]) by CY4PR11MB1848.namprd11.prod.outlook.com ([fe80::917f:87a9:4204:a8d1%6]) with mapi id 15.20.5654.020; Fri, 23 Sep 2022 16:25:31 +0000 From: "Dooley, Brian" To: Gowrishankar Muthukrishnan , "dev@dpdk.org" CC: Anoob Joseph , "Zhang, Roy Fan" , Akhil Goyal , "jerinj@marvell.com" Subject: RE: [v1] examples/fips_validation: fix SHA MCT test from segfault Thread-Topic: [v1] examples/fips_validation: fix SHA MCT test from segfault Thread-Index: AQHYydUK0l0my48iqEmsMxj/yAR80a3tOJxw Date: Fri, 23 Sep 2022 16:25:31 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.500.17 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: CY4PR11MB1848:EE_|BN9PR11MB5257:EE_ x-ms-office365-filtering-correlation-id: 885ffb4c-aaa3-49c4-df25-08da9d803c21 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: H3wGoDdotSH+WXKraXvexBXH1WPRfN84pDIbXZsFsejLYCyhZ7zGCDmul8zRQRBpa0aXu8A4aR5g/bCAv/ygJSwjl75gbmhLgSe56Xi7+u7Il6xPwetUCUvb/+uE5aoZrerdaQnZKcyguFNadJ8xLjuBuHIoUN7pJfEQm0OB/eeBmlnErL4zsNdqUMsDw7a3IR7NY6cOsqaOqoyjscXDGIvQ07zLstSU1W561jaJ01p4ziGNTJN1baV99N04V4nZ33mmu1U/KJee/uCkmRQS+6TQUkcIu5+PwmhH+UCb5vbA32nY2r9ACtfLPkRIYyAVeUXxtNQPBDzpk90oOELWfHBKiNTfJOi6814Zt8szVxKBOuYDpr468+BhuVFe8Kz5qxmoKVmuMEDoOBay39y7BvxpV17QY/NBuNf5QrJgz1ixDzg4jjOJIS3GrviQyehVo/u1ZF5ux0mbD023WKhfhqsIUinVUHowtcup/Rw+u4AD0quYfH42HAU0kLC7QFH1Sr0opW1YqBkadtPj3D+GxgvDchjCwRZ90ArC7OC+L+fuaDr5gOISOXVY+jUpGkgq1f+6F2vYc0cnKeShBZPjlApfxzKmbP0h2MLNXqVHzokwO6nIaWZRPmVhJzy00zAoRGz+Jon2XfpUdJDVv5eUKByl+cEototv4YOg7aqDsoPKNL+XlWo46BUEUJY35SXdzmfJxK59aBNd9DvJqZl8vs4MtmG+HIWDWa9KC0Q4Cf967EhJzjYEl9wVq/pBAMEqks27MrcIdiygMmbk6C1jZg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CY4PR11MB1848.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(366004)(39860400002)(136003)(396003)(376002)(346002)(451199015)(478600001)(53546011)(2906002)(26005)(9686003)(7696005)(6506007)(38100700002)(122000001)(41300700001)(76116006)(64756008)(4326008)(66556008)(66476007)(66446008)(38070700005)(316002)(55016003)(54906003)(8676002)(52536014)(33656002)(5660300002)(66946007)(110136005)(8936002)(71200400001)(86362001)(186003)(83380400001)(82960400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?01TQE623YzPFcczn3euvObPnkj0uNbUHFtprlkHkZiKJnSs7fD9IRpp4gG5P?= =?us-ascii?Q?d2/pNcxXlDzSxJ01I3KRin5lyHvqEJFscsgcC7Zczk26Wie8ASgaw+Mp7kW+?= =?us-ascii?Q?S1XfEc4uVsCGj/tMOk1giRMiKrtfDygWPUwQfDr6HxSlCfXg//7kAUFqqWpD?= =?us-ascii?Q?T7DVWPjhRPLlGkRG0XPzIXXLVosrWtaEGzDqTAL0vqvW0lvEcMQG7k/HlOff?= =?us-ascii?Q?gOcXSfiE0akY4WURMCyIoF71byDcsf/fDNa9AHG2wRItm7g83lueaAeHk+NC?= =?us-ascii?Q?G/nn6cQBxOEy25TdBUu6Yq5edI4oWowHZ4IZJoY2iYEbK26UGzWEVQnpOa2k?= =?us-ascii?Q?Wivg3lVVo7fJZHqS+pithGPO9RBaihDc/54dOAvtnhvF3MpT9IEphm1rKlyM?= =?us-ascii?Q?mAKczZ1g0I8HpIGsjHJzYt6G6lnwfFUQXuLarIIVn5T7YCro6T8vbYXY3ZCq?= =?us-ascii?Q?vvYcjcCBsAH2BlrwHFKlk7pvLSKwF5qQsnK6FK1bO0xKNnBCmwmkpyJ4Yp4F?= =?us-ascii?Q?u+OA9GYGPCpbbtL1XBLrb4pwnm6lWbbTCaZBsIT1RFuf+gKItHjw4mFVGu7W?= =?us-ascii?Q?eDV9M/fw2gTLX+dms920c869qP4XyASSuziywRIV9Df29osYUi1IKQ9HZSqQ?= =?us-ascii?Q?gJAPDwgMxR8kd3g13m6EajSiTXbVRyEjAL56VR3CFqfhLGjc9ye1NTFE0SA1?= =?us-ascii?Q?WKWPE5WHjt8IAwqR/Bu8GZ+I5Z0BGWlSOurd8J2d69in0diMokvQEuo/P+jQ?= =?us-ascii?Q?iD7zUBqg1uVKIaj4u424vBPxTW5qAZUxBRXDT42ZnOwmU0vLNYI+VpvniF7d?= =?us-ascii?Q?i4bWSrQyKeMRtOT6sje+9W2ELXVC5/ItCk6105Q13Wr3EBErapjid3PD7iO1?= =?us-ascii?Q?qIiRLyR388rjUPvtrHB/1CIWt/qhXYovwPJwLmfbflPIrxl7C/NsTrxSTuIe?= =?us-ascii?Q?tkYo+cZlegar2h5EcdmEAnkays0gfEpFPEIEoewioR1AzazLs6k81zNz0UKD?= =?us-ascii?Q?9MmoXomoPrSw3rEH5p7fkRL2/BrOXfM2F2+EInqXypkY/ZfyhF77DXADNg09?= =?us-ascii?Q?h4WZPxsSW1uybMJhUBTFTvMYfp5SryUYbI89FTs549i6Thl+B6oMJIVX+8cu?= =?us-ascii?Q?n0cATjYnd88C33A3uqHE7s2VApsCj2/S4BlkFB9s69jGxj2GL+z0/m6w03ZR?= =?us-ascii?Q?85TqJyob8Gv9dZBDdrRU0U/CoVyqdQguJx6OmI1GoGVsd3XO4TD4efy7o3DX?= =?us-ascii?Q?XbYk+/FskGwJz4p4Firi9SS+5mT6gFzDtvCjzsuQgnKx5F66W1zkiwtQLv90?= =?us-ascii?Q?aGT1Yb1+jvJ5mcVD+0VdfBwtFRdXaRqUHnVm0UjTYFLTIP7g35Gmnyx3254x?= =?us-ascii?Q?PrRFHKhEMQFwpuuf6TzaK92atp2MyMbXH38t+PnaMJ0OhtKbTO+DhMZ/JHfk?= =?us-ascii?Q?qblTnGkSbkTN+Z3nxg0XLyVxkx7zE2UAUsXALUc9GqNvrlmxYkhuIljgJSiV?= =?us-ascii?Q?BjowI2pWAETH8xaQqD7gll2qdg5t7AgJhqZs9m4P0WkP610YlBMwRmtq0Ij0?= =?us-ascii?Q?FW5V6mFCSxwJd25Qyg6VhLUbey3TpgxHSEWoduX2?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1848.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 885ffb4c-aaa3-49c4-df25-08da9d803c21 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Sep 2022 16:25:31.6261 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: h9E0R84LXZ59Py6azxdlTr+LhSnEKrjV4C6rgbJyHwYUINNkMZT0iprTrp+6eS+A8/jZUVGNUmOFcYw55wYn1g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR11MB5257 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Gowrishankar Muthukrishnan > Sent: Friday, September 16, 2022 3:02 PM > To: dev@dpdk.org > Cc: Anoob Joseph ; Zhang, Roy Fan > ; Dooley, Brian ; Akhil > Goyal ; jerinj@marvell.com; Gowrishankar > Muthukrishnan > Subject: [v1] examples/fips_validation: fix SHA MCT test from segfault >=20 > In case of FIPS 140-2 format of test vectors in MCT test, msg is not give= n in > the test vector, hence pt will be NULL which test function has to handle > correctly. >=20 > Fixes: d5c247145c2c ("examples/fips_validation: add parsing for SHA") >=20 > Signed-off-by: Gowrishankar Muthukrishnan > --- > examples/fips_validation/main.c | 14 ++++++++------ > 1 file changed, 8 insertions(+), 6 deletions(-) >=20 > diff --git a/examples/fips_validation/main.c > b/examples/fips_validation/main.c index 8bd5a66889..cab3dd22b9 100644 > --- a/examples/fips_validation/main.c > +++ b/examples/fips_validation/main.c > @@ -1696,13 +1696,14 @@ fips_mct_sha_test(void) > /* val[0] is op result and other value is for parse_writeback callback > */ > struct fips_val val[2] =3D {{NULL, 0},}; > struct fips_val md[SHA_MD_BLOCK], msg; > - char temp[MAX_DIGEST_SIZE*2]; > int ret; > uint32_t i, j; >=20 > msg.len =3D SHA_MD_BLOCK * vec.cipher_auth.digest.len; > msg.val =3D calloc(1, msg.len); > - memcpy(vec.cipher_auth.digest.val, vec.pt.val, > vec.cipher_auth.digest.len); > + if (vec.pt.val) > + memcpy(vec.cipher_auth.digest.val, vec.pt.val, > +vec.cipher_auth.digest.len); > + > for (i =3D 0; i < SHA_MD_BLOCK; i++) > md[i].val =3D rte_malloc(NULL, (MAX_DIGEST_SIZE*2), 0); >=20 > @@ -1769,14 +1770,15 @@ fips_mct_sha_test(void) > memcpy(vec.cipher_auth.digest.val, md[2].val, md[2].len); > vec.cipher_auth.digest.len =3D md[2].len; >=20 > - if (info.file_type !=3D FIPS_TYPE_JSON) { > + if (info.file_type !=3D FIPS_TYPE_JSON) > fprintf(info.fp_wr, "COUNT =3D %u\n", j); > - writeback_hex_str("", temp, > &vec.cipher_auth.digest); > - fprintf(info.fp_wr, "MD =3D %s\n\n", temp); > - } > + > val[1].val =3D msg.val; > val[1].len =3D msg.len; > info.parse_writeback(val); > + > + if (info.file_type !=3D FIPS_TYPE_JSON) > + fprintf(info.fp_wr, "\n"); > } >=20 > for (i =3D 0; i < (SHA_MD_BLOCK); i++) > -- > 2.25.1 LGTM Tested-by: Brian Dooley