From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F1AFC31E40 for ; Fri, 9 Aug 2019 09:07:53 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 8A09B2171F for ; Fri, 9 Aug 2019 09:07:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=marvell.com header.i=@marvell.com header.b="Jof6BiCC"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=marvell.onmicrosoft.com header.i=@marvell.onmicrosoft.com header.b="egkE6WLd" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8A09B2171F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=marvell.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6266B137C; Fri, 9 Aug 2019 11:07:51 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id B7E1ADE3 for ; Fri, 9 Aug 2019 11:07:49 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id x7994mqW024922; Fri, 9 Aug 2019 02:07:48 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=BGyCJIC5Rl6vSDL/h7387g6wU5Cl3GQ7qhOX9I0AKNI=; b=Jof6BiCCHGN7+JOOgNB3dnwQU2tQsVNlY+h8XFehzAdtqp9m/VR2WdPQx1fwA0E3tETA ljA6RPPjqhKVsUxk2HhyoGV1ixmTfrDuoRel+rlaYWYov8mU2NFxVyVSzl8tSSrCbe2s RwA0Kp/3rDg3Aqd6onyFcxTr4gYpZJ1z2YzFfP3qbwelYjeFHjctxJnsYx5Hwn2oV0Rf FCfGDzzyO9qFkvVSK0Fz1Kk5n8gHoaU4PI+aCA3zBn5XOR2+fx29CHLJkvr3Iebyubzn 9a5Di0y8SYIyEjYQ//TihLUpA/TSY0t3JjFapzoyb1oThlFWkKZud6uScQ9UxroHde+6 fg== Received: from sc-exch01.marvell.com ([199.233.58.181]) by mx0a-0016f401.pphosted.com with ESMTP id 2u8cqjdfrd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Fri, 09 Aug 2019 02:07:48 -0700 Received: from SC-EXCH01.marvell.com (10.93.176.81) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Fri, 9 Aug 2019 02:07:47 -0700 Received: from NAM02-CY1-obe.outbound.protection.outlook.com (104.47.37.56) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Fri, 9 Aug 2019 02:07:47 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WmTIu8wl25BfW9qSj4qFDkHlK84/YAlnRYV0bF4aqLvXeyt/sOhy6MByYkXfO114Ws8FrEpje/UIl7nmNtoSpKXinlZNtngrH8W61J0o/Njtt8Q+QFa7WUpCsfEvj/fs19+d5CadLrklClwYLZLMMOiek6hz1NXkLRh4cbfJ7Bs+Q/hXEH6XtlSHNjxgT9FC14mV10/mGfERXALQcm4XTx4SemMSZr12jDIet6pPwaDkHMdSUDWm4DEcH25PQe7MlXKeb2a+9upCte5Sf8QyhLLq/dKW4ef8V4YbWeRgFWhkn0UiUD1o3fwl4ToRM/3GWoBhI5Kx+nAfCLPnirYTsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BGyCJIC5Rl6vSDL/h7387g6wU5Cl3GQ7qhOX9I0AKNI=; b=abYdFhnO00CV21dqcLOeRBUpupVtt1i8qawEULkHRaZfDc7ZiIlK3HNYZ7fRFYZgUUBbTCVjtPUGlYfYLSc1o/poOlnDlX2JZ56+vnoXGPzaEyUmJG+D9mixW3BItZ/z+8o57KDNohvo9aAGlAaiskwijoj6ZedugC6r3suekQrM4gu0eN6+3LAr6iYtYkYM02dff2h7Z5DSj2h7vTvdUXxGd2ZksgZMb3/W1AyoR9qfU20mlWh+sMkIug+FwGqtHCWsD+l7TNM3bvhE6sF08ZuQfDv1fyyD7oaZCcAPq3L+x7cQA1MOUdezr9pySyvMYJ4AJO875GTtbyDuF/xoWg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector2-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BGyCJIC5Rl6vSDL/h7387g6wU5Cl3GQ7qhOX9I0AKNI=; b=egkE6WLddPZPyXoGFkpZBrLmq+zijoFzsNbA2RgnKP2ZQ6K6sQMrTCMd5hV8opM1g24MR2DxLaGlQwqCAmaiN8SnyhR/t2TN6m1RI0JulJ0R2lzfluIyCfq2d2wqlvj3Uad5me9Yl86krpmMViCV+yz6R4woKwVYga2S8+CJJzg= Received: from CY4PR1801MB1863.namprd18.prod.outlook.com (10.171.255.14) by CY4PR1801MB1831.namprd18.prod.outlook.com (10.165.90.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2157.18; Fri, 9 Aug 2019 09:07:45 +0000 Received: from CY4PR1801MB1863.namprd18.prod.outlook.com ([fe80::ad3e:ff83:79ce:a2bc]) by CY4PR1801MB1863.namprd18.prod.outlook.com ([fe80::ad3e:ff83:79ce:a2bc%4]) with mapi id 15.20.2157.020; Fri, 9 Aug 2019 09:07:45 +0000 From: Pavan Nikhilesh Bhagavatula To: "Ananyev, Konstantin" , "Jerin Jacob Kollanukkaran" , "stephen@networkplumber.org" , "arybchenko@solarflare.com" , "hemant.agrawal@nxp.com" , "thomas@monjalon.net" , "Yigit, Ferruh" , "Richardson, Bruce" , Neil Horman , "Mcnamara, John" , "Kovacevic, Marko" CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [patch v4] doc: announce API change in ethdev offload flags Thread-Index: AQHVTo8JxC9Ftu/Pq0Wuhm5ZNhAdzqbyhiEQ Date: Fri, 9 Aug 2019 09:07:45 +0000 Message-ID: References: <20190808085859.796-1-pbhagavatula@marvell.com> <20190809081740.1607-1-pbhagavatula@marvell.com> <2601191342CEEE43887BDE71AB9772580168A64124@irsmsx105.ger.corp.intel.com> In-Reply-To: <2601191342CEEE43887BDE71AB9772580168A64124@irsmsx105.ger.corp.intel.com> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [14.140.231.66] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: abf87886-c1d8-44c3-879d-08d71ca90b23 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328)(7193020); SRVR:CY4PR1801MB1831; x-ms-traffictypediagnostic: CY4PR1801MB1831: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 01244308DF x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(136003)(376002)(366004)(396003)(39850400004)(346002)(189003)(199004)(13464003)(2501003)(71190400001)(66066001)(76176011)(6246003)(110136005)(26005)(186003)(7696005)(6436002)(316002)(4326008)(66946007)(14454004)(99286004)(66446008)(52536014)(11346002)(486006)(446003)(476003)(102836004)(6506007)(55236004)(256004)(5660300002)(71200400001)(14444005)(8936002)(229853002)(81156014)(55016002)(3846002)(81166006)(76116006)(33656002)(86362001)(25786009)(2201001)(7416002)(9686003)(64756008)(66556008)(66476007)(2906002)(74316002)(478600001)(6116002)(53936002)(305945005)(7736002)(921003)(1121003); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR1801MB1831; H:CY4PR1801MB1863.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: +BMunO2lQ3LkZCc+CGZ2gxBraNnn+w2K5yC7+Ta/zvz2NTZVlbisvXH0Kzg1bX96IsxiufAgs+9e9qnRmBRXEmeBwHbVk0OIoxjnZ4GGGYgTIOlgx/B91OHOcsdTwDT7C/PSQGE1bOjG4RY/ZXqdblGu8WCi6nkbz1y+id84A4QqMT5erz8Gow3PPdQUBw4ID2orkPbXHgHz6itaBNfPN+S88KWvahhaag+ALiNu1TkuS1hBDFONenhF6yw12Eim9jM9vHtHy79sZqpSgD0n5ZftH1DCU1fQHFolZuKI3qRjJaonRzEW7NDBRcRMgnSTNMmJqXvMNLAOm/GFK/Axwl6MCt1KpxnS30bzVF+cP2udWwgWyPMgvNR7V+A3MLiNx9b1khzxUKLD4wqHCJ/q/IToZcGvJQzqfg9UcQyL678= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: abf87886-c1d8-44c3-879d-08d71ca90b23 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Aug 2019 09:07:45.4795 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 36mKiNWeF5f4ns6GMq2snv5XvmuL0u0foJ59IqEjGwnwI/8f5eqiWQFHi5xBgeCmfX9D5B+sAnoSbsMvama3oqNO8gf7BLHnnieO6xNuxp4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR1801MB1831 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:5.22.84,1.0.8 definitions=2019-08-09_02:2019-08-07,2019-08-09 signatures=0 Subject: Re: [dpdk-dev] [patch v4] doc: announce API change in ethdev offload flags X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, >-----Original Message----- >From: Ananyev, Konstantin >Sent: Friday, August 9, 2019 2:17 PM >To: Pavan Nikhilesh Bhagavatula ; Jerin >Jacob Kollanukkaran ; >stephen@networkplumber.org; arybchenko@solarflare.com; >hemant.agrawal@nxp.com; thomas@monjalon.net; Yigit, Ferruh >; Richardson, Bruce >; Neil Horman >; Mcnamara, John >; Kovacevic, Marko > >Cc: dev@dpdk.org >Subject: RE: [dpdk-dev] [patch v4] doc: announce API change in >ethdev offload flags >Hi > >> >> From: Pavan Nikhilesh >> >> Add new offload flags ``DEV_RX_OFFLOAD_RSS`` and >``DEV_RX_OFFLOAD_FLOW_MARK``. >> Add new function ``rte_eth_dev_set_supported_ptypes`` to allow >application to >> set specific ptypes to be updated in ``rte_mbuf::packet_type`` >> >> Signed-off-by: Pavan Nikhilesh >> Acked-by: Andrew Rybchenko >> Acked-by: Jerin Jacob >> Acked-by: Hemant Agrawal >> --- >> doc/guides/rel_notes/deprecation.rst | 23 >+++++++++++++++++++++++ >> 1 file changed, 23 insertions(+) >> >> diff --git a/doc/guides/rel_notes/deprecation.rst >b/doc/guides/rel_notes/deprecation.rst >> index 37b8592b6..e4e2a85d7 100644 >> --- a/doc/guides/rel_notes/deprecation.rst >> +++ b/doc/guides/rel_notes/deprecation.rst >> @@ -78,3 +78,26 @@ Deprecation Notices >> to set new power environment if power environment was already >initialized. >> In this case the function will return -1 unless the environment is >unset first >> (using ``rte_power_unset_env``). Other function usage scenarios >will not change. >> + >> +* ethdev: New offload flags ``DEV_RX_OFFLOAD_RSS_HASH`` and >``DEV_RX_OFFLOAD_FLOW_MARK`` >> + will be added in 19.11. >> + This will allow application to enable or disable PMDs from updating >> + ``rte_mbuf::hash::rss`` and ``rte_mbuf::hash::fdir`` respectively. >> + This scheme will allow PMDs to avoid writes to ``rte_mbuf`` fields >on Rx and >> + thereby improve Rx performance if application wishes do so. >> + In 19.11 PMDs will still update the fields even when the offloads are >not >> + enabled. >> + >> +* ethdev: New function ``rte_eth_dev_set_supported_ptypes`` will >be added in >> + 19.11. > >As I said in my previous mail, I do support the idea, though few nits >below. > >> + This will allow application to request PMD to set specific ptypes >defined >> + through ``rte_eth_dev_set_supported_ptypes`` in >``rte_mbuf::packet_type``. >> + If application doesn't want any ptype information it can call >> + ``rte_eth_dev_set_supported_ptypes(ethdev_id, >RTE_PTYPE_UNKNOWN)`` > >Probably worth to mention that in that case packet_type will be set to 0 >(PMD still need to set the value). Ack, will update in v5. > >> + If application doesn't call ``rte_eth_dev_set_supported_ptypes`` >PMD can >> + return ``rte_mbuf::packet_type`` with >``rte_eth_dev_get_supported_ptypes``. >> + If application is interested only in L2/L3 layer, it can inform the P= MD >to update >> + ``rte_mbuf::packet_type`` with L2/L3 ptype by calling >> + ``rte_eth_dev_set_supported_ptypes(ethdev_id, >RTE_PTYPE_L2_MASK | RTE_PTYPE_L3_MASK)``. >> + This scheme will allow PMDs to avoid writes to ``rte_mbuf`` fields >on Rx and > >As I understand, PMD will still need to write ptype value. >Though it will help PMD to avoid figuring out ptype values, when user >don't need that information. I will reword to ``will allow PMDs to avoid lookup to internal ptype table`= `. > >> + thereby improve Rx performance if application wishes do so. >> -- >> 2.17.1 Thanks, Pavan.