DPDK-dev Archive on lore.kernel.org
 help / color / Atom feed
* [dpdk-dev] [PATCH 0/2] test/meson: fix hash readwrite timeout failure
@ 2019-09-06  5:49 agupta3
  2019-09-06  5:49 ` [dpdk-dev] [PATCH 1/2] test/meson: hash test split into shorter subtests agupta3
                   ` (2 more replies)
  0 siblings, 3 replies; 14+ messages in thread
From: agupta3 @ 2019-09-06  5:49 UTC (permalink / raw)
  To: yipeng1.wang, sameh.gobriel, bruce.richardson, pablo.de.lara.guarch
  Cc: dev, Amit Gupta

From: Amit Gupta <agupta3@marvell.com>

V1 changes:
* hash_readwrite and hash_readwrite lockfree meson test was
taking longer time to complete. The test always get TIMEOUT.
* hash readwrtie test is split into functional and perf tests 
and moved to dpdk fast and perf testsuite accordingly.
* hash readwrite lockfree is moved to dpdk perf testsuite.

Amit Gupta (2):
  test/meson: hash test split into shorter subtests
  test/meson: hash lf test moved to dpdk perf testsuite

 app/test/meson.build           |   5 +-
 app/test/test_hash_readwrite.c | 146 +++++++++++++++++++++++++++++++++++++++++
 2 files changed, 149 insertions(+), 2 deletions(-)

-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 14+ messages in thread

* [dpdk-dev] [PATCH 1/2] test/meson: hash test split into shorter subtests
  2019-09-06  5:49 [dpdk-dev] [PATCH 0/2] test/meson: fix hash readwrite timeout failure agupta3
@ 2019-09-06  5:49 ` agupta3
  2019-09-11 17:05   ` Wang, Yipeng1
  2019-09-06  5:49 ` [dpdk-dev] [PATCH 2/2] test/meson: hash lf test moved to dpdk perf testsuite agupta3
  2019-09-11  5:55 ` [dpdk-dev] [PATCH 0/2] test/meson: fix hash readwrite timeout failure Amit Gupta
  2 siblings, 1 reply; 14+ messages in thread
From: agupta3 @ 2019-09-06  5:49 UTC (permalink / raw)
  To: yipeng1.wang, sameh.gobriel, bruce.richardson, pablo.de.lara.guarch
  Cc: dev, Amit Gupta

From: Amit Gupta <agupta3@marvell.com>

hash_readwrite meson test was taking longer time to complete.
The test always get TIMEOUT, hence test is split into
functional and perf test. perf test is being moved under
dpdk perf testsuites in  meson build.

Signed-off-by: Amit Gupta <agupta3@marvell.com>
---
 app/test/meson.build           |   3 +-
 app/test/test_hash_readwrite.c | 146 +++++++++++++++++++++++++++++++++++++++++
 2 files changed, 148 insertions(+), 1 deletion(-)

diff --git a/app/test/meson.build b/app/test/meson.build
index ec40943..94fd9f8 100644
--- a/app/test/meson.build
+++ b/app/test/meson.build
@@ -219,7 +219,7 @@ fast_test_names = [
         'distributor_autotest',
         'eventdev_common_autotest',
         'fbarray_autotest',
-        'hash_readwrite_autotest',
+        'hash_readwrite_func_autotest',
         'hash_readwrite_lf_autotest',
         'ipsec_autotest',
         'kni_autotest',
@@ -262,6 +262,7 @@ perf_test_names = [
         'stack_perf_autotest',
         'stack_lf_perf_autotest',
         'rand_perf_autotest',
+        'hash_readwrite_perf_autotest',
 ]
 
 driver_test_names = [
diff --git a/app/test/test_hash_readwrite.c b/app/test/test_hash_readwrite.c
index 4376b09..c25e904 100644
--- a/app/test/test_hash_readwrite.c
+++ b/app/test/test_hash_readwrite.c
@@ -606,6 +606,150 @@ struct {
 }
 
 static int
+test_hash_rw_perf_main(void)
+{
+	/*
+	 * Variables used to choose different tests.
+	 * use_htm indicates if hardware transactional memory should be used.
+	 * reader_faster indicates if the reader threads should finish earlier
+	 * than writer threads. This is to timing either reader threads or
+	 * writer threads for performance numbers.
+	 */
+	int use_htm, reader_faster;
+	unsigned int i = 0, core_id = 0;
+
+	if (rte_lcore_count() < 3) {
+		printf("Not enough cores for hash_readwrite_autotest, expecting at least 3\n");
+		return TEST_SKIPPED;
+	}
+
+	RTE_LCORE_FOREACH_SLAVE(core_id) {
+		slave_core_ids[i] = core_id;
+		i++;
+	}
+
+	setlocale(LC_NUMERIC, "");
+
+	if (rte_tm_supported()) {
+		printf("Hardware transactional memory (lock elision) "
+			"is supported\n");
+
+		printf("Test read-write with Hardware transactional memory\n");
+
+		use_htm = 1;
+
+		reader_faster = 1;
+		if (test_hash_readwrite_perf(&htm_results, use_htm,
+							reader_faster) < 0)
+			return -1;
+
+		reader_faster = 0;
+		if (test_hash_readwrite_perf(&htm_results, use_htm,
+							reader_faster) < 0)
+			return -1;
+	} else {
+		printf("Hardware transactional memory (lock elision) "
+			"is NOT supported\n");
+	}
+
+	printf("Test read-write without Hardware transactional memory\n");
+	use_htm = 0;
+
+	reader_faster = 1;
+	if (test_hash_readwrite_perf(&non_htm_results, use_htm,
+							reader_faster) < 0)
+		return -1;
+	reader_faster = 0;
+	if (test_hash_readwrite_perf(&non_htm_results, use_htm,
+							reader_faster) < 0)
+		return -1;
+
+	printf("================\n");
+	printf("Results summary:\n");
+	printf("================\n");
+
+	printf("single read: %u\n", htm_results.single_read);
+	printf("single write: %u\n", htm_results.single_write);
+	for (i = 0; i < NUM_TEST; i++) {
+		printf("+++ core_cnt: %u +++\n", core_cnt[i]);
+		printf("HTM:\n");
+		printf("  read only: %u\n", htm_results.read_only[i]);
+		printf("  write only: %u\n", htm_results.write_only[i]);
+		printf("  read-write read: %u\n", htm_results.read_write_r[i]);
+		printf("  read-write write: %u\n", htm_results.read_write_w[i]);
+
+		printf("non HTM:\n");
+		printf("  read only: %u\n", non_htm_results.read_only[i]);
+		printf("  write only: %u\n", non_htm_results.write_only[i]);
+		printf("  read-write read: %u\n",
+			non_htm_results.read_write_r[i]);
+		printf("  read-write write: %u\n",
+			non_htm_results.read_write_w[i]);
+	}
+
+	return 0;
+}
+
+static int
+test_hash_rw_func_main(void)
+{
+	/*
+	 * Variables used to choose different tests.
+	 * use_htm indicates if hardware transactional memory should be used.
+	 * reader_faster indicates if the reader threads should finish earlier
+	 * than writer threads. This is to timing either reader threads or
+	 * writer threads for performance numbers.
+	 */
+	int use_htm, use_ext;
+	unsigned int i = 0, core_id = 0;
+
+	if (rte_lcore_count() < 3) {
+		printf("Not enough cores for hash_readwrite_autotest, expecting at least 3\n");
+		return TEST_SKIPPED;
+	}
+
+	RTE_LCORE_FOREACH_SLAVE(core_id) {
+		slave_core_ids[i] = core_id;
+		i++;
+	}
+
+	setlocale(LC_NUMERIC, "");
+
+	if (rte_tm_supported()) {
+		printf("Hardware transactional memory (lock elision) "
+			"is supported\n");
+
+		printf("Test read-write with Hardware transactional memory\n");
+
+		use_htm = 1;
+		use_ext = 0;
+
+		if (test_hash_readwrite_functional(use_ext, use_htm) < 0)
+			return -1;
+
+		use_ext = 1;
+		if (test_hash_readwrite_functional(use_ext, use_htm) < 0)
+			return -1;
+
+	} else {
+		printf("Hardware transactional memory (lock elision) "
+			"is NOT supported\n");
+	}
+
+	printf("Test read-write without Hardware transactional memory\n");
+	use_htm = 0;
+	use_ext = 0;
+	if (test_hash_readwrite_functional(use_ext, use_htm) < 0)
+		return -1;
+
+	use_ext = 1;
+	if (test_hash_readwrite_functional(use_ext, use_htm) < 0)
+		return -1;
+
+	return 0;
+}
+
+static int
 test_hash_readwrite_main(void)
 {
 	/*
@@ -706,3 +850,5 @@ struct {
 }
 
 REGISTER_TEST_COMMAND(hash_readwrite_autotest, test_hash_readwrite_main);
+REGISTER_TEST_COMMAND(hash_readwrite_func_autotest, test_hash_rw_func_main);
+REGISTER_TEST_COMMAND(hash_readwrite_perf_autotest, test_hash_rw_perf_main);
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 14+ messages in thread

* [dpdk-dev] [PATCH 2/2] test/meson: hash lf test moved to dpdk perf testsuite
  2019-09-06  5:49 [dpdk-dev] [PATCH 0/2] test/meson: fix hash readwrite timeout failure agupta3
  2019-09-06  5:49 ` [dpdk-dev] [PATCH 1/2] test/meson: hash test split into shorter subtests agupta3
@ 2019-09-06  5:49 ` agupta3
  2019-09-11 17:13   ` Wang, Yipeng1
                     ` (2 more replies)
  2019-09-11  5:55 ` [dpdk-dev] [PATCH 0/2] test/meson: fix hash readwrite timeout failure Amit Gupta
  2 siblings, 3 replies; 14+ messages in thread
From: agupta3 @ 2019-09-06  5:49 UTC (permalink / raw)
  To: yipeng1.wang, sameh.gobriel, bruce.richardson, pablo.de.lara.guarch
  Cc: dev, Amit Gupta

From: Amit Gupta <agupta3@marvell.com>

hash_readwrite_lf test always getting TIMEOUT as required
time to finish this test was much longer compare to time
required for fast tests(10s). Hence, the test is being
moved to perf test category for its execution to complete.

Signed-off-by: Amit Gupta <agupta3@marvell.com>
---
 app/test/meson.build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/app/test/meson.build b/app/test/meson.build
index 94fd9f8..34141c5 100644
--- a/app/test/meson.build
+++ b/app/test/meson.build
@@ -220,7 +220,6 @@ fast_test_names = [
         'eventdev_common_autotest',
         'fbarray_autotest',
         'hash_readwrite_func_autotest',
-        'hash_readwrite_lf_autotest',
         'ipsec_autotest',
         'kni_autotest',
         'kvargs_autotest',
@@ -263,6 +262,7 @@ perf_test_names = [
         'stack_lf_perf_autotest',
         'rand_perf_autotest',
         'hash_readwrite_perf_autotest',
+        'hash_readwrite_lf_autotest',
 ]
 
 driver_test_names = [
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [dpdk-dev] [PATCH 0/2] test/meson: fix hash readwrite timeout failure
  2019-09-06  5:49 [dpdk-dev] [PATCH 0/2] test/meson: fix hash readwrite timeout failure agupta3
  2019-09-06  5:49 ` [dpdk-dev] [PATCH 1/2] test/meson: hash test split into shorter subtests agupta3
  2019-09-06  5:49 ` [dpdk-dev] [PATCH 2/2] test/meson: hash lf test moved to dpdk perf testsuite agupta3
@ 2019-09-11  5:55 ` Amit Gupta
  2 siblings, 0 replies; 14+ messages in thread
From: Amit Gupta @ 2019-09-11  5:55 UTC (permalink / raw)
  To: yipeng1.wang, sameh.gobriel, bruce.richardson, pablo.de.lara.guarch; +Cc: dev

Ping..

-----Original Message-----
From: agupta3@marvell.com <agupta3@marvell.com> 
Sent: Friday, September 6, 2019 11:20 AM
To: yipeng1.wang@intel.com; sameh.gobriel@intel.com; bruce.richardson@intel.com; pablo.de.lara.guarch@intel.com
Cc: dev@dpdk.org; Amit Gupta <agupta3@marvell.com>
Subject: [PATCH 0/2] test/meson: fix hash readwrite timeout failure

From: Amit Gupta <agupta3@marvell.com>

V1 changes:
* hash_readwrite and hash_readwrite lockfree meson test was taking longer time to complete. The test always get TIMEOUT.
* hash readwrtie test is split into functional and perf tests and moved to dpdk fast and perf testsuite accordingly.
* hash readwrite lockfree is moved to dpdk perf testsuite.

Amit Gupta (2):
  test/meson: hash test split into shorter subtests
  test/meson: hash lf test moved to dpdk perf testsuite

 app/test/meson.build           |   5 +-
 app/test/test_hash_readwrite.c | 146 +++++++++++++++++++++++++++++++++++++++++
 2 files changed, 149 insertions(+), 2 deletions(-)

--
1.8.3.1


^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [dpdk-dev] [PATCH 1/2] test/meson: hash test split into shorter subtests
  2019-09-06  5:49 ` [dpdk-dev] [PATCH 1/2] test/meson: hash test split into shorter subtests agupta3
@ 2019-09-11 17:05   ` Wang, Yipeng1
  0 siblings, 0 replies; 14+ messages in thread
From: Wang, Yipeng1 @ 2019-09-11 17:05 UTC (permalink / raw)
  To: agupta3, Gobriel, Sameh, Richardson, Bruce, De Lara Guarch, Pablo; +Cc: dev

>-----Original Message-----
>From: agupta3@marvell.com [mailto:agupta3@marvell.com]
>Sent: Thursday, September 5, 2019 10:50 PM
>To: Wang, Yipeng1 <yipeng1.wang@intel.com>; Gobriel, Sameh <sameh.gobriel@intel.com>; Richardson, Bruce
><bruce.richardson@intel.com>; De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
>Cc: dev@dpdk.org; Amit Gupta <agupta3@marvell.com>
>Subject: [PATCH 1/2] test/meson: hash test split into shorter subtests
>
>From: Amit Gupta <agupta3@marvell.com>
>
>hash_readwrite meson test was taking longer time to complete.
>The test always get TIMEOUT, hence test is split into
>functional and perf test. perf test is being moved under
>dpdk perf testsuites in  meson build.
>
>Signed-off-by: Amit Gupta <agupta3@marvell.com>
[Wang, Yipeng] 
Acked-by: Yipeng Wang <yipeng1.wang@intel.com>


Thanks for the patch!

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [dpdk-dev] [PATCH 2/2] test/meson: hash lf test moved to dpdk perf testsuite
  2019-09-06  5:49 ` [dpdk-dev] [PATCH 2/2] test/meson: hash lf test moved to dpdk perf testsuite agupta3
@ 2019-09-11 17:13   ` Wang, Yipeng1
  2019-09-12 15:00     ` Honnappa Nagarahalli
  2019-09-13  8:12   ` [dpdk-dev] [PATCH v2 1/1] " agupta3
  2019-09-13  8:15   ` agupta3
  2 siblings, 1 reply; 14+ messages in thread
From: Wang, Yipeng1 @ 2019-09-11 17:13 UTC (permalink / raw)
  To: agupta3, Gobriel, Sameh, Dharmik Thakkar, ruifeng.wang,
	honnappa.nagarahalli
  Cc: dev

>-----Original Message-----
>From: agupta3@marvell.com [mailto:agupta3@marvell.com]
>Sent: Thursday, September 5, 2019 10:50 PM
>To: Wang, Yipeng1 <yipeng1.wang@intel.com>; Gobriel, Sameh <sameh.gobriel@intel.com>; Richardson, Bruce
><bruce.richardson@intel.com>; De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
>Cc: dev@dpdk.org; Amit Gupta <agupta3@marvell.com>
>Subject: [PATCH 2/2] test/meson: hash lf test moved to dpdk perf testsuite
>
>From: Amit Gupta <agupta3@marvell.com>
>
>hash_readwrite_lf test always getting TIMEOUT as required
>time to finish this test was much longer compare to time
>required for fast tests(10s). Hence, the test is being
>moved to perf test category for its execution to complete.
>
>Signed-off-by: Amit Gupta <agupta3@marvell.com>
>---
> app/test/meson.build | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/app/test/meson.build b/app/test/meson.build
>index 94fd9f8..34141c5 100644
>--- a/app/test/meson.build
>+++ b/app/test/meson.build
>@@ -220,7 +220,6 @@ fast_test_names = [
>         'eventdev_common_autotest',
>         'fbarray_autotest',
>         'hash_readwrite_func_autotest',
>-        'hash_readwrite_lf_autotest',
>         'ipsec_autotest',
>         'kni_autotest',
>         'kvargs_autotest',
>@@ -263,6 +262,7 @@ perf_test_names = [
>         'stack_lf_perf_autotest',
>         'rand_perf_autotest',
>         'hash_readwrite_perf_autotest',
>+        'hash_readwrite_lf_autotest',
> ]
>
> driver_test_names = [
>--
>1.8.3.1
 [Wang, Yipeng] 
I believe the lf_autotest includes functional test as well which is critical for testing the lock free implementation on non-TSO machine.
Do you think it is possible to also separate this test?
I also include the ARM folks for opinions.

Thanks!
Yipeng


^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [dpdk-dev] [PATCH 2/2] test/meson: hash lf test moved to dpdk perf testsuite
  2019-09-11 17:13   ` Wang, Yipeng1
@ 2019-09-12 15:00     ` Honnappa Nagarahalli
  2019-09-13  8:24       ` Amit Gupta
  0 siblings, 1 reply; 14+ messages in thread
From: Honnappa Nagarahalli @ 2019-09-12 15:00 UTC (permalink / raw)
  To: Wang, Yipeng1, agupta3, Gobriel, Sameh, Dharmik Thakkar,
	Ruifeng Wang (Arm Technology China)
  Cc: dev, nd, Honnappa Nagarahalli, nd

<snip>

> >Subject: [PATCH 2/2] test/meson: hash lf test moved to dpdk perf
> >testsuite
> >
> >From: Amit Gupta <agupta3@marvell.com>
> >
> >hash_readwrite_lf test always getting TIMEOUT as required time to
> >finish this test was much longer compare to time required for fast
> >tests(10s). Hence, the test is being moved to perf test category for
> >its execution to complete.
> >
> >Signed-off-by: Amit Gupta <agupta3@marvell.com>
> >---
> > app/test/meson.build | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> >diff --git a/app/test/meson.build b/app/test/meson.build index
> >94fd9f8..34141c5 100644
> >--- a/app/test/meson.build
> >+++ b/app/test/meson.build
> >@@ -220,7 +220,6 @@ fast_test_names = [
> >         'eventdev_common_autotest',
> >         'fbarray_autotest',
> >         'hash_readwrite_func_autotest',
> >-        'hash_readwrite_lf_autotest',
> >         'ipsec_autotest',
> >         'kni_autotest',
> >         'kvargs_autotest',
> >@@ -263,6 +262,7 @@ perf_test_names = [
> >         'stack_lf_perf_autotest',
> >         'rand_perf_autotest',
> >         'hash_readwrite_perf_autotest',
> >+        'hash_readwrite_lf_autotest',
> > ]
> >
> > driver_test_names = [
> >--
> >1.8.3.1
>  [Wang, Yipeng]
> I believe the lf_autotest includes functional test as well which is critical for
> testing the lock free implementation on non-TSO machine.
> Do you think it is possible to also separate this test?
> I also include the ARM folks for opinions.
Thanks Yipeng. We combined the functional testing with performance testing. So, it is all performance tests. From that perspective, I suggest changing 'hash_readwrite_lf_autotest' to 'hash_readwrite_lf_perf_autotest'.

> 
> Thanks!
> Yipeng


^ permalink raw reply	[flat|nested] 14+ messages in thread

* [dpdk-dev] [PATCH v2 1/1] test/meson: hash lf test moved to dpdk perf testsuite
  2019-09-06  5:49 ` [dpdk-dev] [PATCH 2/2] test/meson: hash lf test moved to dpdk perf testsuite agupta3
  2019-09-11 17:13   ` Wang, Yipeng1
@ 2019-09-13  8:12   ` " agupta3
  2019-09-13 14:40     ` Aaron Conole
  2019-09-13  8:15   ` agupta3
  2 siblings, 1 reply; 14+ messages in thread
From: agupta3 @ 2019-09-13  8:12 UTC (permalink / raw)
  To: Yipeng Wang, Sameh Gobriel, Bruce Richardson, Pablo de Lara
  Cc: dev, Amit Gupta

From: Amit Gupta <agupta3@marvell.com>

hash_readwrite_lf test always getting TIMEOUT as required
time to finish this test was much longer compare to time
required for fast tests(10s). Hence, the test is being renamed
moved to perf test category for its execution to complete.

Signed-off-by: Amit Gupta <agupta3@marvell.com>
---
 app/test/meson.build              | 2 +-
 app/test/test_hash_readwrite_lf.c | 3 ++-
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/app/test/meson.build b/app/test/meson.build
index 94fd9f8..57d5316 100644
--- a/app/test/meson.build
+++ b/app/test/meson.build
@@ -220,7 +220,6 @@ fast_test_names = [
         'eventdev_common_autotest',
         'fbarray_autotest',
         'hash_readwrite_func_autotest',
-        'hash_readwrite_lf_autotest',
         'ipsec_autotest',
         'kni_autotest',
         'kvargs_autotest',
@@ -263,6 +262,7 @@ perf_test_names = [
         'stack_lf_perf_autotest',
         'rand_perf_autotest',
         'hash_readwrite_perf_autotest',
+        'hash_readwrite_lf_perf_autotest',
 ]
 
 driver_test_names = [
diff --git a/app/test/test_hash_readwrite_lf.c b/app/test/test_hash_readwrite_lf.c
index 1f2fba4..33d63fa 100644
--- a/app/test/test_hash_readwrite_lf.c
+++ b/app/test/test_hash_readwrite_lf.c
@@ -1431,4 +1431,5 @@ struct {
 	return 0;
 }
 
-REGISTER_TEST_COMMAND(hash_readwrite_lf_autotest, test_hash_readwrite_lf_main);
+REGISTER_TEST_COMMAND(hash_readwrite_lf_perf_autotest,
+		      test_hash_readwrite_lf_main);
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 14+ messages in thread

* [dpdk-dev] [PATCH v2 1/1] test/meson: hash lf test moved to dpdk perf testsuite
  2019-09-06  5:49 ` [dpdk-dev] [PATCH 2/2] test/meson: hash lf test moved to dpdk perf testsuite agupta3
  2019-09-11 17:13   ` Wang, Yipeng1
  2019-09-13  8:12   ` [dpdk-dev] [PATCH v2 1/1] " agupta3
@ 2019-09-13  8:15   ` agupta3
  2 siblings, 0 replies; 14+ messages in thread
From: agupta3 @ 2019-09-13  8:15 UTC (permalink / raw)
  To: Yipeng Wang, Sameh Gobriel, Bruce Richardson, Pablo de Lara
  Cc: dev, Amit Gupta

From: Amit Gupta <agupta3@marvell.com>

hash_readwrite_lf test always getting TIMEOUT as required
time to finish this test was much longer compare to time
required for fast tests(10s). Hence, the test is being renamed
moved to perf test category for its execution to complete.

Signed-off-by: Amit Gupta <agupta3@marvell.com>
---
v2 Changes:
*hash_readwrite_lf_autotest renamed to hash_readwrite_lf_pref_autotest

 app/test/meson.build              | 2 +-
 app/test/test_hash_readwrite_lf.c | 3 ++-
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/app/test/meson.build b/app/test/meson.build
index 94fd9f8..57d5316 100644
--- a/app/test/meson.build
+++ b/app/test/meson.build
@@ -220,7 +220,6 @@ fast_test_names = [
         'eventdev_common_autotest',
         'fbarray_autotest',
         'hash_readwrite_func_autotest',
-        'hash_readwrite_lf_autotest',
         'ipsec_autotest',
         'kni_autotest',
         'kvargs_autotest',
@@ -263,6 +262,7 @@ perf_test_names = [
         'stack_lf_perf_autotest',
         'rand_perf_autotest',
         'hash_readwrite_perf_autotest',
+        'hash_readwrite_lf_perf_autotest',
 ]
 
 driver_test_names = [
diff --git a/app/test/test_hash_readwrite_lf.c b/app/test/test_hash_readwrite_lf.c
index 1f2fba4..33d63fa 100644
--- a/app/test/test_hash_readwrite_lf.c
+++ b/app/test/test_hash_readwrite_lf.c
@@ -1431,4 +1431,5 @@ struct {
 	return 0;
 }
 
-REGISTER_TEST_COMMAND(hash_readwrite_lf_autotest, test_hash_readwrite_lf_main);
+REGISTER_TEST_COMMAND(hash_readwrite_lf_perf_autotest,
+		      test_hash_readwrite_lf_main);
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [dpdk-dev] [PATCH 2/2] test/meson: hash lf test moved to dpdk perf testsuite
  2019-09-12 15:00     ` Honnappa Nagarahalli
@ 2019-09-13  8:24       ` Amit Gupta
  0 siblings, 0 replies; 14+ messages in thread
From: Amit Gupta @ 2019-09-13  8:24 UTC (permalink / raw)
  To: Honnappa Nagarahalli, Wang, Yipeng1, Gobriel, Sameh,
	Dharmik Thakkar, Ruifeng Wang (Arm Technology China)
  Cc: dev, nd, nd



> -----Original Message-----
> From: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
> Sent: Thursday, September 12, 2019 8:31 PM
> To: Wang, Yipeng1 <yipeng1.wang@intel.com>; Amit Gupta
> <agupta3@marvell.com>; Gobriel, Sameh <sameh.gobriel@intel.com>;
> Dharmik Thakkar <Dharmik.Thakkar@arm.com>; Ruifeng Wang (Arm
> Technology China) <Ruifeng.Wang@arm.com>
> Cc: dev@dpdk.org; nd <nd@arm.com>; Honnappa Nagarahalli
> <Honnappa.Nagarahalli@arm.com>; nd <nd@arm.com>
> Subject: [EXT] RE: [PATCH 2/2] test/meson: hash lf test moved to dpdk perf
> testsuite
> 
> External Email
> 
> ----------------------------------------------------------------------
> <snip>
> 
> > >Subject: [PATCH 2/2] test/meson: hash lf test moved to dpdk perf
> > >testsuite
> > >
> > >From: Amit Gupta <agupta3@marvell.com>
> > >
> > >hash_readwrite_lf test always getting TIMEOUT as required time to
> > >finish this test was much longer compare to time required for fast
> > >tests(10s). Hence, the test is being moved to perf test category for
> > >its execution to complete.
> > >
> > >Signed-off-by: Amit Gupta <agupta3@marvell.com>
> > >---
> > > app/test/meson.build | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > >diff --git a/app/test/meson.build b/app/test/meson.build index
> > >94fd9f8..34141c5 100644
> > >--- a/app/test/meson.build
> > >+++ b/app/test/meson.build
> > >@@ -220,7 +220,6 @@ fast_test_names = [
> > >         'eventdev_common_autotest',
> > >         'fbarray_autotest',
> > >         'hash_readwrite_func_autotest',
> > >-        'hash_readwrite_lf_autotest',
> > >         'ipsec_autotest',
> > >         'kni_autotest',
> > >         'kvargs_autotest',
> > >@@ -263,6 +262,7 @@ perf_test_names = [
> > >         'stack_lf_perf_autotest',
> > >         'rand_perf_autotest',
> > >         'hash_readwrite_perf_autotest',
> > >+        'hash_readwrite_lf_autotest',
> > > ]
> > >
> > > driver_test_names = [
> > >--
> > >1.8.3.1
> >  [Wang, Yipeng]
> > I believe the lf_autotest includes functional test as well which is
> > critical for testing the lock free implementation on non-TSO machine.
> > Do you think it is possible to also separate this test?
> > I also include the ARM folks for opinions.
> Thanks Yipeng. We combined the functional testing with performance
> testing. So, it is all performance tests. From that perspective, I suggest
> changing 'hash_readwrite_lf_autotest' to
> 'hash_readwrite_lf_perf_autotest'.
Agreed, will update in v2!
> 
> >
> > Thanks!
> > Yipeng


^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [dpdk-dev] [PATCH v2 1/1] test/meson: hash lf test moved to dpdk perf testsuite
  2019-09-13  8:12   ` [dpdk-dev] [PATCH v2 1/1] " agupta3
@ 2019-09-13 14:40     ` Aaron Conole
  2019-09-13 15:09       ` Wang, Yipeng1
  0 siblings, 1 reply; 14+ messages in thread
From: Aaron Conole @ 2019-09-13 14:40 UTC (permalink / raw)
  To: agupta3
  Cc: Yipeng Wang, Sameh Gobriel, Bruce Richardson, Pablo de Lara, dev,
	Honnappa Nagarahalli

<agupta3@marvell.com> writes:

> From: Amit Gupta <agupta3@marvell.com>
>
> hash_readwrite_lf test always getting TIMEOUT as required
> time to finish this test was much longer compare to time
> required for fast tests(10s). Hence, the test is being renamed
> moved to perf test category for its execution to complete.
>
> Signed-off-by: Amit Gupta <agupta3@marvell.com>
> ---

Okay.  I'll note that we pass the '-t 3' flag, so it is actually timing
out with 30s instead of the default 10.  We do this because occasionally
the lpm6 and table tests would also exceed the 10s timeout in the travis
environment.  I agree, it's better to pull the perf part of tests out.

I think there isn't any additional functional test in this readwrite -
is that so?  If it is, then we need to also prioritize adding back in
some of the functional testing.  Maybe I misread the lf_autotest,
though.

>  app/test/meson.build              | 2 +-
>  app/test/test_hash_readwrite_lf.c | 3 ++-
>  2 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/app/test/meson.build b/app/test/meson.build
> index 94fd9f8..57d5316 100644
> --- a/app/test/meson.build
> +++ b/app/test/meson.build
> @@ -220,7 +220,6 @@ fast_test_names = [
>          'eventdev_common_autotest',
>          'fbarray_autotest',
>          'hash_readwrite_func_autotest',
> -        'hash_readwrite_lf_autotest',
>          'ipsec_autotest',
>          'kni_autotest',
>          'kvargs_autotest',
> @@ -263,6 +262,7 @@ perf_test_names = [
>          'stack_lf_perf_autotest',
>          'rand_perf_autotest',
>          'hash_readwrite_perf_autotest',
> +        'hash_readwrite_lf_perf_autotest',
>  ]
>  
>  driver_test_names = [
> diff --git a/app/test/test_hash_readwrite_lf.c b/app/test/test_hash_readwrite_lf.c
> index 1f2fba4..33d63fa 100644
> --- a/app/test/test_hash_readwrite_lf.c
> +++ b/app/test/test_hash_readwrite_lf.c
> @@ -1431,4 +1431,5 @@ struct {
>  	return 0;
>  }
>  
> -REGISTER_TEST_COMMAND(hash_readwrite_lf_autotest, test_hash_readwrite_lf_main);
> +REGISTER_TEST_COMMAND(hash_readwrite_lf_perf_autotest,
> +		      test_hash_readwrite_lf_main);

^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [dpdk-dev] [PATCH v2 1/1] test/meson: hash lf test moved to dpdk perf testsuite
  2019-09-13 14:40     ` Aaron Conole
@ 2019-09-13 15:09       ` Wang, Yipeng1
  2019-09-13 15:46         ` Honnappa Nagarahalli
  0 siblings, 1 reply; 14+ messages in thread
From: Wang, Yipeng1 @ 2019-09-13 15:09 UTC (permalink / raw)
  To: Aaron Conole, agupta3
  Cc: Gobriel, Sameh, Richardson, Bruce, De Lara Guarch, Pablo, dev,
	Honnappa Nagarahalli

> -----Original Message-----
> From: Aaron Conole [mailto:aconole@redhat.com]
> Sent: Friday, September 13, 2019 7:41 AM
> To: agupta3@marvell.com
> Cc: Wang, Yipeng1 <yipeng1.wang@intel.com>; Gobriel, Sameh
> <sameh.gobriel@intel.com>; Richardson, Bruce
> <bruce.richardson@intel.com>; De Lara Guarch, Pablo
> <pablo.de.lara.guarch@intel.com>; dev@dpdk.org; Honnappa Nagarahalli
> <Honnappa.Nagarahalli@arm.com>
> Subject: Re: [dpdk-dev] [PATCH v2 1/1] test/meson: hash lf test moved to
> dpdk perf testsuite
> 
> <agupta3@marvell.com> writes:
> 
> > From: Amit Gupta <agupta3@marvell.com>
> >
> > hash_readwrite_lf test always getting TIMEOUT as required time to
> > finish this test was much longer compare to time required for fast
> > tests(10s). Hence, the test is being renamed moved to perf test
> > category for its execution to complete.
> >
> > Signed-off-by: Amit Gupta <agupta3@marvell.com>
> > ---
> 
> Okay.  I'll note that we pass the '-t 3' flag, so it is actually timing out with 30s
> instead of the default 10.  We do this because occasionally the lpm6 and table
> tests would also exceed the 10s timeout in the travis environment.  I agree,
> it's better to pull the perf part of tests out.
> 
> I think there isn't any additional functional test in this readwrite - is that so?
> If it is, then we need to also prioritize adding back in some of the functional
> testing.  Maybe I misread the lf_autotest, though.
> 
[Wang, Yipeng] 
Yes that is my concern too, if we just move all the lock-free test into perf test then we miss
the functional test.
Would any of you like to consider adding a small functional test into the readwrite or readwrite_lf_functional?
That would be great :)



^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [dpdk-dev] [PATCH v2 1/1] test/meson: hash lf test moved to dpdk perf testsuite
  2019-09-13 15:09       ` Wang, Yipeng1
@ 2019-09-13 15:46         ` Honnappa Nagarahalli
  2019-09-16  4:39           ` Amit Gupta
  0 siblings, 1 reply; 14+ messages in thread
From: Honnappa Nagarahalli @ 2019-09-13 15:46 UTC (permalink / raw)
  To: Wang, Yipeng1, Aaron Conole, agupta3
  Cc: Gobriel, Sameh, Richardson, Bruce, De Lara Guarch, Pablo, dev,
	Honnappa Nagarahalli, nd, nd

<snip>

> >
> > <agupta3@marvell.com> writes:
> >
> > > From: Amit Gupta <agupta3@marvell.com>
> > >
> > > hash_readwrite_lf test always getting TIMEOUT as required time to
> > > finish this test was much longer compare to time required for fast
> > > tests(10s). Hence, the test is being renamed moved to perf test
> > > category for its execution to complete.
> > >
> > > Signed-off-by: Amit Gupta <agupta3@marvell.com>
> > > ---
> >
> > Okay.  I'll note that we pass the '-t 3' flag, so it is actually
> > timing out with 30s instead of the default 10.  We do this because
> > occasionally the lpm6 and table tests would also exceed the 10s
> > timeout in the travis environment.  I agree, it's better to pull the perf part
> of tests out.
> >
> > I think there isn't any additional functional test in this readwrite - is that so?
> > If it is, then we need to also prioritize adding back in some of the
> > functional testing.  Maybe I misread the lf_autotest, though.
> >
> [Wang, Yipeng]
> Yes that is my concern too, if we just move all the lock-free test into perf test
> then we miss the functional test.
> Would any of you like to consider adding a small functional test into the
> readwrite or readwrite_lf_functional?
> That would be great :)
Yes, I will take up for readwrite_lf_functional. But, I do not have much bandwidth for 19.11. I suggest we move only part of the tests to perf tests instead for 19.11, this would serve both the purposes.

Amit, would it be possible to check what tests will run within the timeout period?
> 


^ permalink raw reply	[flat|nested] 14+ messages in thread

* Re: [dpdk-dev] [PATCH v2 1/1] test/meson: hash lf test moved to dpdk perf testsuite
  2019-09-13 15:46         ` Honnappa Nagarahalli
@ 2019-09-16  4:39           ` Amit Gupta
  0 siblings, 0 replies; 14+ messages in thread
From: Amit Gupta @ 2019-09-16  4:39 UTC (permalink / raw)
  To: Honnappa Nagarahalli, Wang, Yipeng1, Aaron Conole
  Cc: Gobriel, Sameh, Richardson, Bruce, De Lara Guarch, Pablo, dev, nd, nd



> -----Original Message-----
> From: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
> Sent: Friday, September 13, 2019 9:17 PM
> To: Wang, Yipeng1 <yipeng1.wang@intel.com>; Aaron Conole
> <aconole@redhat.com>; Amit Gupta <agupta3@marvell.com>
> Cc: Gobriel, Sameh <sameh.gobriel@intel.com>; Richardson, Bruce
> <bruce.richardson@intel.com>; De Lara Guarch, Pablo
> <pablo.de.lara.guarch@intel.com>; dev@dpdk.org; Honnappa Nagarahalli
> <Honnappa.Nagarahalli@arm.com>; nd <nd@arm.com>; nd <nd@arm.com>
> Subject: [EXT] RE: [dpdk-dev] [PATCH v2 1/1] test/meson: hash lf test moved
> to dpdk perf testsuite
> 
> External Email
> 
> ----------------------------------------------------------------------
> <snip>
> 
> > >
> > > <agupta3@marvell.com> writes:
> > >
> > > > From: Amit Gupta <agupta3@marvell.com>
> > > >
> > > > hash_readwrite_lf test always getting TIMEOUT as required time to
> > > > finish this test was much longer compare to time required for fast
> > > > tests(10s). Hence, the test is being renamed moved to perf test
> > > > category for its execution to complete.
> > > >
> > > > Signed-off-by: Amit Gupta <agupta3@marvell.com>
> > > > ---
> > >
> > > Okay.  I'll note that we pass the '-t 3' flag, so it is actually
> > > timing out with 30s instead of the default 10.  We do this because
> > > occasionally the lpm6 and table tests would also exceed the 10s
> > > timeout in the travis environment.  I agree, it's better to pull the
> > > perf part
> > of tests out.
> > >
> > > I think there isn't any additional functional test in this readwrite - is that
> so?
> > > If it is, then we need to also prioritize adding back in some of the
> > > functional testing.  Maybe I misread the lf_autotest, though.
> > >
> > [Wang, Yipeng]
> > Yes that is my concern too, if we just move all the lock-free test
> > into perf test then we miss the functional test.
> > Would any of you like to consider adding a small functional test into
> > the readwrite or readwrite_lf_functional?
> > That would be great :)
> Yes, I will take up for readwrite_lf_functional. But, I do not have much
> bandwidth for 19.11. I suggest we move only part of the tests to perf tests
> instead for 19.11, this would serve both the purposes.
> 
> Amit, would it be possible to check what tests will run within the timeout
> period?
> >
Not even a single subtest of hash_readwrite_lf runs within the timeout period of 10s. 
generate_key logic itself is taking ~8s to generate all required keys.

^ permalink raw reply	[flat|nested] 14+ messages in thread

end of thread, back to index

Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-06  5:49 [dpdk-dev] [PATCH 0/2] test/meson: fix hash readwrite timeout failure agupta3
2019-09-06  5:49 ` [dpdk-dev] [PATCH 1/2] test/meson: hash test split into shorter subtests agupta3
2019-09-11 17:05   ` Wang, Yipeng1
2019-09-06  5:49 ` [dpdk-dev] [PATCH 2/2] test/meson: hash lf test moved to dpdk perf testsuite agupta3
2019-09-11 17:13   ` Wang, Yipeng1
2019-09-12 15:00     ` Honnappa Nagarahalli
2019-09-13  8:24       ` Amit Gupta
2019-09-13  8:12   ` [dpdk-dev] [PATCH v2 1/1] " agupta3
2019-09-13 14:40     ` Aaron Conole
2019-09-13 15:09       ` Wang, Yipeng1
2019-09-13 15:46         ` Honnappa Nagarahalli
2019-09-16  4:39           ` Amit Gupta
2019-09-13  8:15   ` agupta3
2019-09-11  5:55 ` [dpdk-dev] [PATCH 0/2] test/meson: fix hash readwrite timeout failure Amit Gupta

DPDK-dev Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/dpdk-dev/0 dpdk-dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dpdk-dev dpdk-dev/ https://lore.kernel.org/dpdk-dev \
		dev@dpdk.org dpdk-dev@archiver.kernel.org
	public-inbox-index dpdk-dev


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/ public-inbox