DPDK-dev Archive on lore.kernel.org
 help / color / Atom feed
* [dpdk-dev] [PATCH] net/mlx5: fix interrupt install
@ 2019-07-21  8:16 Matan Azrad
  2019-07-21  8:51 ` Slava Ovsiienko
  2019-07-21  9:56 ` Raslan Darawsheh
  0 siblings, 2 replies; 3+ messages in thread
From: Matan Azrad @ 2019-07-21  8:16 UTC (permalink / raw)
  To: Shahaf Shuler, Yongseok Koh, Viacheslav Ovsiienko; +Cc: dev

The error path of interrupt install was done in any way.
Fix it to skip error path in case of success.

Fixes: 0134353a5951 ("net/mlx5: accelerate DV flow counter query")

Signed-off-by: Matan Azrad <matan@mellanox.com>
---
 drivers/net/mlx5/mlx5_ethdev.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/mlx5/mlx5_ethdev.c b/drivers/net/mlx5/mlx5_ethdev.c
index fdd6e03..6c9bcf1 100644
--- a/drivers/net/mlx5/mlx5_ethdev.c
+++ b/drivers/net/mlx5/mlx5_ethdev.c
@@ -1620,6 +1620,7 @@ int mlx5_fw_version_get(struct rte_eth_dev *dev, char *fw_ver, size_t fw_size)
 #endif /* HAVE_IBV_DEVX_ASYNC */
 	}
 	sh->intr_cnt++;
+	goto exit;
 error_unregister:
 	rte_intr_callback_unregister(&sh->intr_handle,
 				     mlx5_dev_interrupt_handler, sh);
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] net/mlx5: fix interrupt install
  2019-07-21  8:16 [dpdk-dev] [PATCH] net/mlx5: fix interrupt install Matan Azrad
@ 2019-07-21  8:51 ` Slava Ovsiienko
  2019-07-21  9:56 ` Raslan Darawsheh
  1 sibling, 0 replies; 3+ messages in thread
From: Slava Ovsiienko @ 2019-07-21  8:51 UTC (permalink / raw)
  To: Matan Azrad, Shahaf Shuler, Yongseok Koh; +Cc: dev

> -----Original Message-----
> From: Matan Azrad <matan@mellanox.com>
> Sent: Sunday, July 21, 2019 11:17
> To: Shahaf Shuler <shahafs@mellanox.com>; Yongseok Koh
> <yskoh@mellanox.com>; Slava Ovsiienko <viacheslavo@mellanox.com>
> Cc: dev@dpdk.org
> Subject: [PATCH] net/mlx5: fix interrupt install
> 
> The error path of interrupt install was done in any way.
> Fix it to skip error path in case of success.
> 
> Fixes: 0134353a5951 ("net/mlx5: accelerate DV flow counter query")
> 
> Signed-off-by: Matan Azrad <matan@mellanox.com>
Acked-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] net/mlx5: fix interrupt install
  2019-07-21  8:16 [dpdk-dev] [PATCH] net/mlx5: fix interrupt install Matan Azrad
  2019-07-21  8:51 ` Slava Ovsiienko
@ 2019-07-21  9:56 ` Raslan Darawsheh
  1 sibling, 0 replies; 3+ messages in thread
From: Raslan Darawsheh @ 2019-07-21  9:56 UTC (permalink / raw)
  To: Matan Azrad, Shahaf Shuler, Yongseok Koh, Slava Ovsiienko; +Cc: dev

Hi,

> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Matan Azrad
> Sent: Sunday, July 21, 2019 11:17 AM
> To: Shahaf Shuler <shahafs@mellanox.com>; Yongseok Koh
> <yskoh@mellanox.com>; Slava Ovsiienko <viacheslavo@mellanox.com>
> Cc: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] net/mlx5: fix interrupt install
> 
> The error path of interrupt install was done in any way.
> Fix it to skip error path in case of success.
> 
> Fixes: 0134353a5951 ("net/mlx5: accelerate DV flow counter query")
> 
> Signed-off-by: Matan Azrad <matan@mellanox.com>
> ---
>  drivers/net/mlx5/mlx5_ethdev.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/mlx5/mlx5_ethdev.c
> b/drivers/net/mlx5/mlx5_ethdev.c
> index fdd6e03..6c9bcf1 100644
> --- a/drivers/net/mlx5/mlx5_ethdev.c
> +++ b/drivers/net/mlx5/mlx5_ethdev.c
> @@ -1620,6 +1620,7 @@ int mlx5_fw_version_get(struct rte_eth_dev *dev,
> char *fw_ver, size_t fw_size)
>  #endif /* HAVE_IBV_DEVX_ASYNC */
>  	}
>  	sh->intr_cnt++;
> +	goto exit;
>  error_unregister:
>  	rte_intr_callback_unregister(&sh->intr_handle,
>  				     mlx5_dev_interrupt_handler, sh);
> --
> 1.8.3.1

Patch applied to next-net-mlx,

Kindest regards,
Raslan Darawsheh

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-21  8:16 [dpdk-dev] [PATCH] net/mlx5: fix interrupt install Matan Azrad
2019-07-21  8:51 ` Slava Ovsiienko
2019-07-21  9:56 ` Raslan Darawsheh

DPDK-dev Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/dpdk-dev/0 dpdk-dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dpdk-dev dpdk-dev/ https://lore.kernel.org/dpdk-dev \
		dev@dpdk.org dpdk-dev@archiver.kernel.org
	public-inbox-index dpdk-dev


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/ public-inbox