From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6703EC76188 for ; Sun, 21 Jul 2019 09:56:30 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id C9F062084C for ; Sun, 21 Jul 2019 09:56:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=Mellanox.com header.i=@Mellanox.com header.b="AnUHQyJp" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C9F062084C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mellanox.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1FB7B2BC7; Sun, 21 Jul 2019 11:56:28 +0200 (CEST) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70075.outbound.protection.outlook.com [40.107.7.75]) by dpdk.org (Postfix) with ESMTP id 94F4B1041 for ; Sun, 21 Jul 2019 11:56:26 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Bv/PkYVwmbVNej4A/EycwQsicfh5Ejjg9/PGshyBR18IqYa8Na4Knf7kL7BCMYjqDmpLAFTmPNHUZJolsmxG0ykG0v8npRZqpJOSmKCJo2jQKjmP1A6fbOuV45A2UiK3RQ/5mAIXBY1p0vPS2ALXMMwHe0koNq/OQC20cb1j51XTyDnZEJtr/xTaYSsKVTurpJ0ss6yeRUY9I3IQ0GcQ7cB96lY/0pHOi9d7ZrMyt5pdE5zez2SvLwWvkqYWi0LwkChT7QaL6wb1YVNk72MdkGfCDsg8aNscW5ZLkGXwzHekvoggowkiwvFpsj+j2uM9GQIqFOb5KNItRCS7FQ1a7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZjC7BiYfFt1/bsNsDkt53+2dN/n/hS58RYHUNoCb3Nw=; b=ObpX99VlnCj65g31mJ3ottHTwTU39Q++nafXPl4mbWRQdzFv1niCiloZ8ebMvXJvygPE3WJQ5vwNRDe4s+n9lCJadOTaDKCM1xb9/RsWmLUCsvpUVn7w8/NR1SisMS8yhDUn8FJL0pry2wBTuzFRsTiZ+kXs2gjDR1yIiZpyW5vVd4TmyM0wZYaQAEHA8e6YrO3yz38LcITJxu71s0y7gAW46NYZclCYFxK/toXeOzRC+h/3Ycr4AK/504mc7g/itBonAKNECjjPpPBrqqtjISpFUVUMT8UwuYKov4JNkmkdQYBaCYutYGgont4HeqwkFWK94PFObt0L0jySkpuB/w== ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=pass smtp.mailfrom=mellanox.com;dmarc=pass action=none header.from=mellanox.com;dkim=pass header.d=mellanox.com;arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZjC7BiYfFt1/bsNsDkt53+2dN/n/hS58RYHUNoCb3Nw=; b=AnUHQyJprNaPOzQsqNMRb6jrwnf/h3SjlAU2bhFt9zHoKm57eiEMOGOIDDy1rQ59Xs+p9BkAxu9Nkv3ufSxoakZdqZVhQsTu7rrHG4dr2uwp7Sub5RO0SXTsKg7yvEAycc7bWITgZfzSdmhoV90YnAWHUmL0ySgY7Ag3EfEC5cc= Received: from DB3PR0502MB3964.eurprd05.prod.outlook.com (52.134.65.161) by DB3PR0502MB4012.eurprd05.prod.outlook.com (52.134.68.29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2073.14; Sun, 21 Jul 2019 09:56:24 +0000 Received: from DB3PR0502MB3964.eurprd05.prod.outlook.com ([fe80::bcc1:5331:1dca:7360]) by DB3PR0502MB3964.eurprd05.prod.outlook.com ([fe80::bcc1:5331:1dca:7360%7]) with mapi id 15.20.2094.013; Sun, 21 Jul 2019 09:56:24 +0000 From: Raslan Darawsheh To: Matan Azrad , Shahaf Shuler , Yongseok Koh , Slava Ovsiienko CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] net/mlx5: fix interrupt install Thread-Index: AQHVP5ysPKN8bnCXtkmCa07SaStlRqbU1cqw Date: Sun, 21 Jul 2019 09:56:24 +0000 Message-ID: References: <1563697004-8052-1-git-send-email-matan@mellanox.com> In-Reply-To: <1563697004-8052-1-git-send-email-matan@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=rasland@mellanox.com; x-originating-ip: [212.29.221.74] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 2e1d98bb-6c0d-4649-2a4b-08d70dc1b137 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:DB3PR0502MB4012; x-ms-traffictypediagnostic: DB3PR0502MB4012: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2089; x-forefront-prvs: 0105DAA385 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(376002)(39860400002)(136003)(366004)(346002)(396003)(13464003)(199004)(189003)(5660300002)(55016002)(6436002)(81166006)(9686003)(6246003)(52536014)(81156014)(256004)(4326008)(8936002)(316002)(476003)(110136005)(3846002)(7736002)(486006)(6116002)(25786009)(86362001)(446003)(11346002)(53936002)(66446008)(76116006)(64756008)(66556008)(66476007)(66946007)(102836004)(53546011)(71190400001)(186003)(6636002)(74316002)(229853002)(68736007)(26005)(33656002)(99286004)(6506007)(66066001)(8676002)(7696005)(76176011)(2906002)(305945005)(71200400001)(478600001)(14454004); DIR:OUT; SFP:1101; SCL:1; SRVR:DB3PR0502MB4012; H:DB3PR0502MB3964.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: ns+bMPONvF7xGcCZ6IW2jHg1XUtj0w6PtUQNH44xvRRo0V3JcSIiVJLjsxJxhjuQ324jsfvrQT2HU2bFPx1+DzwFPZaIRiSBWZwWg2bMN4ymY5m7a5kvaaM8boK4frHnbbHNOByGrOeSY6rIKktYdLS6mA9bKZ1rKoRyJAbKks5+9OgajUdSFicPneV5U8mU9LSEJYlPX3Ourqag5MeSJSODN/+VutOGu6jVPLhlObfbArLLKqH5Uyw69bkyGD3+gOxkL2WNiTjuqB0NOB1DuYoYTvo58AX56VQkcnAU7rfLXuN9LU6guuS6BeQY4oHHJM1sa7gvS2wGZLT4Cu0kuFOy73H1EjKcE3i1KrlH4dsTzZzB6AI9u9AjL55rY3LwhQfh0l7f3kyMQDTSx65Ks7LN65qOZdwLUnlWGzreeyc= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2e1d98bb-6c0d-4649-2a4b-08d70dc1b137 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Jul 2019 09:56:24.7787 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: rasland@mellanox.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0502MB4012 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix interrupt install X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: dev On Behalf Of Matan Azrad > Sent: Sunday, July 21, 2019 11:17 AM > To: Shahaf Shuler ; Yongseok Koh > ; Slava Ovsiienko > Cc: dev@dpdk.org > Subject: [dpdk-dev] [PATCH] net/mlx5: fix interrupt install >=20 > The error path of interrupt install was done in any way. > Fix it to skip error path in case of success. >=20 > Fixes: 0134353a5951 ("net/mlx5: accelerate DV flow counter query") >=20 > Signed-off-by: Matan Azrad > --- > drivers/net/mlx5/mlx5_ethdev.c | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/drivers/net/mlx5/mlx5_ethdev.c > b/drivers/net/mlx5/mlx5_ethdev.c > index fdd6e03..6c9bcf1 100644 > --- a/drivers/net/mlx5/mlx5_ethdev.c > +++ b/drivers/net/mlx5/mlx5_ethdev.c > @@ -1620,6 +1620,7 @@ int mlx5_fw_version_get(struct rte_eth_dev *dev, > char *fw_ver, size_t fw_size) > #endif /* HAVE_IBV_DEVX_ASYNC */ > } > sh->intr_cnt++; > + goto exit; > error_unregister: > rte_intr_callback_unregister(&sh->intr_handle, > mlx5_dev_interrupt_handler, sh); > -- > 1.8.3.1 Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh