From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D3C0FC6195 for ; Fri, 8 Nov 2019 14:33:53 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 39C52214DB for ; Fri, 8 Nov 2019 14:33:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=Mellanox.com header.i=@Mellanox.com header.b="UjrFHsS/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 39C52214DB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mellanox.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 650D41C1D9; Fri, 8 Nov 2019 15:33:52 +0100 (CET) Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30081.outbound.protection.outlook.com [40.107.3.81]) by dpdk.org (Postfix) with ESMTP id 8812C1C1C7 for ; Fri, 8 Nov 2019 15:33:50 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oSwjauRFaB1bY6PSVDNFs+l5kcgwNKLWJJvY2se8cpH13/a+Spe3dDiSTMGYBtGnfuaeFil5wo26JqO1SLoq1mYXrdKjG7xG+AC7HDTQMU2DtiujbwXXQOy6gXcduD4yKbzGzpjRDc1jY4hMcezrdJzRpYXhwsK4eo6vc+ZXT3cdXAPezH8Qc0LkKiKf78CNLOJE/2F3s6yT/VWoZK7dZti1d6dYxV0Ot6Jg9fTSjX/1ltdi9JIa3P1BC/QotYTGMvLOmzKVeFosh+c7s0K4R3NL4ie0ET0iyP+nm9y7aV9dnaKWt3BtEoOU4RVVoLHrfu7Nqv0s8du5FtSsKi9abw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0yoSefN5voDyuKgnCLt4PgU+NPSVT9bIVveVlccgBdk=; b=XjKKfaWA6i7k/GXnXVk1Rok7b8XgZh5EHDXp1r2p8XLOmeZyvVBRDY6ztd//39jwohx600FMp2QXsfDGsyDDbI08ARhxLKXTfckWLkIAbrXeOFIN3hH262BfeDi+bnUnRny8eolngO7n3Q4eTgVEpGAYecMT4BD3Bott3OBLSuv4F6BINKs0BwcDbo/wjIBkKs0rvKoGeNl8wEqERo+VPuhtqi6myt7guFvr4aBXbJGfutwVI7gog11UOuiLhLOWEfA8YbtW3ORRIzPgGwDEFGszrj+g6jkaYxx0NeVPccrb2288B08e4bbe/RCXoQNK0K358ZFDR90K/cXNrf+95w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0yoSefN5voDyuKgnCLt4PgU+NPSVT9bIVveVlccgBdk=; b=UjrFHsS/dT8RwMJvmzgywnM1srjmHVJjwNPr5IuWj/8DnfrGFaSK6p0CK9WqOGz0u89jcYAXpj10ZD1CLUcPMBlrxvizT87gCvqWMgAWcT0UJ3CkdfO8xaRVlwfvJYfd5QKo4ZW0EnasfDP/KPuuhWObBuVzcPntGmoBUWAhTeQ= Received: from DB3PR0502MB3964.eurprd05.prod.outlook.com (52.134.65.161) by DB3PR0502MB4043.eurprd05.prod.outlook.com (52.134.68.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2430.20; Fri, 8 Nov 2019 14:33:49 +0000 Received: from DB3PR0502MB3964.eurprd05.prod.outlook.com ([fe80::a850:bac9:c90f:f2f5]) by DB3PR0502MB3964.eurprd05.prod.outlook.com ([fe80::a850:bac9:c90f:f2f5%6]) with mapi id 15.20.2408.028; Fri, 8 Nov 2019 14:33:49 +0000 From: Raslan Darawsheh To: Slava Ovsiienko , "dev@dpdk.org" CC: Matan Azrad , Ori Kam Thread-Topic: [PATCH] net/mlx5: fix asserts for multi-segment Tx offload misconfig Thread-Index: AQHVlW3aB4CY0KUn8U2burl0LE4MDaeBWCLQ Date: Fri, 8 Nov 2019 14:33:49 +0000 Message-ID: References: <1573132704-6637-1-git-send-email-viacheslavo@mellanox.com> In-Reply-To: <1573132704-6637-1-git-send-email-viacheslavo@mellanox.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=rasland@mellanox.com; x-originating-ip: [188.161.230.21] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: deafe241-d687-4135-9823-08d76458aba8 x-ms-traffictypediagnostic: DB3PR0502MB4043:|DB3PR0502MB4043: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-forefront-prvs: 0215D7173F x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(39860400002)(366004)(136003)(396003)(376002)(346002)(199004)(189003)(13464003)(99286004)(110136005)(71200400001)(6436002)(2501003)(54906003)(71190400001)(486006)(102836004)(7736002)(5660300002)(6116002)(3846002)(14454004)(478600001)(33656002)(229853002)(52536014)(74316002)(76176011)(4326008)(186003)(26005)(305945005)(86362001)(76116006)(66066001)(446003)(8676002)(6506007)(53546011)(11346002)(107886003)(316002)(6246003)(81156014)(81166006)(8936002)(25786009)(256004)(476003)(66446008)(2906002)(7696005)(55016002)(9686003)(66556008)(64756008)(66476007)(66946007); DIR:OUT; SFP:1101; SCL:1; SRVR:DB3PR0502MB4043; H:DB3PR0502MB3964.eurprd05.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: VmUW3DR1oCep0R5I19c7Ehh2zu11nV0jW7a7bmJLrbYTFZeQEc2GfDWFo4UphgC2OQNvpAEBW+IEjxm/kLPSNx26f3J60hO4eqYkH6xEp0cVaztdZKhSw7SrCtSZmlEkvsVeOCrtBMh8RfRJO71Xdee/AlTpdEzeuq1BgOEPl6qwOaQTrxckaqyX7t1o5y1SfIcKQKwBXPAl/mJ4Mo4HF/Az1Uc/4M5vi4zA64Pj79jI00zzrrRkwhr/F4jVNQ7kLkGytcYOgeTnXEyLRVpc7q89poAEZDolmvetozQ3ekPeTqglQJjV1MBS/I2kC0K1T3Xefg+knsiIKKLuQD6FqobmE8jOFuqGppfAGfF8bud+k0MaBQA87QPMcn7ZDNtpatElOkpZ0c2lwPQ/6tQaC1sH130QMYVseQDwMvHIaw+c+bo1qsw2kFksf0rax24r Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: deafe241-d687-4135-9823-08d76458aba8 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Nov 2019 14:33:49.5357 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: s1uBgDWUGulcMCBkAqBKQ6s6GV1iZM4bnaL0H3mMwEP/mbbgW1sMOufBxJAFiFpZhFIW5fW0btW6QPnaihEXvg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0502MB4043 Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix asserts for multi-segment Tx offload misconfig X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: Viacheslav Ovsiienko > Sent: Thursday, November 7, 2019 3:18 PM > To: dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; Ori Kam > Subject: [PATCH] net/mlx5: fix asserts for multi-segment Tx offload misco= nfig >=20 > To support multi-segment packet sending the Tx datapath > DEV_TX_OFFLOAD_MULTI_SEGS offload must be configured. > In debug configuration the asserts arise if the multi-segment > packet is being sent and no DEV_TX_OFFLOAD_MULTI_SEGS is set. > It was found that in some execution paths asserts were missed, > this patch adds ones. >=20 > Fixes: 18a1c20044c0 ("net/mlx5: implement Tx burst template") >=20 > Signed-off-by: Viacheslav Ovsiienko > --- > drivers/net/mlx5/mlx5_rxtx.c | 4 ++++ > 1 file changed, 4 insertions(+) >=20 > diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c > index 887e283..ecebd72 100644 > --- a/drivers/net/mlx5/mlx5_rxtx.c > +++ b/drivers/net/mlx5/mlx5_rxtx.c > @@ -3870,6 +3870,7 @@ enum mlx5_txcmp_code { > unsigned int slen =3D 0; >=20 > next_empw: > + assert(NB_SEGS(loc->mbuf) =3D=3D 1); > part =3D RTE_MIN(pkts_n, MLX5_EMPW_MAX_PACKETS); > if (unlikely(loc->elts_free < part)) { > /* We have no enough elts to save all mbufs. */ > @@ -3929,6 +3930,7 @@ enum mlx5_txcmp_code { > return MLX5_TXCMP_CODE_EXIT; > return MLX5_TXCMP_CODE_MULTI; > } > + assert(NB_SEGS(loc->mbuf) =3D=3D 1); > if (ret =3D=3D MLX5_TXCMP_CODE_TSO) { > part -=3D loop; > mlx5_tx_sdone_empw(txq, loc, part, slen, > olx); > @@ -4028,6 +4030,7 @@ enum mlx5_txcmp_code { > unsigned int room, part, nlim; > unsigned int slen =3D 0; >=20 > + assert(NB_SEGS(loc->mbuf) =3D=3D 1); > /* > * Limits the amount of packets in one WQE > * to improve CQE latency generation. > @@ -4168,6 +4171,7 @@ enum mlx5_txcmp_code { > return MLX5_TXCMP_CODE_EXIT; > return MLX5_TXCMP_CODE_MULTI; > } > + assert(NB_SEGS(loc->mbuf) =3D=3D 1); > if (ret =3D=3D MLX5_TXCMP_CODE_TSO) { > part -=3D room; > mlx5_tx_idone_empw(txq, loc, part, slen, > olx); > -- > 1.8.3.1 Patch applied to next-net-mlx, Kindest regards, Raslan Darawsheh