From: "Wang, Haiyue" <haiyue.wang@intel.com> To: David Marchand <david.marchand@redhat.com>, Stephen Hemminger <stephen@networkplumber.org> Cc: dev <dev@dpdk.org>, Neil Horman <nhorman@tuxdriver.com> Subject: Re: [dpdk-dev] [RFC v2 1/3] ethdev: add the API for getting trace information Date: Tue, 13 Aug 2019 11:21:04 +0000 Message-ID: <E3B9F2FDCB65864C82CD632F23D8AB8773D5B6E8@shsmsx102.ccr.corp.intel.com> (raw) In-Reply-To: <CAJFAV8z_hq95=Rt8Hw9xHcWOuUOvMs+Jh=fBTgRZakyg90Oocw@mail.gmail.com> > -----Original Message----- > From: David Marchand [mailto:david.marchand@redhat.com] > Sent: Tuesday, August 13, 2019 17:58 > To: Stephen Hemminger <stephen@networkplumber.org>; Wang, Haiyue <haiyue.wang@intel.com> > Cc: dev <dev@dpdk.org>; Neil Horman <nhorman@tuxdriver.com> > Subject: Re: [dpdk-dev] [RFC v2 1/3] ethdev: add the API for getting trace information > > On Tue, Aug 13, 2019 at 5:24 AM Stephen Hemminger > <stephen@networkplumber.org> wrote: > > > > On Tue, 13 Aug 2019 11:06:10 +0800 > > Haiyue Wang <haiyue.wang@intel.com> wrote: > > > > int rte_eth_tx_queue_info_get(uint16_t port_id, uint16_t queue_id, > > > struct rte_eth_txq_info *qinfo); > > > > > > +int > > > +rte_eth_trace_info_get(uint16_t port_id, uint16_t queue_id, > > > + enum rte_eth_trace type, char *buf, int sz); > > > + > > > > You didn't run checkpatch, otherwise you would have seen complaints > > about not listing API as experimental. > > The checks in checkpatches.sh won't catch this. > But trying to build dpdk as a shared library will. > > Example: https://travis-ci.com/david-marchand/dpdk/jobs/224737320 > > Got it, thanks for sharing, just for a quick RFC, missed something in detail for making an API. > -- > David Marchand
next prev parent reply index Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-08-13 3:06 [dpdk-dev] [RFC v2 0/3] show the Rx/Tx burst description field Haiyue Wang 2019-08-13 3:06 ` [dpdk-dev] [RFC v2 1/3] ethdev: add the API for getting trace information Haiyue Wang 2019-08-13 3:24 ` Stephen Hemminger 2019-08-13 4:37 ` Wang, Haiyue 2019-08-13 9:57 ` David Marchand 2019-08-13 11:21 ` Wang, Haiyue [this message] 2019-08-13 12:51 ` Ray Kinsella 2019-09-06 14:21 ` Ferruh Yigit 2019-09-07 2:42 ` Wang, Haiyue 2019-09-09 11:23 ` Ferruh Yigit 2019-09-09 12:40 ` Bruce Richardson 2019-09-09 12:50 ` Ferruh Yigit 2019-09-09 13:17 ` Ferruh Yigit 2019-09-10 4:36 ` Wang, Haiyue 2019-09-10 8:06 ` Ferruh Yigit 2019-09-10 8:37 ` Wang, Haiyue 2019-09-10 9:14 ` Ferruh Yigit 2019-09-10 11:41 ` Wang, Haiyue 2019-09-10 15:00 ` Ferruh Yigit 2019-09-10 15:17 ` Wang, Haiyue 2019-09-10 15:33 ` Ferruh Yigit 2019-09-10 15:35 ` Wang, Haiyue 2019-09-10 14:19 ` Wang, Haiyue 2019-09-10 15:03 ` Ferruh Yigit 2019-09-10 15:18 ` Wang, Haiyue 2019-09-10 15:36 ` Ferruh Yigit 2019-09-10 15:38 ` Wang, Haiyue 2019-09-10 15:06 ` Ferruh Yigit 2019-09-10 15:21 ` Wang, Haiyue 2019-09-10 15:35 ` Ferruh Yigit 2019-09-10 15:37 ` Wang, Haiyue 2019-10-26 16:45 ` Thomas Monjalon 2019-10-27 4:10 ` Wang, Haiyue 2019-08-15 9:07 ` Ray Kinsella 2019-08-13 3:06 ` [dpdk-dev] [RFC v2 2/3] testpmd: show the Rx/Tx burst description Haiyue Wang 2019-08-13 3:06 ` [dpdk-dev] [RFC v2 3/3] net/ice: support the Rx/Tx burst description trace Haiyue Wang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=E3B9F2FDCB65864C82CD632F23D8AB8773D5B6E8@shsmsx102.ccr.corp.intel.com \ --to=haiyue.wang@intel.com \ --cc=david.marchand@redhat.com \ --cc=dev@dpdk.org \ --cc=nhorman@tuxdriver.com \ --cc=stephen@networkplumber.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK-dev Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/dpdk-dev/0 dpdk-dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dpdk-dev dpdk-dev/ https://lore.kernel.org/dpdk-dev \ dev@dpdk.org public-inbox-index dpdk-dev Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git