From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Van Haaren, Harry" Subject: Re: [PATCH] Create kern folder for Linux kernel modules Date: Fri, 22 Dec 2017 14:28:31 +0000 Message-ID: References: <1513922231-15554-1-git-send-email-hemant.agrawal@nxp.com> <2388140.F1AUfV8GGA@xps> <1e293147-9c72-9e77-97cb-9aabc9e5af39@nxp.com> <4919393.KhUSbVM1LT@xps> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: "dev@dpdk.org" , "Yigit, Ferruh" , Hemant Agrawal To: Thomas Monjalon Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 2B05B1B38B for ; Fri, 22 Dec 2017 15:28:35 +0100 (CET) In-Reply-To: <4919393.KhUSbVM1LT@xps> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon > Sent: Friday, December 22, 2017 11:38 AM > To: Hemant Agrawal > Cc: dev@dpdk.org; Yigit, Ferruh > Subject: Re: [dpdk-dev] [PATCH] Create kern folder for Linux kernel modul= es >=20 > 22/12/2017 11:04, Hemant Agrawal: > > On 12/22/2017 2:13 PM, Thomas Monjalon wrote: > > > Hi, > > > > > > 22/12/2017 06:57, Hemant Agrawal: > > >> This patch moves the Linux kernel modules code to a common place. > > >> - Separate the kernel module code from user space code. > > >> - The GPL-2.0 licensed code is separated from the BSD-3 licensed > userspace > > >> code > > > > > > What is the benefit of separate things by license? > > > > The separation makes it easy to identify and check the license. > > > > Any patch introducing new file in *non-kern* folders shall not be > > GPL-2.0 licensed. Or GPL-2.0 license is allowed only for kern folder. >=20 > The kernel modules are in DPDK only for historical reasons. > We should get rid of them, and rely only on upstream modules. >=20 > And it should be allowed to have kernel-related files elsewhere. > Examples: GPL tools or BPF code. >=20 > > > These modules are Linux modules, so they should be in the linuxapp di= r. > > > > > > This is a cleaner separation w.r.t userspace/kernel space code. > > *kern* is a better placefolder for LKMs. >=20 > I prefer "kernel" name. >=20 > > Also eal is not getting overloaded. > > > > linuxapp is part of librte_eal. KNI is not related to EAL, but still > > the kni kernel code is added to librte_eal under linuxapp. >=20 > Yes it makes sense. >=20 > More opinions/votes? No strong opinion on moving source code around here... but: We should be careful that the build system leaves the .ko and other files i= n the same place as before as moving the build output may break automated d= eployments of other projects that use DPDK. We've accidentally broken things before, for example moving scripts/ to use= rtools/ broke automation in OpenStack IIRC. > > > There are also some kernel modules in the bsdapp directory. > > > > We can move them as well.