From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4524C7618F for ; Fri, 19 Jul 2019 17:01:32 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 82B862184E for ; Fri, 19 Jul 2019 17:01:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 82B862184E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A8A787CBC; Fri, 19 Jul 2019 19:01:31 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 665B55680; Fri, 19 Jul 2019 19:01:29 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Jul 2019 10:01:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,283,1559545200"; d="scan'208";a="173554163" Received: from irsmsx109.ger.corp.intel.com ([163.33.3.23]) by orsmga006.jf.intel.com with ESMTP; 19 Jul 2019 10:01:26 -0700 Received: from irsmsx104.ger.corp.intel.com ([169.254.5.40]) by IRSMSX109.ger.corp.intel.com ([169.254.13.29]) with mapi id 14.03.0439.000; Fri, 19 Jul 2019 18:01:26 +0100 From: "Lipiec, Herakliusz" To: Thomas Monjalon CC: "dev@dpdk.org" , "stable@dpdk.org" , "Richardson, Bruce" Thread-Topic: [dpdk-dev] [PATCH] mk: fix output directory name when compiling with custom kernel header dir Thread-Index: AQHVPWykMttRqgemnUmrs2pympfJcKbQV4sAgACMPwCAAOWhkP//93wAgABrG4A= Date: Fri, 19 Jul 2019 17:01:25 +0000 Message-ID: References: <20190718132912.28250-1-herakliusz.lipiec@intel.com> <1901807.fy38742gHy@xps> <5528023.XUqoTqKA7R@xps> In-Reply-To: <5528023.XUqoTqKA7R@xps> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOGJiMWQ1ZDctNWU2MC00ZjI5LThjNDktNmNjYjQ1ZWE0Zjg5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiZVJhKzIzYTdMN0JRVmc2bkxzbTNNWE0za0s1a01UdzR1alNKTGlnR0hKRHYybTFZTXhaZGkwZDVQam9lMFowcCJ9 x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] mk: fix output directory name when compiling with custom kernel header dir X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Friday, July 19, 2019 12:37 PM > To: Lipiec, Herakliusz > Cc: dev@dpdk.org; stable@dpdk.org; Richardson, Bruce > > Subject: Re: [dpdk-dev] [PATCH] mk: fix output directory name when > compiling with custom kernel header dir >=20 > 19/07/2019 13:09, Lipiec, Herakliusz: > > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > > 18/07/2019 16:03, Herakliusz Lipiec: > > > > -kerneldir ?=3D /lib/modules/$(shell uname -r)/extra/dpdk > > > > +kerneldir ?=3D $(subst /build,/extra/dpdk,$(RTE_KERNELDIR)) > > > > > > I would suggest another syntax, easier to read: > > > > > > kerneldir ?=3D $(RTE_KERNELDIR:/build=3D/extra/dpdk) > > > > > I have tried that before and it didn't seem to solve the issue. >=20 > Why? What is the output of $(info $(kerneldir)) ? >=20 I have tested your line again, and it worked, I compared against the one I = was using at the beginning And I found that I was missing slash. I will resend a v3.