From: "Yang, Qiming" <qiming.yang@intel.com> To: "Zhang, Qi Z" <qi.z.zhang@intel.com>, "Ye, Xiaolong" <xiaolong.ye@intel.com> Cc: "Wang, Haiyue" <haiyue.wang@intel.com>, "dev@dpdk.org" <dev@dpdk.org>, "Zhang, Qi Z" <qi.z.zhang@intel.com>, "Stillwell Jr, Paul M" <paul.m.stillwell.jr@intel.com> Subject: Re: [dpdk-dev] [PATCH 15/17] net/iavf/base: fix send adminq return value Date: Thu, 2 Jan 2020 02:48:12 +0000 Message-ID: <F5DF4F0E3AFEF648ADC1C3C33AD4DBF17A5A803B@SHSMSX101.ccr.corp.intel.com> (raw) In-Reply-To: <20191203070318.39620-16-qi.z.zhang@intel.com> > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Qi Zhang > Sent: Tuesday, December 3, 2019 3:03 PM > To: Ye, Xiaolong <xiaolong.ye@intel.com> > Cc: Wang, Haiyue <haiyue.wang@intel.com>; dev@dpdk.org; Zhang, Qi Z > <qi.z.zhang@intel.com>; Stillwell Jr, Paul M <paul.m.stillwell.jr@intel.com> > Subject: [dpdk-dev] [PATCH 15/17] net/iavf/base: fix send adminq return > value > > When send a adminq, if get IAVF_AQ_RC_BUSY, we should return > IAVF_ERR_NOT_READY. > > Fixes: e5b2a9e957e7 ("net/avf/base: add base code for avf PMD") > Lack of CC stable > Signed-off-by: Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com> > Signed-off-by: Qi Zhang <qi.z.zhang@intel.com> > --- > drivers/net/iavf/base/iavf_adminq.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/net/iavf/base/iavf_adminq.c > b/drivers/net/iavf/base/iavf_adminq.c > index 0a5b2b281..c1668d228 100644 > --- a/drivers/net/iavf/base/iavf_adminq.c > +++ b/drivers/net/iavf/base/iavf_adminq.c > @@ -803,6 +803,8 @@ enum iavf_status iavf_asq_send_command(struct > iavf_hw *hw, > cmd_completed = true; > if ((enum iavf_admin_queue_err)retval == IAVF_AQ_RC_OK) > status = IAVF_SUCCESS; > + else if ((enum iavf_admin_queue_err)retval == > IAVF_AQ_RC_EBUSY) > + status = IAVF_ERR_NOT_READY; > else > status = IAVF_ERR_ADMIN_QUEUE_ERROR; > hw->aq.asq_last_status = (enum > iavf_admin_queue_err)retval; > -- > 2.13.6
next prev parent reply index Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-12-03 7:03 [dpdk-dev] [PATCH 00/17] iavf base code update Qi Zhang 2019-12-03 7:03 ` [dpdk-dev] [PATCH 01/17] net/iavf/base: remove unnecessary header file Qi Zhang 2019-12-03 7:03 ` [dpdk-dev] [PATCH 02/17] net/iavf/base: rename error code enum Qi Zhang 2019-12-03 7:03 ` [dpdk-dev] [PATCH 03/17] net/iavf/base: rename register macro Qi Zhang 2019-12-03 7:03 ` [dpdk-dev] [PATCH 04/17] net/iavf/base: update device id Qi Zhang 2019-12-03 7:03 ` [dpdk-dev] [PATCH 05/17] net/iavf/base: remove unused code Qi Zhang 2019-12-03 7:03 ` [dpdk-dev] [PATCH 06/17] net/iavf/base: remove unnecessary compile option Qi Zhang 2019-12-03 7:03 ` [dpdk-dev] [PATCH 07/17] net/iavf/base: rename functions Qi Zhang 2019-12-03 7:03 ` [dpdk-dev] [PATCH 08/17] net/iavf/base: update virtual channel Qi Zhang 2019-12-03 7:03 ` [dpdk-dev] [PATCH 09/17] net/iavf/base: adjust code indent Qi Zhang 2019-12-03 7:03 ` [dpdk-dev] [PATCH 10/17] net/iavf/base: increase max VSI count for VFs Qi Zhang 2019-12-03 7:03 ` [dpdk-dev] [PATCH 11/17] net/iavf/base: fix command buffer memory free Qi Zhang 2019-12-03 7:03 ` [dpdk-dev] [PATCH 12/17] net/iavf/base: update FW API version for X722 Qi Zhang 2019-12-03 7:03 ` [dpdk-dev] [PATCH 13/17] net/iavf/base: add more link speed support Qi Zhang 2019-12-03 7:03 ` [dpdk-dev] [PATCH 14/17] net/iavf/base: update copyright date Qi Zhang 2019-12-03 7:03 ` [dpdk-dev] [PATCH 15/17] net/iavf/base: fix send adminq return value Qi Zhang 2020-01-02 2:48 ` Yang, Qiming [this message] 2019-12-03 7:03 ` [dpdk-dev] [PATCH 16/17] net/iavf: move device state flag Qi Zhang 2019-12-03 7:03 ` [dpdk-dev] [PATCH 17/17] net/ice/base: update version info Qi Zhang 2020-01-02 2:50 ` [dpdk-dev] [PATCH 00/17] iavf base code update Yang, Qiming 2020-01-02 3:14 ` Ye Xiaolong
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=F5DF4F0E3AFEF648ADC1C3C33AD4DBF17A5A803B@SHSMSX101.ccr.corp.intel.com \ --to=qiming.yang@intel.com \ --cc=dev@dpdk.org \ --cc=haiyue.wang@intel.com \ --cc=paul.m.stillwell.jr@intel.com \ --cc=qi.z.zhang@intel.com \ --cc=xiaolong.ye@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK-dev Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/dpdk-dev/0 dpdk-dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dpdk-dev dpdk-dev/ https://lore.kernel.org/dpdk-dev \ dev@dpdk.org public-inbox-index dpdk-dev Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git