From mboxrd@z Thu Jan  1 00:00:00 1970
From: Shreyansh Jain <shreyansh.jain@nxp.com>
Subject: Re: [PATCH v3 3/7] net/dpaa2: change into dynamic logging
Date: Thu, 29 Mar 2018 18:01:39 +0000
Message-ID: <HE1PR0402MB27801E9AFA67AAC2EA48246890A20@HE1PR0402MB2780.eurprd04.prod.outlook.com>
References: <20180313054431.19556-1-shreyansh.jain@nxp.com>
 <20180323120456.16920-1-shreyansh.jain@nxp.com>
 <20180323120456.16920-4-shreyansh.jain@nxp.com> <2107185.outpdSVCPl@xps>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "dev@dpdk.org" <dev@dpdk.org>, "ferruh.yigit@intel.com"
 <ferruh.yigit@intel.com>, Hemant Agrawal <hemant.agrawal@nxp.com>, Nipun
 Gupta <nipun.gupta@nxp.com>, Akhil Goyal <akhil.goyal@nxp.com>
To: Thomas Monjalon <thomas@monjalon.net>
Return-path: <dev-bounces@dpdk.org>
Received: from EUR02-VE1-obe.outbound.protection.outlook.com
 (mail-eopbgr20045.outbound.protection.outlook.com [40.107.2.45])
 by dpdk.org (Postfix) with ESMTP id 1679C2BBD
 for <dev@dpdk.org>; Thu, 29 Mar 2018 20:02:08 +0200 (CEST)
In-Reply-To: <2107185.outpdSVCPl@xps>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> Sent: Thursday, March 29, 2018 8:57 PM
> To: Shreyansh Jain <shreyansh.jain@nxp.com>
> Cc: dev@dpdk.org; ferruh.yigit@intel.com; Hemant Agrawal
> <hemant.agrawal@nxp.com>; Nipun Gupta <nipun.gupta@nxp.com>; Akhil Goyal
> <akhil.goyal@nxp.com>
> Subject: Re: [dpdk-dev] [PATCH v3 3/7] net/dpaa2: change into dynamic
> logging
>=20
> 23/03/2018 13:04, Shreyansh Jain:
> > --- a/config/common_base
> > +++ b/config/common_base
> > @@ -189,11 +189,6 @@ CONFIG_RTE_LIBRTE_DPAA2_USE_PHYS_IOVA=3Dy
> >  # Compile burst-oriented NXP DPAA2 PMD driver
> >  #
> >  CONFIG_RTE_LIBRTE_DPAA2_PMD=3Dn
> > -CONFIG_RTE_LIBRTE_DPAA2_DEBUG_INIT=3Dn
> > -CONFIG_RTE_LIBRTE_DPAA2_DEBUG_DRIVER=3Dn
> > -CONFIG_RTE_LIBRTE_DPAA2_DEBUG_RX=3Dn
> > -CONFIG_RTE_LIBRTE_DPAA2_DEBUG_TX=3Dn
> > -CONFIG_RTE_LIBRTE_DPAA2_DEBUG_TX_FREE=3Dn
> [...]
> > --- a/config/defconfig_arm64-dpaa2-linuxapp-gcc
> > +++ b/config/defconfig_arm64-dpaa2-linuxapp-gcc
> > @@ -26,15 +26,7 @@ CONFIG_RTE_LIBRTE_VHOST_NUMA=3Dn
> >  # Compile Support Libraries for DPAA2
> >  #
> >  CONFIG_RTE_LIBRTE_DPAA2_USE_PHYS_IOVA=3Dn
> > -
> > -#
> > -# Compile burst-oriented NXP DPAA2 PMD driver
> > -#
> > -CONFIG_RTE_LIBRTE_DPAA2_DEBUG_INIT=3Dn
> >  CONFIG_RTE_LIBRTE_DPAA2_DEBUG_DRIVER=3Dn
> > -CONFIG_RTE_LIBRTE_DPAA2_DEBUG_RX=3Dn
> > -CONFIG_RTE_LIBRTE_DPAA2_DEBUG_TX=3Dn
> > -CONFIG_RTE_LIBRTE_DPAA2_DEBUG_TX_FREE=3Dn
>=20
>=20
> CONFIG_RTE_LIBRTE_DPAA2_DEBUG_DRIVER should be in config/common_base.
>=20
> All options should be in config/common_base.
> Other files should be used only to overwrite config/common_base.
>=20

OK. I explicitly didn't put it in common_base because this is not a general=
 option. It should be limited to only those who wish to debug/develop on th=
is. It is not something an end-user should worry about.

Anyways, I will send another version.

-
Shreyansh