From mboxrd@z Thu Jan  1 00:00:00 1970
From: Shreyansh Jain <shreyansh.jain@nxp.com>
Subject: Re: [PATCH v2 4/4] testpmd: make use of per-PMD TxRx
	parameters
Date: Wed, 28 Mar 2018 07:18:53 +0000
Message-ID: <HE1PR0402MB2780D28954F000320667B89B90A30@HE1PR0402MB2780.eurprd04.prod.outlook.com>
References: <20180321142749.27520-1-remy.horton@intel.com>
 <20180321142749.27520-5-remy.horton@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: John McNamara <john.mcnamara@intel.com>, Wenzhuo Lu
 <wenzhuo.lu@intel.com>, Jingjing Wu <jingjing.wu@intel.com>, Qi Zhang
 <qi.z.zhang@intel.com>, Beilei Xing <beilei.xing@intel.com>, Thomas Monjalon
 <thomas@monjalon.net>
To: Remy Horton <remy.horton@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Return-path: <dev-bounces@dpdk.org>
Received: from EUR03-VE1-obe.outbound.protection.outlook.com
 (mail-eopbgr50046.outbound.protection.outlook.com [40.107.5.46])
 by dpdk.org (Postfix) with ESMTP id 234DB5F21
 for <dev@dpdk.org>; Wed, 28 Mar 2018 09:19:14 +0200 (CEST)
In-Reply-To: <20180321142749.27520-5-remy.horton@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hello Remy,

> -----Original Message-----
> From: Remy Horton [mailto:remy.horton@intel.com]
> Sent: Wednesday, March 21, 2018 7:58 PM
> To: dev@dpdk.org
> Cc: John McNamara <john.mcnamara@intel.com>; Wenzhuo Lu
> <wenzhuo.lu@intel.com>; Jingjing Wu <jingjing.wu@intel.com>; Qi Zhang
> <qi.z.zhang@intel.com>; Beilei Xing <beilei.xing@intel.com>; Shreyansh
> Jain <shreyansh.jain@nxp.com>; Thomas Monjalon <thomas@monjalon.net>
> Subject: [PATCH v2 4/4] testpmd: make use of per-PMD TxRx parameters
>=20
> The optimal values of several transmission & reception related
> parameters, such as burst sizes, descriptor ring sizes, and number
> of queues, varies between different network interface devices. This
> patch allows testpmd to make use of per-PMD tuned parameter values.
>=20
> Signed-off-by: Remy Horton <remy.horton@intel.com>
> ---
>  app/test-pmd/testpmd.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>=20
> diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
> index 4c0e258..82eb197 100644
> --- a/app/test-pmd/testpmd.c
> +++ b/app/test-pmd/testpmd.c
> @@ -210,9 +210,10 @@ queueid_t nb_txq =3D 1; /**< Number of TX queues per
> port. */
>=20
>  /*
>   * Configurable number of RX/TX ring descriptors.
> + * Defaults are supplied by drivers via ethdev.
>   */
> -#define RTE_TEST_RX_DESC_DEFAULT 1024
> -#define RTE_TEST_TX_DESC_DEFAULT 1024
> +#define RTE_TEST_RX_DESC_DEFAULT 0
> +#define RTE_TEST_TX_DESC_DEFAULT 0
>  uint16_t nb_rxd =3D RTE_TEST_RX_DESC_DEFAULT; /**< Number of RX
> descriptors. */
>  uint16_t nb_txd =3D RTE_TEST_TX_DESC_DEFAULT; /**< Number of TX
> descriptors. */

Can the change for burst size too be accommodated in this patch?
I looked through them and they might not be as trivial as the change above =
- but if that is incorporated in this, it might serve as example for other =
applications.

Or, I am also OK sending a separate patch for that change (maybe for iofwd =
case, at least)

Either way:

Acked-by: Shreyansh Jain <shreyansh.jain@nxp.com>