From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C872C31E57 for ; Mon, 17 Jun 2019 10:34:33 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 749E72084D for ; Mon, 17 Jun 2019 10:34:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=marvell.com header.i=@marvell.com header.b="XQRqAAWz"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=marvell.onmicrosoft.com header.i=@marvell.onmicrosoft.com header.b="UAc6jLkn" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 749E72084D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=marvell.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 814181BED3; Mon, 17 Jun 2019 12:34:31 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id 32D311BED1 for ; Mon, 17 Jun 2019 12:34:30 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x5HAU2pO001100; Mon, 17 Jun 2019 03:34:29 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=iIbAd1X2w1CEdARu08H+srkFR7EEBDPc8gitxY57qMo=; b=XQRqAAWz/LCbgM+q3GS5J0bjS7kTf91LpVj9tvgllA7EQxa9y/WOqItM42iZApKgQb+7 zZpf/WK6hKbRtTKgyuK96KTFOubsyOImNbiF05NI0UzJr1Wy+GSEnl8y+8JrTTc9I56h rA9+HJW1zzy+vvPJxgI+iqyNPfO751V9ua23HW5n+j3fL17a60IHBQtlvNVXfSHpwicx Z0Kx1Z2VemkjVEDD99C6NxyM2ZLnBzGSi5HML8gEPTTstethTGrDdaEFu8+sHNSLTj/g pJpHI8snH1H/qnUt5EtgJZ3uQBdgWQ49Bia4QSjpntxw6D2r1NkZyiQ6+++diBkm87/U uw== Received: from sc-exch01.marvell.com ([199.233.58.181]) by mx0a-0016f401.pphosted.com with ESMTP id 2t68rp836f-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Mon, 17 Jun 2019 03:34:29 -0700 Received: from SC-EXCH04.marvell.com (10.93.176.84) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Mon, 17 Jun 2019 03:34:28 -0700 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.36.52) by SC-EXCH04.marvell.com (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Mon, 17 Jun 2019 03:34:27 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector2-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iIbAd1X2w1CEdARu08H+srkFR7EEBDPc8gitxY57qMo=; b=UAc6jLknJ2mDhluv6vXubVih//p5FZ92t8rVg5Bw0wwjzbI+DFx1JgPkGOktqaanlATbnh75pPtSigr6FzSX/sNdW2Xwm4pAEz4Aypi+dxKthgDGn5z8dcYGn1Mco2JLHUommuN24zQ/s78JT6/Xo6JDOAMaCX7dzQCNcP7aN54= Received: from MN2PR18MB2877.namprd18.prod.outlook.com (20.179.20.218) by MN2PR18MB2365.namprd18.prod.outlook.com (20.179.82.203) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1987.10; Mon, 17 Jun 2019 10:34:26 +0000 Received: from MN2PR18MB2877.namprd18.prod.outlook.com ([fe80::3d9b:ed4b:b155:9bad]) by MN2PR18MB2877.namprd18.prod.outlook.com ([fe80::3d9b:ed4b:b155:9bad%3]) with mapi id 15.20.1987.014; Mon, 17 Jun 2019 10:34:26 +0000 From: Anoob Joseph To: "Carrillo, Erik G" , Jerin Jacob Kollanukkaran , "Rao, Nikhil" , "Gujjar, Abhinandan S" , "Richardson, Bruce" , "De Lara Guarch, Pablo" CC: Narayana Prasad Raju Athreya , "dev@dpdk.org" , Lukas Bartosik , "Pavan Nikhilesh Bhagavatula" , Hemant Agrawal , Nipun Gupta , "Van Haaren, Harry" , =?iso-8859-1?Q?Mattias_R=F6nnblom?= , "Ma, Liang J" Thread-Topic: [EXT] Re: [dpdk-dev] [PATCH 32/39] eventdev: add routine to launch eventmode workers Thread-Index: AQHVH5lKeZr5KC+Rt02Qviww71yj/aafrmwA Date: Mon, 17 Jun 2019 10:34:25 +0000 Message-ID: References: <1559583160-13944-1-git-send-email-anoobj@marvell.com> <1559583160-13944-33-git-send-email-anoobj@marvell.com> In-Reply-To: Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [115.113.156.2] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 50a8a5ae-47eb-4930-6fb9-08d6f30f5ed9 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328)(7193020); SRVR:MN2PR18MB2365; x-ms-traffictypediagnostic: MN2PR18MB2365: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 0071BFA85B x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(136003)(366004)(376002)(346002)(39850400004)(396003)(13464003)(189003)(199004)(102836004)(76176011)(256004)(486006)(66574012)(7696005)(305945005)(71200400001)(71190400001)(11346002)(81156014)(5660300002)(316002)(476003)(81166006)(7416002)(6246003)(74316002)(7736002)(14444005)(14454004)(478600001)(33656002)(446003)(3846002)(6116002)(4326008)(229853002)(25786009)(9686003)(52536014)(99286004)(55016002)(53546011)(66946007)(73956011)(76116006)(6436002)(53936002)(66446008)(64756008)(66556008)(66476007)(6506007)(66066001)(2906002)(186003)(86362001)(8936002)(26005)(68736007)(54906003)(55236004)(110136005)(921003)(1121003); DIR:OUT; SFP:1101; SCL:1; SRVR:MN2PR18MB2365; H:MN2PR18MB2877.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: ZptgZT+vDmx3C5T+HdTRskSCqOd9ZZ4DmAN8V20QMQn3eiAAUfltLCtr51U67YFT6txsTMQj7k0Dxb02PA7N8LD5z/ZR6C5ZjquxULF+vXuc625TMDXQGlvWN4XAgn1gjl9Xi2pxJYoLoRIhfK1/zpMeKuPlQFQqYqLcoRtvxNZVrgq1XER7WbZOHE7IQgEZ9OXaWztYMLwWHz72rB2W9ENxVtRw6GoiOrKQDCqEVEcgXA9GUKZaNpBYMdOQGIdf++hlgisVYTeha1CbIxOZcHyPRKAhZyzfnoUObc8uHGt5/I/xwuSlArx8lHhy9r0S7wA/l2mBGt9dbRcO2HQ8iR76uAACA0H/MsBK1ghxmp7TzZIoB9fmmj3nKTKFweyVVzR1laT/nIRPKwm30Z4IN9cAkLGUsb6LMfMzITkxXgI= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 50a8a5ae-47eb-4930-6fb9-08d6f30f5ed9 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Jun 2019 10:34:25.9242 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: anoobj@marvell.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR18MB2365 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-06-17_05:, , signatures=0 Subject: Re: [dpdk-dev] [EXT] Re: [PATCH 32/39] eventdev: add routine to launch eventmode workers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Erik, Please see inline. Thanks, Anoob > -----Original Message----- > From: dev On Behalf Of Carrillo, Erik G > Sent: Monday, June 10, 2019 8:02 PM > To: Anoob Joseph ; Jerin Jacob Kollanukkaran > ; Rao, Nikhil ; Gujjar, > Abhinandan S ; Richardson, Bruce > ; De Lara Guarch, Pablo > > Cc: Narayana Prasad Raju Athreya ; dev@dpdk.org; > Lukas Bartosik ; Pavan Nikhilesh Bhagavatula > ; Hemant Agrawal > ; Nipun Gupta ; Van > Haaren, Harry ; Mattias R=F6nnblom > ; Ma, Liang J > Subject: [EXT] Re: [dpdk-dev] [PATCH 32/39] eventdev: add routine to laun= ch > eventmode workers >=20 > External Email >=20 > ---------------------------------------------------------------------- > Hi Anoob, >=20 > I've listed a few notes in-line. >=20 > > -----Original Message----- > > From: Anoob Joseph > > Sent: Monday, June 3, 2019 12:33 PM > > To: Jerin Jacob ; Rao, Nikhil > > ; Carrillo, Erik G ; > > Gujjar, Abhinandan S ; Richardson, Bruce > > ; De Lara Guarch, Pablo > > > > Cc: Anoob Joseph ; Narayana Prasad > > ; dev@dpdk.org; Lukasz Bartosik > > ; Pavan Nikhilesh ; > > Hemant Agrawal ; Nipun Gupta > > ; Van Haaren, Harry > ; > > Mattias R=F6nnblom ; Ma, Liang J > > > > Subject: [PATCH 32/39] eventdev: add routine to launch eventmode > > workers > > > > With eventmode, workers could be drafted differently according to the > > capabilities of the underlying event device. The added function would > > receive an array of such workers and probes the eventmode properties > > to choose the worker. > > > > Signed-off-by: Anoob Joseph > > Signed-off-by: Lukasz Bartosik > > --- >=20 > <...snipped...> >=20 > > + > > +/* Event mode packet tx types */ > > +enum rte_eventmode_helper_tx_types { > > + RTE_EVETNMODE_HELPER_TX_TYPE_INVALID =3D 0, >=20 > A couple of characters are transposed in the above. [Anoob] Will fix it in v2. >=20 > > + RTE_EVENTMODE_HELPER_TX_TYPE_MAX =3D 16 }; > > + > > struct rte_eventmode_helper_conf { > > enum rte_eventmode_helper_pkt_transfer_mode mode; > > /**< Packet transfer mode of the application */ @@ -41,6 > > +55,20 @@ struct rte_eventmode_helper_event_link_info { > > /**< Lcore to be polling on this port */ }; > > >=20 > I believe anonymous unions and structures should be annotated with > RTE_STD_C11 below and in other places throughout the series. [Anoob] Will fix in v2. >=20 > > +/* Workers registered by the application */ struct > > +rte_eventmode_helper_app_worker_params { > > + union { > > + struct { > > + uint64_t burst : 4; > > + /**< Specify status of rx type burst */ > > + }; > > + uint64_t u64; > > + } cap; > > + /**< Capabilities of this worker */ > > + void (*worker_thread)(void *mode_conf); > > + /**< Worker thread */ > > +}; > > + > > /* Common helper functions for command line parsing */ > > > > /** > > @@ -157,6 +185,27 @@ uint8_t __rte_experimental > > rte_eventmode_helper_get_tx_queue(struct > rte_eventmode_helper_conf > > *mode_conf, > > uint8_t eventdev_id); > > >=20 > The doxygen documentation for __rte_experimental functions in general > should have: >=20 > * @warning > * @b EXPERIMENTAL: this API may change without prior notice >=20 > as well. >=20 [Anoob] Will add in v2. > > +/** > > + * Launch eventmode worker > > + * > > + * The application can request the eventmode helper subsystem to > > +launch the > > + * worker based on the capabilities of event device and the options > > +selected > > + * while initializing the eventmode. > > + * > > + * @param mode_conf > > + * Configuration of the mode in which app is doing packet handling > > + * @param app_wrkr > > + * List of all the workers registered by application, along with it'= s > > + * capabilities > > + * @param nb_wrkr_param > > + * Number of workers passed by the application > > + * > > + */ > > +void __rte_experimental > > +rte_eventmode_helper_launch_worker(struct > > rte_eventmode_helper_conf *mode_conf, > > + struct rte_eventmode_helper_app_worker_params > > *app_wrkr, > > + uint8_t nb_wrkr_param); > > + > > #ifdef __cplusplus > > } > > #endif >=20 > <...snipped...> >=20 > Regards, > Erik