From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1FDAC31E57 for ; Mon, 17 Jun 2019 10:24:03 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 2EEA62084D for ; Mon, 17 Jun 2019 10:24:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=marvell.com header.i=@marvell.com header.b="ByMC8eIZ"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=marvell.onmicrosoft.com header.i=@marvell.onmicrosoft.com header.b="Za7dZK2V" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2EEA62084D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=marvell.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4ECD21BEC6; Mon, 17 Jun 2019 12:24:02 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id 8C87D1BE16 for ; Mon, 17 Jun 2019 12:24:00 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x5HAKh9n025909; Mon, 17 Jun 2019 03:23:59 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=hUoYe1H2yK8NeToRBy6ENWyZ3YcSUPmlCQjoRhLVBFY=; b=ByMC8eIZtk0yWwYYUtp0Df3Kk8dlNejMPzIwX13T1LtuVbX59EqeFjf7eykJEA6TjS3V LXmorlpekqBPZI5Zlb9PyuadFwPxFpazEE5mG+5AJaODbscjSMOXe3ljugEy3c+Ucua3 KPNIX2nujPfkN6guQUHAgac4PdNOIO24NGun2kthKrPQnYk9BmW7bIUzBtKS/jsNAT9/ QVVhOCl306C/ctUupUVyTs92KQKFaiZVWv/VK8D2ROUFJNURk/gyJSoyLu82eutPZ3rK F+A4Df/X39/WFEE82okSC700hPSvSL//eO1+vDT2GbFjRfpFtngBxyoni4rWuv7iv7Uj Rw== Received: from sc-exch01.marvell.com ([199.233.58.181]) by mx0a-0016f401.pphosted.com with ESMTP id 2t68rp824v-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Mon, 17 Jun 2019 03:23:59 -0700 Received: from SC-EXCH01.marvell.com (10.93.176.81) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Mon, 17 Jun 2019 03:23:58 -0700 Received: from NAM02-CY1-obe.outbound.protection.outlook.com (104.47.37.56) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Mon, 17 Jun 2019 03:23:58 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector2-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hUoYe1H2yK8NeToRBy6ENWyZ3YcSUPmlCQjoRhLVBFY=; b=Za7dZK2V3QWOYgvSbWXLwLPBY9wqEew7aqFFMT5Ln2cD/cz5JcPRgGUpvGugIL/IZDdr/yJhf8Mw46ruV0Rlh5BXFgIlydEgprw0c1R6od1k9CPFHKCwr6EtkGLhHVGZi3vaCXhW4e1jqUwCLRONATKhJq5/ZroBXdtMj7iQvUQ= Received: from MN2PR18MB2877.namprd18.prod.outlook.com (20.179.20.218) by MN2PR18MB2701.namprd18.prod.outlook.com (20.179.22.217) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1987.12; Mon, 17 Jun 2019 10:23:57 +0000 Received: from MN2PR18MB2877.namprd18.prod.outlook.com ([fe80::3d9b:ed4b:b155:9bad]) by MN2PR18MB2877.namprd18.prod.outlook.com ([fe80::3d9b:ed4b:b155:9bad%3]) with mapi id 15.20.1987.014; Mon, 17 Jun 2019 10:23:57 +0000 From: Anoob Joseph To: Jerin Jacob Kollanukkaran , Nikhil Rao , Erik Gabriel Carrillo , Abhinandan Gujjar , Bruce Richardson , Pablo de Lara CC: Narayana Prasad Raju Athreya , "dev@dpdk.org" , Lukas Bartosik , "Pavan Nikhilesh Bhagavatula" , Hemant Agrawal , Nipun Gupta , Harry van Haaren , =?iso-8859-1?Q?Mattias_R=F6nnblom?= , Liang Ma Thread-Topic: [PATCH 25/39] eventdev: add routine to validate conf Thread-Index: AQHVGjLZ5z1IZNsMH0S9WxeJolh6J6aUuSAAgAr/shA= Date: Mon, 17 Jun 2019 10:23:57 +0000 Message-ID: References: <1559583160-13944-1-git-send-email-anoobj@marvell.com> <1559583160-13944-26-git-send-email-anoobj@marvell.com> In-Reply-To: Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [115.113.156.2] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: bb9bd9a7-58f4-4d48-f76c-08d6f30de813 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328)(7193020); SRVR:MN2PR18MB2701; x-ms-traffictypediagnostic: MN2PR18MB2701: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-forefront-prvs: 0071BFA85B x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39850400004)(136003)(376002)(346002)(396003)(366004)(13464003)(189003)(199004)(6506007)(86362001)(81156014)(52536014)(53936002)(6436002)(25786009)(33656002)(81166006)(55236004)(5660300002)(110136005)(53546011)(2906002)(102836004)(7416002)(8676002)(54906003)(66574012)(4326008)(99286004)(8936002)(74316002)(6246003)(7696005)(15650500001)(55016002)(76176011)(229853002)(305945005)(316002)(76116006)(14444005)(486006)(73956011)(66446008)(7736002)(66946007)(66476007)(66556008)(64756008)(9686003)(14454004)(26005)(478600001)(71200400001)(446003)(6116002)(476003)(3846002)(256004)(68736007)(11346002)(66066001)(186003)(71190400001); DIR:OUT; SFP:1101; SCL:1; SRVR:MN2PR18MB2701; H:MN2PR18MB2877.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: V1XCAFhakcbBiOzkNLjk8uYtQL6fwzQ+QVrPToW7KRjSA2thhy45q0Y4g4mP2d5aFYR30L+7DMMu5vo8AuD1En5E5NdSzxWBtmQM+CTsD4QTIJHFZPCSy/RSx9GYk7qNucHnwjtBtThlIAt54c6qeHQsdHcUqj45z+vWxXDqeYAw3M8Iyw4lVQpIlTz7se6O+p5iMfpGXfSG5+5nAhVU1Q8+GnkMlnoZRZwymrHuFA7Bu3628g51dENIBf7pLmyXPMHhUnIgmsiLhydTf+auzHZCQAmgJ+JqUG+1WI0cq9rpOpjQnrQiVenCwmwXQtERIdEs9zZMTLqPkjpksPd5cqmzva779CC/hoSb9CB4b1dmkq6eEdF3IkMHOWLrzVjOfHKZxsiaXmoykyvNb326gO/oh0HJdOJqxDSj0GKsYTM= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: bb9bd9a7-58f4-4d48-f76c-08d6f30de813 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Jun 2019 10:23:57.1212 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: anoobj@marvell.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR18MB2701 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-06-17_05:, , signatures=0 Subject: Re: [dpdk-dev] [PATCH 25/39] eventdev: add routine to validate conf X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Jerin, Please see inline. Thanks, Anoob > -----Original Message----- > From: Jerin Jacob Kollanukkaran > Sent: Monday, June 10, 2019 3:55 PM > To: Anoob Joseph ; Nikhil Rao > ; Erik Gabriel Carrillo = ; > Abhinandan Gujjar ; Bruce Richardson > ; Pablo de Lara > > Cc: Anoob Joseph ; Narayana Prasad Raju Athreya > ; dev@dpdk.org; Lukas Bartosik > ; Pavan Nikhilesh Bhagavatula > ; Hemant Agrawal > ; Nipun Gupta ; Harry > van Haaren ; Mattias R=F6nnblom > ; Liang Ma > Subject: RE: [PATCH 25/39] eventdev: add routine to validate conf >=20 > > -----Original Message----- > > From: Anoob Joseph > > Sent: Monday, June 3, 2019 11:02 PM > > To: Jerin Jacob Kollanukkaran ; Nikhil Rao > > ; Erik Gabriel Carrillo > > ; Abhinandan Gujjar > > ; Bruce Richardson > > ; Pablo de Lara > > > > Cc: Anoob Joseph ; Narayana Prasad Raju Athreya > > ; dev@dpdk.org; Lukas Bartosik > > ; Pavan Nikhilesh Bhagavatula > > ; Hemant Agrawal > ; > > Nipun Gupta ; Harry van Haaren > > ; Mattias R=F6nnblom > > ; Liang Ma > > Subject: [PATCH 25/39] eventdev: add routine to validate conf > > > > Adding routine to validate event mode conf. This function will verify > > the conf requested by the user and would populate other fields with > default values. > > Presently, the function acts as placeholder for the above mentioned > actions. > > > > Signed-off-by: Anoob Joseph > > Signed-off-by: Lukasz Bartosik > > --- > > lib/librte_eventdev/rte_eventmode_helper.c | 33 > > ++++++++++++++++++++++++++++++ > > 1 file changed, 33 insertions(+) > > > > diff --git a/lib/librte_eventdev/rte_eventmode_helper.c > > b/lib/librte_eventdev/rte_eventmode_helper.c > > index a57f837..4dbb94a 100644 > > --- a/lib/librte_eventdev/rte_eventmode_helper.c > > +++ b/lib/librte_eventdev/rte_eventmode_helper.c > > @@ -165,6 +165,32 @@ rte_eventmode_helper_parse_args(int argc, char > > **argv) > > return NULL; > > } > > > > +/* Pre-process conf before using for init*/ > > + > > +static int > > +rte_eventmode_validate_user_params(struct eventmode_conf > > *em_conf) { >=20 > No need to start with rte_eventmode_... for internal functions [Anoob] Will fix in v2.