From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6AD12C06510 for ; Tue, 2 Jul 2019 14:17:33 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id CBC682146F for ; Tue, 2 Jul 2019 14:17:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=marvell.com header.i=@marvell.com header.b="F0hFAgMo"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=marvell.onmicrosoft.com header.i=@marvell.onmicrosoft.com header.b="DTUje/4T" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CBC682146F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=marvell.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A37A21B995; Tue, 2 Jul 2019 16:17:31 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id BAF1D5424; Tue, 2 Jul 2019 16:17:29 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x62E9MTb005086; Tue, 2 Jul 2019 07:17:29 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=4BkBgyVUjVDP0pCtNfZnbN0ER51gobGnNi3WoFJW19E=; b=F0hFAgMowwxqrWchNrpXJWzqjOO/ocAdS/C4EKNpnzEeZygkf7bQAl5+LUWDx7dRARdB 4hCC/s+8buSBTgsV308fbUJQSpMzJBFoBJ3bxR76eFd4/VLb2OW5jYCZLLT5Rb0D36yV fxl4Mt/53SpvEiRBPFTxwI1mjrIwzg/7e6CXJZ9IiYJvmOOR35IHmDAz+scUJ7Gme54U lR1NK4MlfGO3BSyxe7OFFq4vSvFn/HbVuZXc0AeMF/NVLc7/G4+R45kgM8tcjDnZkw6r yD0khZ5n8WgXrGrJRCJXzpo7sdGlkFh+gAMvA8pfD2cUbku6aegPDmHdEH6H2vXtgRCq 8w== Received: from sc-exch04.marvell.com ([199.233.58.184]) by mx0b-0016f401.pphosted.com with ESMTP id 2tg57313ps-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Tue, 02 Jul 2019 07:17:29 -0700 Received: from SC-EXCH02.marvell.com (10.93.176.82) by SC-EXCH04.marvell.com (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Tue, 2 Jul 2019 07:17:27 -0700 Received: from NAM03-CO1-obe.outbound.protection.outlook.com (104.47.40.56) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Tue, 2 Jul 2019 07:17:26 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector2-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4BkBgyVUjVDP0pCtNfZnbN0ER51gobGnNi3WoFJW19E=; b=DTUje/4T7u5QslkTK0TSe68M7dtzgyRskXk32lnToKzgpRS3ViYfiGu54oW6HGE/aslPZf8c5oPok2fgF0TVrQvUPjmhhrKmawnMzXzGw4lJbt7L0q+TEBspqQWAL4CsiLC3YCsBgDBv2BmclXp0SMRjiOWhgRcj8P8nvmPyO3k= Received: from MN2PR18MB2877.namprd18.prod.outlook.com (20.179.20.218) by MN2PR18MB3424.namprd18.prod.outlook.com (10.255.239.13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2032.20; Tue, 2 Jul 2019 14:17:25 +0000 Received: from MN2PR18MB2877.namprd18.prod.outlook.com ([fe80::595e:3b6c:3d12:7285]) by MN2PR18MB2877.namprd18.prod.outlook.com ([fe80::595e:3b6c:3d12:7285%7]) with mapi id 15.20.2032.019; Tue, 2 Jul 2019 14:17:25 +0000 From: Anoob Joseph To: Thomas Monjalon , Jerin Jacob Kollanukkaran CC: "dev@dpdk.org" , =?iso-8859-1?Q?Mattias_R=F6nnblom?= , Nikhil Rao , "Erik Gabriel Carrillo" , Abhinandan Gujjar , Bruce Richardson , Pablo de Lara , Narayana Prasad Raju Athreya , Lukas Bartosik , "Pavan Nikhilesh Bhagavatula" , Hemant Agrawal , Nipun Gupta , Harry van Haaren , Liang Ma , "techboard@dpdk.org" Thread-Topic: [dpdk-dev] [EXT] Re: [PATCH 00/39] adding eventmode helper library Thread-Index: AQHVMODfJaWShYqkoEST+UIrk446lQ== Date: Tue, 2 Jul 2019 14:17:25 +0000 Message-ID: References: <2775383.qy1u6QUkDx@xps> In-Reply-To: Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [117.98.153.232] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f9f02e8d-359a-4e97-949b-08d6fef801b9 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(5600148)(711020)(4605104)(1401327)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7193020); SRVR:MN2PR18MB3424; x-ms-traffictypediagnostic: MN2PR18MB3424: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-forefront-prvs: 008663486A x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(136003)(346002)(376002)(39860400002)(366004)(396003)(13464003)(189003)(199004)(6436002)(7696005)(86362001)(53546011)(6246003)(76176011)(9686003)(8936002)(71200400001)(305945005)(6506007)(68736007)(7416002)(33656002)(55016002)(74316002)(66556008)(71190400001)(53936002)(26005)(7736002)(256004)(186003)(99286004)(8676002)(25786009)(81156014)(102836004)(6636002)(81166006)(229853002)(5660300002)(52536014)(6116002)(3846002)(561944003)(2906002)(446003)(76116006)(66946007)(73956011)(478600001)(66446008)(11346002)(64756008)(66476007)(486006)(54906003)(110136005)(4326008)(66066001)(14454004)(316002)(476003); DIR:OUT; SFP:1101; SCL:1; SRVR:MN2PR18MB3424; H:MN2PR18MB2877.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: 2VS4Bb9ywKIDFF5pTEglP2RPGRyJdc3Gil3FAOc+1/3XhN8OsVl/ly6JszNp13KUcCEQ8qN2kIFxddSyDpDmhRjZ+FMnWr3MzgxgpeyqiIwOmnIFvprDyvGJWK/QLIJ+rS30dWTd3F931KEUS6xw7pEYyY7H1/Ov631BV9x4D6PPNgPoUMhvJ3wTIzxLwha+zL2wWZxyVCJic6uptVyqE3USWrFvmp8UlLWBvruBYWEFignV3iWc6C2ZlzIjfnNXaRQ8Z02rQ+ZkvufOyifuyX904bPJCJdTDnXGAZkJi/N9dR5FqsYFweW5DOi1FiPEbRL2jrU2FsZ3KPO5FMu8u4fEhhon9ET/QZxCTh3i/MyYdr7yOXFaqs5nKxNg7yi/eaIMlexyezYAWX/XSZKQQhuevtj+uMjJyJwVFpucaKk= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: f9f02e8d-359a-4e97-949b-08d6fef801b9 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Jul 2019 14:17:25.2318 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: anoobj@marvell.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR18MB3424 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-07-02_07:, , signatures=0 Subject: Re: [dpdk-dev] [EXT] Re: [PATCH 00/39] adding eventmode helper library X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Thomas, Jerin, Is there any consensus on how we should proceed? Can this be taken up by te= chboard? Thanks, Anoob > -----Original Message----- > From: dev On Behalf Of Anoob Joseph > Sent: Friday, June 28, 2019 5:04 PM > To: Thomas Monjalon ; Jerin Jacob Kollanukkaran > > Cc: dev@dpdk.org; Mattias R=F6nnblom ; > Nikhil Rao ; Erik Gabriel Carrillo > ; Abhinandan Gujjar ; > Bruce Richardson ; Pablo de Lara > ; Narayana Prasad Raju Athreya > ; Lukas Bartosik ; Pavan > Nikhilesh Bhagavatula ; Hemant Agrawal > ; Nipun Gupta ; Harry van > Haaren ; Liang Ma ; > techboard@dpdk.org > Subject: Re: [dpdk-dev] [EXT] Re: [PATCH 00/39] adding eventmode helper > library >=20 > Hi Thomas, Jerin, >=20 > > -----Original Message----- > > From: dev On Behalf Of Thomas Monjalon > > Sent: Friday, June 28, 2019 2:10 PM > > To: Jerin Jacob Kollanukkaran ; Anoob Joseph > > > > Cc: dev@dpdk.org; Mattias R=F6nnblom ; > > Nikhil Rao ; Erik Gabriel Carrillo > > ; Abhinandan Gujjar > > ; Bruce Richardson > > ; Pablo de Lara > > ; Narayana Prasad Raju Athreya > > ; Lukas Bartosik ; Pavan > > Nikhilesh Bhagavatula ; Hemant Agrawal > > ; Nipun Gupta ; Harry > van > > Haaren ; Liang Ma ; > > techboard@dpdk.org > > Subject: [EXT] Re: [dpdk-dev] [PATCH 00/39] adding eventmode helper > > library > > > > External Email > > > > ---------------------------------------------------------------------- > > 28/06/2019 05:37, Jerin Jacob Kollanukkaran: > > > From: Anoob Joseph > > > > From: Jerin Jacob Kollanukkaran > > > > > From: Anoob Joseph > > > > > > The helper library will be experimental while we add > > > > > > event-mode support for other applications like l3fwd & > > > > > > ipsec-secgw. I expect the helper library to be complete over > > > > > > the course of those applications also using the helper library. > > > > You are doing a copy of l2fwd example to add event mode. > > It was the decision from the techboard to not complicate the original l= 2fwd. > > But it makes me nervous to see some code duplicated, especially if you > > plan to do the same for l3fwd and ipsec-secgw. > > We are not going to duplicate every examples. We should re-consider. > > >=20 > [Anoob] For l3fwd & ipsec-secgw, the plan is to add eventmode in the orig= inal > application itself. If you have concerns about code duplication in l2fwd-= event, > the changes can be added to l2fwd itself. Please advise on how to proceed= . >=20 > > > > > I have only concern about moving this as library inside eventdev > > > > > that till we have mature version of helper library the eventdev > > > > > library ABI will not stable(i.e .so file version needs to be > > > > > incremented as when a change needed). Which align with Mattias > > > > > thoughts for some other reason:. How about moving this code to > > > > > 1) example/common or > > > > > 2) to specific application itself, once at least two > > > > > applications starts using it then move to Eventdev library. > > > > > > > > > > Thoughts? > > > > > > > > [Anoob] Either location is not a problem if there is a consensus. > > > > Earlier the suggestion was to move it to library (when the patch > > > > was submitted with changes added in app). > > > > If there is only one user, making it grow in the application looks to > > be the best thing to do. > > Should we use it in more applications before it is more mature? > > If not, we could move the code in eventdev library when we will use it > > in more examples. > > >=20 > [Anoob] The proposal with l2fwd-event was to present an easy enough examp= le > so that the APIs can be decided before moving onto complex examples. > Additions to l3fwd & ipsec-secgw is in the pipeline. >=20 > > > If there NO objections then lets move to example/common. > > > > If we really want to have this library standalone in examples, I > > suggest to give it a name and not use a "common" directory. > > >=20 > [Anoob] I would suggest to add the eventmode code in 'examples/utils'. >=20 > What is being added here can be treated as a utility library. Almost all = examples > have duplicated code for the entire conf parsing, ethdev init etc. Anyone= who > would attempt a new application will have to duplicate lot of code. So a = similar > exercise with regular poll mode is also possible. >=20 > As for build, we will have the following options, >=20 > 1. From the examples//Makefile, build *helper*.o files ( > '../utils/eventmode_helper.o') and prepare the binary. So each applicatio= n will > build its own version of *helper*.c > +SRCS-y +=3D ../utils/eventmode_helper.c >=20 > 2. Make 'examples/utils' a separate library. This way, all applications c= an directly > link without having to build separately. >=20 > Please do suggest on which would be a good way to execute. >=20 > Thanks, > Anoob