From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D496C4321A for ; Tue, 11 Jun 2019 03:45:55 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 01B1120820 for ; Tue, 11 Jun 2019 03:45:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=marvell.com header.i=@marvell.com header.b="IgqfNC2h"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=marvell.onmicrosoft.com header.i=@marvell.onmicrosoft.com header.b="e1V56jNa" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 01B1120820 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=marvell.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DA1DB1C246; Tue, 11 Jun 2019 05:45:53 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 7E50A1C23E for ; Tue, 11 Jun 2019 05:45:52 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x5B3jop7007237; Mon, 10 Jun 2019 20:45:50 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=Er1sW564bZiz4OnOwarlToFdNi/Gm0zRVASwasPlu3A=; b=IgqfNC2h/W5GXDmsvie4fxR0BPDZPu/FfxmYhd5CDtCr3Np6lEjAT3mEM0f7CvlanEVm KYpp5TY5HvC8lJbMYFYcZ4l9vMrrCs88MR0uHtPfuvpiU+qyqc6rsPpIzwgsAZb78G5F ybzSIdAM8T899MXyVwxqTb3k/uK+0KisLAFmrJrY4vK0ghOywkyorWnzc0q4NFF/hc4Q U607gUuSkU3WaKa16TKl2/I0anH/N6J947+zDDCahAhRhAEHDdzsCksM/+axvQ4KHL0n sK/iC3gF+SvYQT5VeDIz24i+BKY3LFDWMwKkSqzMfXV5v7lFMZLseoOe5wSjx/8iwbGn 2w== Received: from sc-exch04.marvell.com ([199.233.58.184]) by mx0b-0016f401.pphosted.com with ESMTP id 2t20f4rwdb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Mon, 10 Jun 2019 20:45:50 -0700 Received: from SC-EXCH01.marvell.com (10.93.176.81) by SC-EXCH04.marvell.com (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Mon, 10 Jun 2019 20:45:48 -0700 Received: from NAM04-CO1-obe.outbound.protection.outlook.com (104.47.45.57) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Mon, 10 Jun 2019 20:45:48 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector2-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Er1sW564bZiz4OnOwarlToFdNi/Gm0zRVASwasPlu3A=; b=e1V56jNa2zh0gk82JSUtXde1Uk+WJSTzwdZgMEZFYIOWY8h0pCtjwu4jFKj0AnBEooFRxmB6CI2GgMvMRjM7UV0n6Clnp33AEEp5Elak20QpoEZR6gtcZN2YpQKWtNvDlbzykZAv3gTHVyhGEVQKMddXUkaI0ghxilQU0ur5OMs= Received: from MN2PR18MB2877.namprd18.prod.outlook.com (20.179.20.218) by MN2PR18MB2704.namprd18.prod.outlook.com (20.178.255.93) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1965.12; Tue, 11 Jun 2019 03:45:47 +0000 Received: from MN2PR18MB2877.namprd18.prod.outlook.com ([fe80::3d9b:ed4b:b155:9bad]) by MN2PR18MB2877.namprd18.prod.outlook.com ([fe80::3d9b:ed4b:b155:9bad%3]) with mapi id 15.20.1965.017; Tue, 11 Jun 2019 03:45:47 +0000 From: Anoob Joseph To: "Carrillo, Erik G" , Jerin Jacob Kollanukkaran , "Rao, Nikhil" , "Gujjar, Abhinandan S" , "Richardson, Bruce" , "De Lara Guarch, Pablo" CC: Narayana Prasad Raju Athreya , "dev@dpdk.org" , Lukas Bartosik , "Pavan Nikhilesh Bhagavatula" , Hemant Agrawal , Nipun Gupta , "Van Haaren, Harry" , =?iso-8859-1?Q?Mattias_R=F6nnblom?= , "Ma, Liang J" Thread-Topic: [EXT] Re: [dpdk-dev] [PATCH 24/39] eventdev: add Rx adapter init in eventmode Thread-Index: AQHVH5yv9dKZhXwOLkCJsjHVdL8RyaaV0Eww Date: Tue, 11 Jun 2019 03:45:47 +0000 Message-ID: References: <1559583160-13944-1-git-send-email-anoobj@marvell.com> <1559583160-13944-25-git-send-email-anoobj@marvell.com> In-Reply-To: Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [115.113.156.2] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 5fde4b2d-f88a-4008-9581-08d6ee1f4a65 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328)(7193020); SRVR:MN2PR18MB2704; x-ms-traffictypediagnostic: MN2PR18MB2704: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-forefront-prvs: 006546F32A x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(39860400002)(136003)(396003)(366004)(376002)(346002)(189003)(199004)(13464003)(6116002)(102836004)(110136005)(5660300002)(6506007)(71190400001)(99286004)(54906003)(55236004)(8936002)(53546011)(71200400001)(3846002)(74316002)(2906002)(316002)(86362001)(478600001)(81166006)(81156014)(14454004)(66946007)(66476007)(7736002)(6246003)(305945005)(76116006)(66066001)(7416002)(186003)(73956011)(66556008)(64756008)(26005)(229853002)(68736007)(66446008)(486006)(25786009)(33656002)(9686003)(4326008)(76176011)(476003)(7696005)(256004)(55016002)(52536014)(11346002)(6436002)(53936002)(446003)(921003)(1121003); DIR:OUT; SFP:1101; SCL:1; SRVR:MN2PR18MB2704; H:MN2PR18MB2877.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: BLAM7l/oLCLkPOYUn00AGUYp2imwg+QhDKgorP/9PvThBaCxcEcvCgtshkem7sPKXQ7RX8YhP74qCmWvN3IJpopu4TLkrWzLGIQtEBDoyxGWSmHS7lHdvI+sPgXo/lqAHW6jvDIWcQ1/dwg1KaZcguSMGIUflGb+g83w2HjMHVThGEw/CDZqh5ttQ12S0GQfRs7seEZCn1mRfbL3V1QJNui7MOC41aSZDN61c5m3ryDhyUpk2MBXqwfzHAR0naB09F1ee+bPTTatuDx449725n6u2hzyiOtkpDbg3Zzu71HBxu01AIT8DWWtNsrZhLmVX2aDbPMYxgmcsGPVnSt0Kb9gckxSIYXvYY/PqWFJfGyKsUrL1vtyXaZze7MgbmBA7uXz0WvuNfBi+cmV+Bs5SiMNJVXAVWmSc4AQNoPrrLM= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 5fde4b2d-f88a-4008-9581-08d6ee1f4a65 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Jun 2019 03:45:47.7632 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: anoobj@marvell.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR18MB2704 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-06-11_01:, , signatures=0 Subject: Re: [dpdk-dev] [EXT] Re: [PATCH 24/39] eventdev: add Rx adapter init in eventmode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Erik, Please see inline. Thanks, Anoob > -----Original Message----- > From: dev On Behalf Of Carrillo, Erik G > Sent: Monday, June 10, 2019 8:26 PM > To: Anoob Joseph ; Jerin Jacob Kollanukkaran > ; Rao, Nikhil ; Gujjar, > Abhinandan S ; Richardson, Bruce > ; De Lara Guarch, Pablo > > Cc: Narayana Prasad Raju Athreya ; dev@dpdk.org; > Lukas Bartosik ; Pavan Nikhilesh Bhagavatula > ; Hemant Agrawal > ; Nipun Gupta ; Van > Haaren, Harry ; Mattias R=F6nnblom > ; Ma, Liang J > Subject: [EXT] Re: [dpdk-dev] [PATCH 24/39] eventdev: add Rx adapter init= in > eventmode >=20 > External Email >=20 > ---------------------------------------------------------------------- > > -----Original Message----- > > From: Anoob Joseph > > Sent: Monday, June 3, 2019 12:32 PM > > To: Jerin Jacob ; Rao, Nikhil > > ; Carrillo, Erik G ; > > Gujjar, Abhinandan S ; Richardson, Bruce > > ; De Lara Guarch, Pablo > > > > Cc: Anoob Joseph ; Narayana Prasad > > ; dev@dpdk.org; Lukasz Bartosik > > ; Pavan Nikhilesh ; > > Hemant Agrawal ; Nipun Gupta > > ; Van Haaren, Harry > ; > > Mattias R=F6nnblom ; Ma, Liang J > > > > Subject: [PATCH 24/39] eventdev: add Rx adapter init in eventmode > > > > Adding rx adapter conf. The helper init routine would be initializing > > the rx adapter according to the conf. > > > > Signed-off-by: Anoob Joseph > > Signed-off-by: Lukasz Bartosik > > --- >=20 > <...Snipped...> >=20 > > diff --git a/lib/librte_eventdev/rte_eventmode_helper_internal.h > > b/lib/librte_eventdev/rte_eventmode_helper_internal.h > > index 2a6cd90..9c68605 100644 > > --- a/lib/librte_eventdev/rte_eventmode_helper_internal.h > > +++ b/lib/librte_eventdev/rte_eventmode_helper_internal.h > > @@ -35,6 +35,12 @@ > > /* Max event devices supported */ > > #define EVENT_MODE_MAX_EVENT_DEVS RTE_EVENT_MAX_DEVS > > > > +/* Max Rx adapters supported */ > > +#define EVENT_MODE_MAX_RX_ADAPTERS RTE_EVENT_MAX_DEVS > > + > > +/* Max Rx adapter connections */ > > +#define EVENT_MODE_MAX_CONNECTIONS_PER_ADAPTER 16 > > + > > /* Max event queues supported per event device */ #define > > EVENT_MODE_MAX_EVENT_QUEUES_PER_DEV > > RTE_EVENT_MAX_QUEUES_PER_DEV > > > > @@ -50,12 +56,33 @@ struct eventdev_params { > > uint8_t ev_queue_mode; > > }; > > >=20 > Should the struct below be named "rx_adapter_connection_info" since you > add "tx_adapter_connection_info" in a later patch? [Anoob] Yes. Will make this change in v2. >=20 > > +/* Rx adapter connection info */ > > +struct adapter_connection_info { > > + uint8_t ethdev_id; > > + uint8_t eventq_id; > > + int32_t ethdev_rx_qid; > > +}; > > + > > +/* Rx adapter conf */ > > +struct rx_adapter_conf { > > + int32_t eventdev_id; > > + int32_t adapter_id; > > + uint32_t rx_core_id; > > + uint8_t nb_connections; > > + struct adapter_connection_info > > + > > conn[EVENT_MODE_MAX_CONNECTIONS_PER_ADAPTER]; > > +}; > > + >=20 > <...Snipped...> >=20 > Regards, > Erik