From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B03DEC10DCE for ; Fri, 13 Mar 2020 16:50:20 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 186E8206B7 for ; Fri, 13 Mar 2020 16:50:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=intel.onmicrosoft.com header.i=@intel.onmicrosoft.com header.b="y5VS7Onp" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 186E8206B7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2F6631BF97; Fri, 13 Mar 2020 17:50:19 +0100 (CET) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id EED972BE3 for ; Fri, 13 Mar 2020 17:50:16 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Mar 2020 09:50:11 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,549,1574150400"; d="scan'208";a="322842395" Received: from orsmsx104.amr.corp.intel.com ([10.22.225.131]) by orsmga001.jf.intel.com with ESMTP; 13 Mar 2020 09:50:11 -0700 Received: from ORSEDG001.ED.cps.intel.com (10.7.248.4) by ORSMSX104.amr.corp.intel.com (10.22.225.131) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 13 Mar 2020 09:50:10 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.173) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 13 Mar 2020 09:50:10 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=M0Yq+Od/sSJSAdJCYLRP2mz/Mj4EDNMK9wi7hgguhPkZQ57sa2g/1aBmoLtrackiDhDeQ8TK6P30w1tG519J/yb4IDutLb7cwFc0+5zWlRYxuoM7ZJyFPNEaAiaqYeoDVJRYbURDRbWxy14PPQ2Vb3VkU6xt0V5PWLbvJ3aIOmP7eBqapTUrwV+x5sqW7fmNEwe55LgesUqWxlHfR2FRoqa+ahTBBfuKI+hRESxcuOBYD7SO5yfcRoVWIfa91Wms0wmRbtEAwKwNT7F3h/4T5oU3qn0g8UVNyn2CrCJ0c3wfA125rduviZMT9dSesbNSIgX9hfNUFY3U/rVpj6pQDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vwIUc5OkhyFMqOKEYjys1i1d3Fbk36bODAAXDJAx47I=; b=C4vkG7n+RDAAEsPAhEZljjhVb40W4pOiIVPbKRicsVVRNM245VxCudwyPcNgZSyqG0lH5uJHgGYuEKD4/h+xyug0IZ4kHoMQ//4svIyJkI0eYGBwtZY/pZ53A3UL/v8/bz57pudgpgh0ONhNMRf6YwLwha4hP2O2EwdNpeYyJ+U7Hv4lT0gpataMZADlRMa+4Z6N8FvBdoq8sH5zPBjjpeUR+nJzcpe+AHtshn2LYJNv0hJGs98fnxBooWkd+Eb1p2T0Wu7RTMGYUiLSn5cf4ymtzKfLpC5dKxLrVjQNdImFKh4MXOMXk0moub+8fIhOA8tIUbAwPTSXtlEyOPugrQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vwIUc5OkhyFMqOKEYjys1i1d3Fbk36bODAAXDJAx47I=; b=y5VS7Onp5bcg+WLGB83Y5hvrkSQpCR+WtP8HpZlf7kYCRtmhJzASt8rgbn1pxAMteiXzww76MCwzrM2K4Jmo72c3yN7hoWuLaVkr9PVmNVfsTmu1l7CHTlrmgYRI1IgOtrYdE57TfJ+IHWu3ak9utT9RVfHP/4kFMV/7ugbM1RU= Received: from MW3PR11MB4538.namprd11.prod.outlook.com (2603:10b6:303:57::12) by MW3PR11MB4700.namprd11.prod.outlook.com (2603:10b6:303:2d::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2793.16; Fri, 13 Mar 2020 16:50:07 +0000 Received: from MW3PR11MB4538.namprd11.prod.outlook.com ([fe80::d94d:d13e:f47a:29f8]) by MW3PR11MB4538.namprd11.prod.outlook.com ([fe80::d94d:d13e:f47a:29f8%3]) with mapi id 15.20.2793.018; Fri, 13 Mar 2020 16:50:07 +0000 From: "Stillwell Jr, Paul M" To: "Wang, Haiyue" , "dev@dpdk.org" , "Ye, Xiaolong" , "Zhang, Qi Z" , "Yang, Qiming" , "Xing, Beilei" CC: "Zhao1, Wei" Thread-Topic: [dpdk-dev] [PATCH v2 0/7] add Intel DCF PMD support Thread-Index: AQHV9qljPljSSGDfcUyQXpJG1Qa66KhGuKEggAACDICAAAUIkA== Date: Fri, 13 Mar 2020 16:50:07 +0000 Message-ID: References: <20200309141437.11800-1-haiyue.wang@intel.com> <20200310065029.40966-1-haiyue.wang@intel.com> <54faf82423d94f85a83298f9238b9ac1@intel.com> In-Reply-To: <54faf82423d94f85a83298f9238b9ac1@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.2.0.6 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: spf=none (sender IP is ) smtp.mailfrom=paul.m.stillwell.jr@intel.com; x-originating-ip: [192.55.52.218] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 532b2dcb-e09e-44ef-8f95-08d7c76e9640 x-ms-traffictypediagnostic: MW3PR11MB4700: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-forefront-prvs: 034119E4F6 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(136003)(366004)(346002)(376002)(39860400002)(396003)(199004)(55016002)(7696005)(26005)(86362001)(9686003)(8936002)(107886003)(81156014)(81166006)(71200400001)(4326008)(186003)(316002)(110136005)(8676002)(66476007)(66446008)(64756008)(66556008)(76116006)(966005)(5660300002)(6506007)(2906002)(66946007)(33656002)(478600001)(6636002)(52536014)(53546011)(921003)(1121003); DIR:OUT; SFP:1102; SCL:1; SRVR:MW3PR11MB4700; H:MW3PR11MB4538.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 0sb3Be/pkPkHGyDYQj4R37YVNQGXUMglMMB4OVTSdxJ+eKvPK7l54VVNmPPBQz9RpiK9cYSdOod2fk8/9GXB19v+1GG7HZiVRtZ1Z4o4zVNECvLTonD+1O6D7dUmRljgu2DT/cH/aTJQzXh1kjusVl0B/rSW/W+Dcj0+IYC9K+hvULyn/4bNxOvN3HsHHeZVVOHNyE7URqeNjxK8bwaOKPKgZUckm/U4wA4/HPQWHt6/Ey8JPvenQNe8psE8vM9rzNjP0whX6YhqOn9LVfSNwr/Ct0NSgMBNsQa25/hawl8IHlYaKvpXokGe0eaxNWaZAJXyr+oasQNrKND4eds56Yo/HT0YfADeRbjpoHy2RYmTtmVWuDN3NxKvCAbhCxfzxUT62jGUYIsn5SzZe29xKbooq1n6D7aJFWWKbjJZt6C/SC2syYitniJEtnw1I87pb8WHO3NxvECw3MaFtG50dGwxyfRmoHmSE70MA6R5or8voB+Pzean07ha75bUCQPvT7rWf7EK4E47ADbcxfn7X1EBLUZtJTYdLC7wWOY7sc4E8aU+xPYa6rD3pVkRJ5ls9/V5F8yb4OvcosXoz5KCnA== x-ms-exchange-antispam-messagedata: HbmXQ4Ae0MK3hsOJRJAEu+l1fV77mwERjAyhXgExnLINgADdgmeTPoB7JFbzu+TL3eLvW0YjuM7ec619pZtXudYEFHCcxsPX2VcON9TZONgrfzPign3z7DBAUy1CW85i/oHOjgNpok50V7NscSUcUw== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 532b2dcb-e09e-44ef-8f95-08d7c76e9640 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Mar 2020 16:50:07.6322 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: W5wvPTEc/rFyRgE5XEHd+OreWueSaMal0e6z4hPPigKk8WDw1AgUD8ikQFKsmWE/JUJaAZ4IU/GAt5+wuBsz0HMal+L6Nhx3unpzCRj5MpU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4700 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2 0/7] add Intel DCF PMD support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Haiyue, This statement is confusing to me "But the flow setting is the ice PF Admin= Q message, so the DCF shares most of ice PMD flow control." What do you mea= n by "flow setting"? The way I understand DCF working is that there is a tr= usted VF (the DCF) that is setting switch rules for other VFs on the same P= F. The mechanism for doing that is the DCF sends a virtchnl message to the = Linux kernel driver PF to add/delete a switch rule. None of this requires t= he ice PMD as far as I can tell. This seems like a driver just like the iav= f driver; the iavf driver is separate from the ice PMD and it seems like DC= F should also be separate. Paul > -----Original Message----- > From: Wang, Haiyue > Sent: Friday, March 13, 2020 9:25 AM > To: Stillwell Jr, Paul M ; dev@dpdk.org; Y= e, > Xiaolong ; Zhang, Qi Z ; > Yang, Qiming ; Xing, Beilei > Cc: Zhao1, Wei > Subject: RE: [dpdk-dev] [PATCH v2 0/7] add Intel DCF PMD support >=20 > Hi Paul, >=20 > Yes, it's VF (VF hardware initialization like virtchnl). But the flow set= ting is the > ice PF AdminQ message, so the DCF shares most of ice PMD flow control. >=20 > BR, > Haiyue >=20 > > -----Original Message----- > > From: Stillwell Jr, Paul M > > Sent: Saturday, March 14, 2020 00:19 > > To: Wang, Haiyue ; dev@dpdk.org; Ye, Xiaolong > > ; Zhang, Qi Z ; Yang, > > Qiming ; Xing, Beilei > > Cc: Zhao1, Wei ; Wang, Haiyue > > > > Subject: RE: [dpdk-dev] [PATCH v2 0/7] add Intel DCF PMD support > > > > I'm confused. Shouldn't the DCF be a separate driver since it is a VF, > > not part of a PF? You are starting to combine PF/VF code and I'm not su= re if > that is the correct way to go. > > > > Paul > > > > > -----Original Message----- > > > From: dev On Behalf Of Haiyue Wang > > > Sent: Monday, March 9, 2020 11:50 PM > > > To: dev@dpdk.org; Ye, Xiaolong ; Zhang, Qi Z > > > ; Yang, Qiming ; Xing, > > > Beilei > > > Cc: Zhao1, Wei ; Wang, Haiyue > > > > > > Subject: [dpdk-dev] [PATCH v2 0/7] add Intel DCF PMD support > > > > > > A DCF (Device Config Function) based approach is proposed where a > > > device bound to the device's VF0 can act as a sole controlling > > > entity to exercise advance functionality (such as switch, ACL) for re= st of > the VFs. > > > > > > The DCF works as a standalone PMD to support this function, which > > > shares the ice PMD flow control core function and the iavf virtchnl > > > mailbox core module. > > > > > > This patchset is based on: > > > [1] https://patchwork.dpdk.org/cover/66417/ : update ice base code > > > [2] https://patchwork.dpdk.org/cover/66472/ : iavf share code update > > > > > > Depends-on: series-8843 > > > Depends-on: series-8855 > > > > > > v2: > > > 1. update the iavf patchset link. > > > 2. split more patches for making this work be more understandable > > > 3. fix the log function usage, devargs checking from v1. > > > > > > Haiyue Wang (7): > > > net/iavf: stop the PCI probe in DCF mode > > > net/ice: add the DCF hardware initialization > > > net/ice: initiate to acquire the DCF capability > > > net/ice: handle the AdminQ command by DCF > > > net/ice: export the DDP definition symbols > > > net/ice: handle the PF initialization by DCF > > > net/ice: get the VF hardware index in DCF > > > > > > doc/guides/nics/ice.rst | 47 ++ > > > doc/guides/nics/img/ice_dcf.png | Bin 0 -> 39168 bytes > > > doc/guides/rel_notes/release_20_05.rst | 5 + > > > drivers/common/Makefile | 1 + > > > drivers/net/iavf/iavf_ethdev.c | 43 ++ > > > drivers/net/ice/Makefile | 6 + > > > drivers/net/ice/ice_dcf.c | 651 +++++++++++++++++++++++= ++ > > > drivers/net/ice/ice_dcf.h | 61 +++ > > > drivers/net/ice/ice_dcf_ethdev.c | 321 ++++++++++++ > > > drivers/net/ice/ice_dcf_ethdev.h | 33 ++ > > > drivers/net/ice/ice_dcf_parent.c | 344 +++++++++++++ > > > drivers/net/ice/ice_ethdev.c | 9 +- > > > drivers/net/ice/ice_ethdev.h | 8 + > > > drivers/net/ice/meson.build | 8 +- > > > mk/rte.app.mk | 1 + > > > 15 files changed, 1528 insertions(+), 10 deletions(-) create mode > > > 100644 doc/guides/nics/img/ice_dcf.png create mode 100644 > > > drivers/net/ice/ice_dcf.c create mode 100644 > > > drivers/net/ice/ice_dcf.h create mode 100644 > > > drivers/net/ice/ice_dcf_ethdev.c create mode 100644 > > > drivers/net/ice/ice_dcf_ethdev.h create mode 100644 > > > drivers/net/ice/ice_dcf_parent.c > > > > > > -- > > > 2.25.1 > > >=20