From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47D64C4363A for ; Thu, 29 Oct 2020 13:52:59 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 413DA2076A for ; Thu, 29 Oct 2020 13:52:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=intel.onmicrosoft.com header.i=@intel.onmicrosoft.com header.b="QgbImQ+m" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 413DA2076A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 051BECD82; Thu, 29 Oct 2020 14:52:56 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id B2DBCCD61; Thu, 29 Oct 2020 14:52:52 +0100 (CET) IronPort-SDR: 9CT6zckML1PjlCq08sGBqCXUdfQx/D8MsCHIzvVeWGjm6i3VykiRLVTSSkFMDkUwdJGo7r7yDY CT6nVXmu4Agw== X-IronPort-AV: E=McAfee;i="6000,8403,9788"; a="168564235" X-IronPort-AV: E=Sophos;i="5.77,430,1596524400"; d="scan'208";a="168564235" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Oct 2020 06:52:50 -0700 IronPort-SDR: yZBDuntncItGX0Dd+EImGZYIKj+hTHqwp7htSuZkE23clotA7Y0eojISBDjXzwuHBfygS65WqM njrY/fIrXetQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,430,1596524400"; d="scan'208";a="362101682" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga007.jf.intel.com with ESMTP; 29 Oct 2020 06:52:50 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 29 Oct 2020 06:52:49 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Thu, 29 Oct 2020 06:52:49 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.171) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Thu, 29 Oct 2020 06:52:49 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=m9D9xp3v5+tqc3JtAwuAxTecopm22VAeCrzuPeAlhUp+BYW/8fBv9oWrJU79g4eK4GuebbtqMAkhnamgIodnNOThKd/FO3zvNDdJSNFNbbrCRQnTO+jjavfeVAkIMxkPm42Ds0VF1567FosY5i5Cyfy4WMX5HxGzm9Qv9hqv1/T67NPxPImKPzjEweXs9DcBOfciUJ2xMnn3xQZAEMBoX/RkMDw4iD381vlOPBS1MrjIDEhSl4hsldp7dbgE8EEa4D+Rnsiz++p0idtn6NvhoHKW/SBp6xvQxBVyBGUILzHFtm6NUNiShJgLiTSuxg0lsCfBoIodZtoXpEY0PU6FYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+0unsZk1zXg/mTNWP2Sb9PKadur2A8wfbK6OlQfjTOs=; b=EF2s55wNCRFbuiv5dGxjcXtTGpn2VP1jwR0gce+Uq9ObU1SHT102cK/qvuGPcIDoAT+2Jcqe5X4HaxbyPCtlawF0jyvcYfOpvtTPJ7WzCwTy42L3FqvYBtGt2lqeiztMq5cRjJj4kAPntXXQa9bRxdMMO/uh4D4wJIp9yHHj8NbOYesebHqkgMVk8sS9nVhxqJ3WF4bvQ2lRIbK7MZgGpyDVOXdHCciYJZ0bpQTgIqUwn37H++M5W1+1aMVPfuiI20Srp0hsRMw08xX1uNVg1Y7dT9Dmiy1rh9loh32wuuus3lwvbEdAGoXrOg/dM3lue/7RikdV52XgPFoeeZi23w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+0unsZk1zXg/mTNWP2Sb9PKadur2A8wfbK6OlQfjTOs=; b=QgbImQ+mtTLt56UGUhvkYzxVVlinIySseaht27bG7HyiwLbE7qR11xmvpqd4dZK4YB/4zIVUq4bma8NPxKYoICi0p1ZFCAZpm5FLNDTSQoqIg9hbaFPkuhhy0wHpWYqrrxeV3icJn3YoLaYptlGGHEP5SjaLpu6q8noR1hLIDgk= Received: from MWHPR11MB1838.namprd11.prod.outlook.com (2603:10b6:300:10c::11) by CO1PR11MB4932.namprd11.prod.outlook.com (2603:10b6:303:98::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.18; Thu, 29 Oct 2020 13:52:46 +0000 Received: from MWHPR11MB1838.namprd11.prod.outlook.com ([fe80::20fb:cc03:ce89:f0ea]) by MWHPR11MB1838.namprd11.prod.outlook.com ([fe80::20fb:cc03:ce89:f0ea%7]) with mapi id 15.20.3499.027; Thu, 29 Oct 2020 13:52:46 +0000 From: "Gujjar, Abhinandan S" To: Honnappa Nagarahalli , "Richardson, Bruce" , "Akhil.goyal@nxp.com" , Ray Kinsella CC: "Ananyev, Konstantin" , "dev@dpdk.org" , "Doherty, Declan" , "techboard@dpdk.org" , "Vangati, Narender" , "jerinj@marvell.com" , nd Thread-Topic: [dpdk-techboard] [v4 1/3] cryptodev: support enqueue callback functions Thread-Index: AQHWq8khg/yqaE27MkanYRdfhPnwbqmrxnGAgADn6NCAAE1qgIAAGfCAgAAL9QCAAAL2AIABeSNw Date: Thu, 29 Oct 2020 13:52:46 +0000 Message-ID: References: <1603619090-118652-1-git-send-email-abhinandan.gujjar@intel.com> <1603619090-118652-2-git-send-email-abhinandan.gujjar@intel.com> <20201028151130.GD1634@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [103.5.135.70] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a9560980-dbaf-4026-22e1-08d87c11eaa7 x-ms-traffictypediagnostic: CO1PR11MB4932: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: klNvDjryYBbAmfI76ZrNBkHiSNxDB6Tzb+a/X6ZDxT+y3HNmTp64WMrsH0SetRM331vUfbDS0ZgBeFdV/6CHiy6J7zHnJI0b3+W3vgA3vKlWgr0ibOoE/haqAoRO/iYcpViFQauUwns2UK/6JqP8PF7LIHKtngWjakW2WeSPsloKoN/x8ufmkz2FMtUUbOvi3A5xp80Ix3YHIphJdpABpslHt1IEEGomsSKIFStnZHqLsLJCp4q23tJllqmHJJJHO5JpeBcTJ+7vXJPUzuVLSG5gxz3vYcQ+RKd5hZoaSYbJk9IvNcENl0Sm9PqHk0UVsWjnr/BuKCT4q7AdI9lAVQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR11MB1838.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(136003)(39860400002)(366004)(396003)(376002)(71200400001)(53546011)(6506007)(55236004)(7696005)(478600001)(316002)(54906003)(26005)(186003)(110136005)(2906002)(55016002)(9686003)(64756008)(66446008)(83380400001)(66476007)(76116006)(66556008)(8936002)(52536014)(66946007)(8676002)(5660300002)(33656002)(86362001)(4326008); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: 1amNXCGT8350rEQQ7efynhYWrnsi5r/APSwPZwr01RE1smutXhMGqphNAYWfSEJF4s2I1ANL/Db+WlMF4M6OMxXN2Lmt4rO0kyWi2vkUuTKi9fSxs7ZTv5xuboFczN6FfVl8IhG/3LaL2GKASUOGigvfFja8XB/fn8FUQ42TiSLC5/EwR+zLcfsgs8xCRSS3c59lp7W1atSiNPggmTF8hwXXBUOlPdlQ/3JDaPBI5EOCmAUCeQsUk5gNP/jp7reMZXdbkACbpiybG7xwBqzfVlnmd+eIQwYkjM+L3frSFn2VGGONjN3ZoFlVu0IHmVgon6+dMY8Mxa6Y8YUJ0mOGaV4A6QE/btOOUaI0RwYbD3gI/BT4sEiWPhow04FGaT1fqVjwQzL0J/Hi25YuKTb+uBhl+sLsJFZWo6EYvLU9AiNfwVP8IsbSDYfUMNF+5uUVT1Wo8i2CFKjg0gYO4b9EZCqG5RrGnenOAmbMP5eHqR5mr5sTTfdyPjNBpUKAQgymJHRBj+7A1bvhJYGRFKUhOmiycj7jvxE8NVW3rKTEG+6eEIaz7GZC8bb5Gls35h+ujVG5sNvMjDjgJF7mzrt/IETjr5odgsIqahuF2OOgVbxjxX6OPVvJgHjEFFgzSf2ekagLONYF7tmonjQFUBsc4g== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MWHPR11MB1838.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a9560980-dbaf-4026-22e1-08d87c11eaa7 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Oct 2020 13:52:46.4546 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 6PlR3rT2Q7VNFSXe0hhjlMIXZ8iiHm/JzwSI3ZqoPMCxzGjNB4mfpuBurZgdUt0FCGzl5yKnbKwnSQEar3vuQJBNVeTihATY2NHjfPzwNfQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB4932 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [dpdk-techboard] [v4 1/3] cryptodev: support enqueue callback functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Akhil, Any updates on this? Thanks Abhinandan > -----Original Message----- > From: Honnappa Nagarahalli > Sent: Wednesday, October 28, 2020 8:52 PM > To: Richardson, Bruce ; Akhil.goyal@nxp.com; > Ray Kinsella > Cc: Ananyev, Konstantin ; Gujjar, Abhinanda= n S > ; dev@dpdk.org; Doherty, Declan > ; techboard@dpdk.org; Vangati, Narender > ; jerinj@marvell.com; nd > Subject: RE: [dpdk-techboard] [v4 1/3] cryptodev: support enqueue callbac= k > functions >=20 > + Ray for ABI >=20 > >=20 > > > > On Wed, Oct 28, 2020 at 02:28:43PM +0000, Akhil Goyal wrote: > > > > > > Hi Konstantin, > > > > > > > > > Hi Tech board members, > > > > > > > > > > > > I have a doubt about the ABI breakage in below addition of fiel= d. > > > > > > Could you please comment. > > > > > > > > > > > > > /** The data structure associated with each crypto device. > > > > > > > */ struct rte_cryptodev { > > > > > > > dequeue_pkt_burst_t dequeue_burst; @@ -867,6 +922,10 > > @@ > > > > > > > struct rte_cryptodev { > > > > > > > __extension__ > > > > > > > uint8_t attached : 1; > > > > > > > /**< Flag indicating the device is attached */ > > > > > > > + > > > > > > > + struct rte_cryptodev_enq_cb_rcu *enq_cbs; > > > > > > > + /**< User application callback for pre enqueue processing > > > > > > > +*/ > > > > > > > + > > > > > > > } __rte_cache_aligned; > > > > > > > > > > > > Here rte_cryptodevs is defined in stable API list in map file > > > > > > which is a pointer To all rte_cryptodev and the above change > > > > > > is changing the size of the > > > > structure. > > > > > > > > While this patch adds new fields into rte_cryptodev structure, it > > > > doesn't change the size of it. > > > > struct rte_cryptodev is cache line aligned, so it's current size: > > > > 128B for 64-bit systems, and 64B(/128B) for 32-bit systems. > > > > So for 64-bit we have 47B implicitly reserved, and for 32-bit we > > > > have 19B reserved. > > > > That's enough to add two pointers without changing size of this str= uct. > > > > > > > > > > The structure is cache aligned, and if the cache line size in 32Byte > > > and the compilation is done on 64bit machine, then we will be left > > > with 15Bytes which is not sufficient for 2 pointers. > > > Do we have such systems? Am I missing something? > > > > > > > I don't think we support any such systems, so unless someone can point > > out a specific case where we need to support 32-byte CLs, I'd tend > > towards ignoring this as a non-issue. > Agree. I have not come across 32B cache line. >=20 > > > > > The reason I brought this into techboard is to have a consensus on > > > such change As rte_cryptodev is a very popular and stable structure. > > > Any changes to it may Have impacts which one person cannot judge all > > > use > > cases. > > > > > > > Haven't been tracking this discussion much, but from what I read here, > > this doesn't look like an ABI break and should be ok. > If we are filling the holes in the cache line with new fields, it should = not be an > ABI break. >=20 > > > > Regards, > > /Bruce