Re: [dpdk-dev] [EXT] Re: [PATCH v2] kni: increase kernel version requirement for VA

[Vamsi Krishna Attunuru <vattunuru@marvell.com>]

> -----Original Message-----
> From: Jerin Jacob <jerinjacobk@gmail.com>
> Sent: Thursday, November 21, 2019 7:28 AM
> To: David Marchand <david.marchand@redhat.com>
> Cc: Vamsi Krishna Attunuru <vattunuru@marvell.com>; Jerin Jacob
> Kollanukkaran <jerinj@marvell.com>; John McNamara
> <john.mcnamara@intel.com>; Marko Kovacevic
> <marko.kovacevic@intel.com>; dev <dev@dpdk.org>; Kiran Kumar
> Kokkilagadda <kirankumark@marvell.com>; Igor Ryzhov
> <iryzhov@nfware.com>; Ferruh Yigit <ferruh.yigit@intel.com>
> Subject: [EXT] Re: [dpdk-dev] [PATCH v2] kni: increase kernel version
> requirement for VA
> 
> External Email
> 
> ----------------------------------------------------------------------
> On Wed, Nov 20, 2019 at 10:59 PM David Marchand
> <david.marchand@redhat.com> wrote:
> >
> > On Wed, Nov 20, 2019 at 6:22 PM Ferruh Yigit <ferruh.yigit@intel.com>
> wrote:
> > >
> > > A build error reported related to the selected
> > > 'get_user_pages_remote()' kernel API:
> > >
> > > .../kernel/linux/kni/kni_dev.h:113:8:
> > >   error: too few arguments to function ‘get_user_pages_remote’
> > >   ret = get_user_pages_remote(tsk, tsk->mm, iova, 1
> > >         ^~~~~~~~~~~~~~~~~~~~~
> > >
> > > Currently there are three version of the 'get_user_pages_remote()'
> > > supported, based on kernel version
> > > < 4.9, = 4.9, > 4.9
> > >
> > > These version based checks are not working fine with the distro
> > > kernels which is the cause of reported build error. The error
> > > reported by the kernel version 4.8, but it is using API defined in > 4.9.
> > >
> > > To be able to take control of this, and possible more, related build
> > > error, increasing the minimum supported kernel version for iova=va
> > > with KNI to kernel version 4.9.
> > >
> > > This leaves us with single version of the kernel API and more
> > > manageable.
> > >
> > > Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> >
> > Jerin, Vamsi,
> >
> > Is this okay for you?
> 
> Acked-by: Jerin Jacob <jerinj@marvell.com>
> 

Acked-by: Vamsi Attunuru <vattunuru@marvell.com>
> 
> > Thanks.
> >
> >
> > --
> > David Marchand
> >