DPDK-dev Archive on lore.kernel.org
 help / color / Atom feed
From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
To: "Yigit, Ferruh" <ferruh.yigit@intel.com>,
	Akhil Goyal <akhil.goyal@nxp.com>, dpdk-dev <dev@dpdk.org>
Cc: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [dpdk-dev] DPDK Release Status Meeting 16/01/2020
Date: Fri, 17 Jan 2020 11:39:24 +0000
Message-ID: <SN6PR11MB2558C1FC817E6A0AEA5E44699A310@SN6PR11MB2558.namprd11.prod.outlook.com> (raw)

Hi lads,

> >>>>> * next-net-crypto
> >>>>>   * Pull request sent
> >>>>>   * There is a performance concern on some ipsec-gw patches,
> >>>>>     they can go in -rc2 if the issue is solved
> >>>>>   * CPU crypto from last release may be breaking ABI, need to confirm
> >>>>
> >>>> AFAIK, there is no ABI breakage.
> >>>
> >>> This is the output of validate-abi.sh.
> >>>
> >>> 	Change 							Effect
> >>> 1 Field sym_cpu_process has been added to this type. 	              1) This field will
> >> not be initialized by old clients.
> >>>                                                                                                                    2) Size of the
> >> inclusive type has been changed.
> >>>
> >>> 								NOTE: this
> >> field should be accessed only from the new library
> >>> functions, otherwise it may result in crash or incorrect behavior of applications.
> >>> 2 Size of this type has been changed from 128 bytes to 136 bytes. 	The
> >> fields or parameters of such data type may be incorrectly
> >>> initialized or accessed by old client applications.
> >>
> >> This is struct rte_cryptodev_ops, which is AFAIK, not part of public API.
> >> So not sure, why do you consider it as ABI breakage?
> >>
> >
> > If this is not an issue, than I am fine with it.
> 
> The ABI change between cryptodev and PMDs are allowed, that is contained within
> DPDK and not a user interface [1].
> 
> [1] Unless some inline functions are directly accessing the dev_ops, as
> (unfortunately) done in the ethdev.

Thanks Ferruh for confirmation.
For cryptodev we don't have such inline functions, plus the we add
new entry at the bottom of struct rte_cryptodev_ops, so I believe we
are safe here.

> 
> >
> >>>
> >>> Apart from that, IPSEC also has breakage, but that is experimental, so not an
> >> issue.
> >>>
> >>>>
> >>>>>     and discussed dummy variable is missing, may be postponed to next
> >> release
> >>>>
> >>>> Not sure I understand last sentence, could the author explain
> >>>> what dummy variables we are talking about.
> >>>
> >>> In one of the techboard meeting around 19.11 timeframe, during the
> >> discussion for approving methodology for CPU-crypto, it was
> >>> proposed that in order to avoid delay, a dummy variable can be introduced in
> >> cryptodev API/ABI to avoid any ABI breakage in
> >>> upcoming releases. But this was not done.
> >>
> >> Dummy variable for what?
> >> If you are talking about sym_cpu_process - we just added it into
> >> rte_cryptodev_ops, instead of
> >> ' struct rte_cryptodev' instead.
> >> That way we avoid any ABI breakage without introducing any churn in
> >> rte_cryptodev itself , see above.
> >
> > Then why was there so much resistance on this approach when there is no ABI breakage.
> > I thought there was ABI breakage because of this change.
> >
> > BTW this patchset is a bit late and it came after merge deadline 15 Jan.
> > Ideally all library related patches should go in RC1.
> > I would check if I could make it to the RC2.
> > I have 3 IPSec series to work on before RC2.
> >


             reply index

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-17 11:39 Ananyev, Konstantin [this message]
  -- strict thread matches above, loose matches on Subject: below --
2020-01-16 11:13 Ferruh Yigit
2020-01-16 12:48 ` Ananyev, Konstantin
2020-01-16 13:17   ` Akhil Goyal
2020-01-16 13:39     ` Ananyev, Konstantin
2020-01-16 16:42       ` Akhil Goyal
2020-01-16 17:47         ` Ferruh Yigit
2020-01-16 13:19 ` Akhil Goyal
2020-01-16 17:50   ` Ferruh Yigit
2020-01-17 16:00 ` Honnappa Nagarahalli

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=SN6PR11MB2558C1FC817E6A0AEA5E44699A310@SN6PR11MB2558.namprd11.prod.outlook.com \
    --to=konstantin.ananyev@intel.com \
    --cc=akhil.goyal@nxp.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK-dev Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/dpdk-dev/0 dpdk-dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dpdk-dev dpdk-dev/ https://lore.kernel.org/dpdk-dev \
		dev@dpdk.org
	public-inbox-index dpdk-dev

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git