From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0E6EC0650E for ; Wed, 3 Jul 2019 10:05:34 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 5793A218A0 for ; Wed, 3 Jul 2019 10:05:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=nxp.com header.i=@nxp.com header.b="Y3SPJZUj" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5793A218A0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nxp.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B60531B965; Wed, 3 Jul 2019 12:05:02 +0200 (CEST) Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30056.outbound.protection.outlook.com [40.107.3.56]) by dpdk.org (Postfix) with ESMTP id CAD1E1B95B; Wed, 3 Jul 2019 12:05:00 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6W6RZcylIoQTP2hcbT/AyO2SZyT02pZMoeOXCTeOWzE=; b=Y3SPJZUjChHQ2ehBYM3XsS3RXG9nF4hc49wNaPmlrdCO8Xw7JU/1gnH1A830QSpv7Nv4zjSIGMuvEL1WMemOEtgE1r+HDU3mxR3qPzX/nH4xMbKEuO5nhzPyIYeK8o9e4rEDDV0dNjnQPxaKCXM5Xni8XtAPIM2R2NgWzW3dtxw= Received: from VE1PR04MB6639.eurprd04.prod.outlook.com (20.179.235.82) by VE1PR04MB6479.eurprd04.prod.outlook.com (20.179.233.80) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2032.20; Wed, 3 Jul 2019 10:04:59 +0000 Received: from VE1PR04MB6639.eurprd04.prod.outlook.com ([fe80::a929:3d03:7bb7:d5e0]) by VE1PR04MB6639.eurprd04.prod.outlook.com ([fe80::a929:3d03:7bb7:d5e0%7]) with mapi id 15.20.2032.019; Wed, 3 Jul 2019 10:04:59 +0000 From: Akhil Goyal To: "Ananyev, Konstantin" , "Iremonger, Bernard" , "dev@dpdk.org" CC: "stable@dpdk.org" Thread-Topic: [PATCH v6 1/2] examples/ipsec-secgw: fix 1st pkt dropped for inline crypto Thread-Index: AQHVIS5r8sG9YVSumkyzkOG5VMHLPqaZhjuAgB9EOiA= Date: Wed, 3 Jul 2019 10:04:59 +0000 Message-ID: References: <1559819547-20742-1-git-send-email-bernard.iremonger@intel.com> <1560351121-21234-2-git-send-email-bernard.iremonger@intel.com> <2601191342CEEE43887BDE71AB97725801688E4E2C@IRSMSX104.ger.corp.intel.com> In-Reply-To: <2601191342CEEE43887BDE71AB97725801688E4E2C@IRSMSX104.ger.corp.intel.com> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=akhil.goyal@nxp.com; x-originating-ip: [92.120.1.65] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e48f73ef-7234-4eeb-cf20-08d6ff9de8b9 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(4618075)(2017052603328)(7193020); SRVR:VE1PR04MB6479; x-ms-traffictypediagnostic: VE1PR04MB6479: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-forefront-prvs: 00872B689F x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(136003)(39860400002)(346002)(376002)(396003)(366004)(199004)(189003)(52536014)(2501003)(256004)(4326008)(8676002)(81156014)(478600001)(71200400001)(71190400001)(305945005)(81166006)(73956011)(6506007)(446003)(33656002)(316002)(76176011)(14444005)(76116006)(2906002)(102836004)(26005)(186003)(74316002)(66476007)(25786009)(5660300002)(66446008)(8936002)(44832011)(6246003)(229853002)(66556008)(66946007)(7736002)(64756008)(110136005)(9686003)(11346002)(86362001)(6436002)(53936002)(3846002)(7696005)(486006)(99286004)(55016002)(14454004)(66066001)(68736007)(6116002)(476003); DIR:OUT; SFP:1101; SCL:1; SRVR:VE1PR04MB6479; H:VE1PR04MB6639.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: dacTDKJT/h5bBx5TJGwpdht3mZ4Uys0JHWbng0L2qjjEgRG05feBDyRlYTcgjH512ui0jRpTE1R7JKjWj/05eQ05XgolRjR6SOKD/Cl8GcubsAawue9ea0FLDygt+QlaExNLFzXswz3cWKRqNdGXJm8Ex2Sj41n3tHy+ZvtaMSGm0UW8Tt63thT+jn1CekwoV4TEMxdl+3Dp+Fu8O/BV2Feeup7io4BzVuoK9A2i6T5LJjfGrUcLqXOS4NOr2kxieqMqWJuhN8v0ORnabantjL1CAaEGH5X+honYzODGGwXmEAwmmJyy1grVM2toQ0gqNG6gKhcvValyi8TRcbexze7nwO7wp5pGuVl4qFTNsgApSY3E1zIf64mUOPAcROwBXrlKfcAl2Bph9G7y5Kk1WUAeiS8zMcneu6WTvb+KNhA= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: e48f73ef-7234-4eeb-cf20-08d6ff9de8b9 X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Jul 2019 10:04:59.7774 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: akhil.goyal@nxp.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6479 Subject: Re: [dpdk-dev] [PATCH v6 1/2] examples/ipsec-secgw: fix 1st pkt dropped for inline crypto X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Bernard, > > > > Inline crypto installs a flow rule in the NIC. This flow > > rule must be installed before the first inbound packet is > > received. > > > > The create_session() function installs the flow rule, > > create_session() has been refactored into create_inline_session() > > and create_lookaside_session(). The create_inline_session() function > > uses the socket_ctx data and is now called at initialisation in > > sa_add_rules(). > > > > The max_session_size() function has been added to calculate memory > > requirements. > > > > The cryprodev_init() function has been refactored to drop calls to > > rte_mempool_create() and to drop calculation of memory requirements. > > > > The main() function has been refactored to call max_session_size() and > > to call session_pool_init() and session_priv_pool_init() earlier. > > The ports are started now before adding a flow rule in main(). > > The sa_init(), sp4_init(), sp6_init() and rt_init() functions are > > now called after the ports have been started. > > > > The rte_ipsec_session_prepare() function is called in fill_ipsec_sessio= n() > > for inline which is called from the ipsec_sa_init() function. > > > > Fixes: ec17993a145a ("examples/ipsec-secgw: support security offload") > > Fixes: d299106e8e31 ("examples/ipsec-secgw: add IPsec sample applicatio= n") > > Cc: stable@dpdk.org > > > > Signed-off-by: Bernard Iremonger > > --- >=20 > Acked-by: Konstantin Ananyev > Tested-by: Konstantin Ananyev >=20 This patch need to be rebased. However, I will try to work on your v5 in next few days if I get time. If I= don't get time to fix that, will need you to send a rebased version of thi= s patch. Thanks, Akhil