[dpdk-dev] [PATCH 1/5] doc/guides/cryptodevs: cleanup for armv8 and openssl PMDs

[dpdk-dev] [PATCH 1/5] doc/guides/cryptodevs: cleanup for armv8 and openssl PMDs

[Thierry Herbelot]

The perf tests were removed in a previous commit.

Fixes: 2ac67c32837a ('test/crypto: remove crypto perf tests')
Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com>
---
 doc/guides/cryptodevs/armv8.rst   | 1 -
 doc/guides/cryptodevs/openssl.rst | 1 -
 2 files changed, 2 deletions(-)

diff --git a/doc/guides/cryptodevs/armv8.rst b/doc/guides/cryptodevs/armv8.rst
index e60af84002a3..1ab40096e349 100644
--- a/doc/guides/cryptodevs/armv8.rst
+++ b/doc/guides/cryptodevs/armv8.rst
@@ -59,7 +59,6 @@ User can use app/test application to check how to use this PMD and to verify
 crypto processing.
 
 Test name is cryptodev_sw_armv8_autotest.
-For performance test cryptodev_sw_armv8_perftest can be used.
 
 Limitations
 -----------
diff --git a/doc/guides/cryptodevs/openssl.rst b/doc/guides/cryptodevs/openssl.rst
index d7269870b610..7407294813b2 100644
--- a/doc/guides/cryptodevs/openssl.rst
+++ b/doc/guides/cryptodevs/openssl.rst
@@ -87,7 +87,6 @@ User can use app/test application to check how to use this pmd and to verify
 crypto processing.
 
 Test name is cryptodev_openssl_autotest.
-For performance test cryptodev_openssl_perftest can be used.
 For asymmetric crypto operations testing, run cryptodev_openssl_asym_autotest.
 
 To verify real traffic l2fwd-crypto example can be used with this command:
-- 
2.11.0

[dpdk-dev] [PATCH 2/5] crypto/mvsam: fix typo

[Thierry Herbelot]

Inverted letters.

Fixes: 8a61c83af2fae ('crypto/mrvl: add mrvl crypto driver')
Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com>
---
 drivers/crypto/mvsam/rte_mrvl_pmd_ops.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/crypto/mvsam/rte_mrvl_pmd_ops.c b/drivers/crypto/mvsam/rte_mrvl_pmd_ops.c
index ef520356ff14..f6bf2cd4c535 100644
--- a/drivers/crypto/mvsam/rte_mrvl_pmd_ops.c
+++ b/drivers/crypto/mvsam/rte_mrvl_pmd_ops.c
@@ -727,7 +727,7 @@ mrvl_crypto_pmd_sym_session_get_size(__rte_unused struct rte_cryptodev *dev)
 /** Configure the session from a crypto xform chain (PMD ops callback).
  *
  * @param dev Pointer to the device structure.
- * @param xform Pointer to the crytpo configuration structure.
+ * @param xform Pointer to the crypto configuration structure.
  * @param sess Pointer to the empty session structure.
  * @returns 0 upon success, negative value otherwise.
  */
-- 
2.11.0

[dpdk-dev] [PATCH 3/5] doc/prog_guides: fix triplicated typo

[Thierry Herbelot]

A bad formula was copied and pasted.

Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com>
---
 doc/guides/prog_guide/bbdev.rst         | 2 +-
 doc/guides/prog_guide/cryptodev_lib.rst | 2 +-
 doc/guides/prog_guide/rawdev.rst        | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/doc/guides/prog_guide/bbdev.rst b/doc/guides/prog_guide/bbdev.rst
index 658ffd400a01..dfa0ef67d0c8 100644
--- a/doc/guides/prog_guide/bbdev.rst
+++ b/doc/guides/prog_guide/bbdev.rst
@@ -44,7 +44,7 @@ From the command line using the --vdev EAL option
 
    --vdev 'baseband_turbo_sw,max_nb_queues=8,socket_id=0'
 
-Our using the rte_vdev_init API within the application code.
+Or using the rte_vdev_init API within the application code.
 
 .. code-block:: c
 
diff --git a/doc/guides/prog_guide/cryptodev_lib.rst b/doc/guides/prog_guide/cryptodev_lib.rst
index 23fa5bc188f7..9bbf207646e8 100644
--- a/doc/guides/prog_guide/cryptodev_lib.rst
+++ b/doc/guides/prog_guide/cryptodev_lib.rst
@@ -52,7 +52,7 @@ From the command line using the --vdev EAL option
 
    Example: ``--vdev  'crypto_aesni_mb0' --vdev  'crypto_aesni_mb1'``
 
-Our using the rte_vdev_init API within the application code.
+Or using the rte_vdev_init API within the application code.
 
 .. code-block:: c
 
diff --git a/doc/guides/prog_guide/rawdev.rst b/doc/guides/prog_guide/rawdev.rst
index 42c195cefa23..06af6942a6df 100644
--- a/doc/guides/prog_guide/rawdev.rst
+++ b/doc/guides/prog_guide/rawdev.rst
@@ -100,7 +100,7 @@ From the command line using the --vdev EAL option
 
    --vdev 'rawdev_dev1'
 
-Our using the rte_vdev_init API within the application code.
+Or using the rte_vdev_init API within the application code.
 
 .. code-block:: c
 
-- 
2.11.0

[dpdk-dev] [PATCH 4/5] doc/guides: fix grammar

[Thierry Herbelot]

A copy'n'paste typo was present in three guides.

Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com>
---
 doc/guides/prog_guide/bbdev.rst         | 2 +-
 doc/guides/prog_guide/compressdev.rst   | 2 +-
 doc/guides/prog_guide/cryptodev_lib.rst | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/doc/guides/prog_guide/bbdev.rst b/doc/guides/prog_guide/bbdev.rst
index dfa0ef67d0c8..12e948a20e3d 100644
--- a/doc/guides/prog_guide/bbdev.rst
+++ b/doc/guides/prog_guide/bbdev.rst
@@ -284,7 +284,7 @@ baseband operations is usually completed during the enqueue call to the bbdev
 device. The dequeue burst API will retrieve any processed operations available
 from the queue on the bbdev device, from physical devices this is usually
 directly from the device's processed queue, and for virtual device's from a
-``rte_ring`` where processed operations are place after being processed on the
+``rte_ring`` where processed operations are placed after being processed on the
 enqueue call.
 
 
diff --git a/doc/guides/prog_guide/compressdev.rst b/doc/guides/prog_guide/compressdev.rst
index a06c835a03c7..07332d0048f9 100644
--- a/doc/guides/prog_guide/compressdev.rst
+++ b/doc/guides/prog_guide/compressdev.rst
@@ -568,7 +568,7 @@ operations is usually completed during the enqueue call to the compression
 device. The dequeue burst API will retrieve any processed operations available
 from the queue pair on the compression device, from physical devices this is usually
 directly from the devices processed queue, and for virtual device's from a
-``rte_ring`` where processed operations are place after being processed on the
+``rte_ring`` where processed operations are placed after being processed on the
 enqueue call.
 
 A burst in DPDK compression can be a combination of stateless and stateful operations with a condition
diff --git a/doc/guides/prog_guide/cryptodev_lib.rst b/doc/guides/prog_guide/cryptodev_lib.rst
index 9bbf207646e8..2839244c50bb 100644
--- a/doc/guides/prog_guide/cryptodev_lib.rst
+++ b/doc/guides/prog_guide/cryptodev_lib.rst
@@ -304,7 +304,7 @@ Crypto operations is usually completed during the enqueue call to the Crypto
 device. The dequeue burst API will retrieve any processed operations available
 from the queue pair on the Crypto device, from physical devices this is usually
 directly from the devices processed queue, and for virtual device's from a
-``rte_ring`` where processed operations are place after being processed on the
+``rte_ring`` where processed operations are placed after being processed on the
 enqueue call.
 
 
-- 
2.11.0

[dpdk-dev] [PATCH 5/5] drivers/{bus,crypto}: fix typo

[Thierry Herbelot]

Fix another copy'n'paste typo.

Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com>
---
 drivers/bus/fslmc/qbman/include/fsl_qbman_portal.h | 2 +-
 drivers/crypto/caam_jr/caam_jr.c                   | 2 +-
 drivers/crypto/dpaa_sec/dpaa_sec.c                 | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/bus/fslmc/qbman/include/fsl_qbman_portal.h b/drivers/bus/fslmc/qbman/include/fsl_qbman_portal.h
index 07b8a4372f24..c35dafedbc38 100644
--- a/drivers/bus/fslmc/qbman/include/fsl_qbman_portal.h
+++ b/drivers/bus/fslmc/qbman/include/fsl_qbman_portal.h
@@ -15,7 +15,7 @@
  * - Enqueue, including setting the enqueue descriptor, and issuing enqueue
  *   command etc.
  * - Dequeue, including setting the dequeue descriptor, issuing dequeue command,
- *   parsing the dequeue response in DQRR and memeory, parsing the state change
+ *   parsing the dequeue response in DQRR and memory, parsing the state change
  *   notifications etc.
  * - Release, including setting the release descriptor, and issuing the buffer
  *   release command.
diff --git a/drivers/crypto/caam_jr/caam_jr.c b/drivers/crypto/caam_jr/caam_jr.c
index 5028bd2a4c94..77c0303476ba 100644
--- a/drivers/crypto/caam_jr/caam_jr.c
+++ b/drivers/crypto/caam_jr/caam_jr.c
@@ -70,7 +70,7 @@ static inline void
 caam_jr_op_ending(struct caam_jr_op_ctx *ctx)
 {
 	PMD_INIT_FUNC_TRACE();
-	/* report op status to sym->op and then free the ctx memeory  */
+	/* report op status to sym->op and then free the ctx memory  */
 	rte_mempool_put(ctx->ctx_pool, (void *)ctx);
 }
 
diff --git a/drivers/crypto/dpaa_sec/dpaa_sec.c b/drivers/crypto/dpaa_sec/dpaa_sec.c
index d9a7cd8a4266..122c80a072ff 100644
--- a/drivers/crypto/dpaa_sec/dpaa_sec.c
+++ b/drivers/crypto/dpaa_sec/dpaa_sec.c
@@ -61,7 +61,7 @@ dpaa_sec_op_ending(struct dpaa_sec_op_ctx *ctx)
 		ctx->op->status = RTE_CRYPTO_OP_STATUS_ERROR;
 	}
 
-	/* report op status to sym->op and then free the ctx memeory  */
+	/* report op status to sym->op and then free the ctx memory  */
 	rte_mempool_put(ctx->ctx_pool, (void *)ctx);
 }
 
-- 
2.11.0

Re: [dpdk-dev] [PATCH 4/5] doc/guides: fix grammar

[Rami Rosen]

Acked-by: Rami Rosen <ramirose@gmail.com>

Re: [dpdk-dev] [PATCH 4/5] doc/guides: fix grammar

[Trahe, Fiona]

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thierry Herbelot
> Sent: Wednesday, May 22, 2019 10:45 AM
> To: dev@dpdk.org
> Cc: Thomas Monjalon <thomas@monjalon.net>
> Subject: [dpdk-dev] [PATCH 4/5] doc/guides: fix grammar
> 
> A copy'n'paste typo was present in three guides.
> 
> Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com>
Acked-by: Fiona Trahe <fiona.trahe@intel.com>

Re: [dpdk-dev] [PATCH 3/5] doc/prog_guides: fix triplicated typo

[Trahe, Fiona]

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thierry Herbelot
> Sent: Wednesday, May 22, 2019 10:45 AM
> To: dev@dpdk.org
> Cc: Thomas Monjalon <thomas@monjalon.net>
> Subject: [dpdk-dev] [PATCH 3/5] doc/prog_guides: fix triplicated typo
> 
> A bad formula was copied and pasted.
> 
> Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com>
> ---
Acked-by: Fiona Trahe <fiona.trahe@intel.com>

Re: [dpdk-dev] [PATCH 2/5] crypto/mvsam: fix typo

[Tomasz Duszynski]

On Wed, May 22, 2019 at 11:44:46AM +0200, Thierry Herbelot wrote:
> Inverted letters.
>
> Fixes: 8a61c83af2fae ('crypto/mrvl: add mrvl crypto driver')
> Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com>
> ---
>  drivers/crypto/mvsam/rte_mrvl_pmd_ops.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/crypto/mvsam/rte_mrvl_pmd_ops.c b/drivers/crypto/mvsam/rte_mrvl_pmd_ops.c
> index ef520356ff14..f6bf2cd4c535 100644
> --- a/drivers/crypto/mvsam/rte_mrvl_pmd_ops.c
> +++ b/drivers/crypto/mvsam/rte_mrvl_pmd_ops.c
> @@ -727,7 +727,7 @@ mrvl_crypto_pmd_sym_session_get_size(__rte_unused struct rte_cryptodev *dev)
>  /** Configure the session from a crypto xform chain (PMD ops callback).
>   *
>   * @param dev Pointer to the device structure.
> - * @param xform Pointer to the crytpo configuration structure.
> + * @param xform Pointer to the crypto configuration structure.
>   * @param sess Pointer to the empty session structure.
>   * @returns 0 upon success, negative value otherwise.
>   */
> --
> 2.11.0
>

Thanks for catching this.
Acked-by: Tomasz Duszynski <tdu@semihalf.com>

Re: [dpdk-dev] [PATCH 1/5] doc/guides/cryptodevs: cleanup for armv8 and openssl PMDs

[Akhil Goyal]

> 
> The perf tests were removed in a previous commit.
> 
> Fixes: 2ac67c32837a ('test/crypto: remove crypto perf tests')
> Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com>
> ---
Acked-by: Akhil Goyal <akhil.goyal@nxp.com>

Re: [dpdk-dev] [PATCH 1/5] doc/guides/cryptodevs: cleanup for armv8 and openssl PMDs

[Akhil Goyal]

> The perf tests were removed in a previous commit.
> 
> Fixes: 2ac67c32837a ('test/crypto: remove crypto perf tests')
> Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com>
> ---
>  doc/guides/cryptodevs/armv8.rst   | 1 -
>  doc/guides/cryptodevs/openssl.rst | 1 -
>  2 files changed, 2 deletions(-)
> 
Acked-by: Akhil Goyal <akhil.goyal@nxp.com>

Please add fixes line for every fix that you do. It was missing in a couple of your patches.

Cc: stable@dpdk.org
Patchset applied to dpdk-next-crypto

Thanks.